bvandeusenandClaude Opus 5.5
914f31359c
CI & Build / Python lint (push) Successful in 5s
CI & Build / Plugin hooks (push) Successful in 17s
CI & Build / TypeScript typecheck (push) Successful in 57s
CI & Build / integration (push) Successful in 1m19s
CI & Build / Python tests (push) Successful in 2m2s
CI & Build / Build & push image (push) Successful in 15s
Docstrings, section headers and assertion messages drop the record number, milestone or step that introduced the behaviour, and incident accounts are restated as the present-tense failure shape. A dead pointer to a design doc that is not in the repo is removed. Renamed to the property they check: test_the_old_shape_would_be_caught -> test_a_rank_then_scope_query_is_caught test_a_ledger_repeat_no_longer_produces_that_case_at_all -> test_a_ledger_repeat_is_counted_not_withheld test_the_header_no_longer_promises_once_per_session -> test_the_header_explains_the_seen_marker test_the_portal_case_no_longer_stamps_one_canon_onto_a_whole_file -> test_one_canon_is_not_stamped_onto_a_whole_file test_the_repos_own_prose_no_longer_defines_with -> test_the_repos_own_prose_does_not_define_with test_the_original_regression_create_note_with_content -> test_the_real_server_refuses_content_on_create_note Fixture and example ids stay: "note 5" in a supersession chain, "rule 156" in an illustrative question, `#2275` as the hex-versus-citation case, `#3244` as the example of a bare number, fixed dates in date-filter tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
100 lines
3.8 KiB
Python
100 lines
3.8 KiB
Python
from unittest.mock import AsyncMock, patch
|
|
|
|
import pytest
|
|
from tests.helpers import fake_note
|
|
|
|
|
|
pytestmark = pytest.mark.usefixtures("_bind_user")
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_create_task_passes_kind():
|
|
# kind=plan is retired (plans are milestones); 'issue' exercises passthrough.
|
|
mock = AsyncMock(return_value=fake_note(task_kind="issue"))
|
|
with patch("scribe.mcp.tools.tasks.notes_svc.create_note", mock):
|
|
from scribe.mcp.tools.tasks import create_task
|
|
await create_task(title="P", kind="issue")
|
|
assert mock.call_args.kwargs["task_kind"] == "issue"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_list_tasks_passes_kind_filter():
|
|
mock = AsyncMock(return_value=([], 0))
|
|
with patch("scribe.mcp.tools.tasks.notes_svc.list_notes", mock):
|
|
from scribe.mcp.tools.tasks import list_tasks
|
|
await list_tasks(kind="plan")
|
|
assert mock.call_args.kwargs["task_kind"] == "plan"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_list_tasks_kind_empty_means_no_filter():
|
|
mock = AsyncMock(return_value=([], 0))
|
|
with patch("scribe.mcp.tools.tasks.notes_svc.list_notes", mock):
|
|
from scribe.mcp.tools.tasks import list_tasks
|
|
await list_tasks()
|
|
assert mock.call_args.kwargs["task_kind"] is None
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_create_task_passes_spike():
|
|
"""The kind a failed rule-check asks for.
|
|
|
|
Time-boxed, and its output is knowledge rather than a change — filing one
|
|
as `work` makes a finished investigation look like an abandoned change.
|
|
"""
|
|
mock = AsyncMock(return_value=fake_note(task_kind="spike"))
|
|
with patch("scribe.mcp.tools.tasks.notes_svc.create_note", mock):
|
|
from scribe.mcp.tools.tasks import create_task
|
|
await create_task(title="Can the runner be given a bash shell?", kind="spike")
|
|
assert mock.call_args.kwargs["task_kind"] == "spike"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_update_task_can_re_file_a_kind():
|
|
"""A task's kind must be CORRECTABLE, not write-once.
|
|
|
|
What a piece of work turns out to be is often clear only once it is under
|
|
way. Without a `kind` parameter on `update_task`, and with a REST route that
|
|
drops the field the editor sends, the save reports success and reverts on
|
|
reload.
|
|
"""
|
|
mock = AsyncMock(return_value=fake_note(task_kind="spike"))
|
|
with patch("scribe.mcp.tools.tasks.notes_svc.update_note", mock):
|
|
from scribe.mcp.tools.tasks import update_task
|
|
await update_task(task_id=1, kind="spike")
|
|
assert mock.call_args.kwargs["task_kind"] == "spike"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_update_task_leaves_kind_alone_when_not_given():
|
|
""""" means leave unchanged, as it does for every other field here."""
|
|
mock = AsyncMock(return_value=fake_note())
|
|
with patch("scribe.mcp.tools.tasks.notes_svc.update_note", mock):
|
|
from scribe.mcp.tools.tasks import update_task
|
|
await update_task(task_id=1, title="renamed")
|
|
assert "task_kind" not in mock.call_args.kwargs
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_minting_a_plan_is_refused_at_both_doors():
|
|
"""`plan` is a valid stored value and NOT a mintable one.
|
|
|
|
Historical plan-tasks carry it and must stay writable, so the column
|
|
keeps accepting it — but plans became milestones in 0066, so no door
|
|
hands out a new one. The error names start_planning rather than just
|
|
refusing, because a caller reaching for kind='plan' wants a plan.
|
|
"""
|
|
from scribe.services.notes import minted_kind
|
|
|
|
with pytest.raises(ValueError, match="start_planning"):
|
|
minted_kind("plan")
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_an_unknown_kind_raises_rather_than_defaulting():
|
|
"""A silently-corrected kind is the defect this whole fix exists to end."""
|
|
from scribe.services.notes import minted_kind
|
|
|
|
with pytest.raises(ValueError, match="kind must be one of"):
|
|
minted_kind("investigation")
|