bvandeusenandClaude Opus 5.5
0f5ef0be63
CI & Build / Python lint (push) Successful in 3s
CI & Build / Plugin hooks (push) Successful in 12s
CI & Build / TypeScript typecheck (push) Successful in 56s
CI & Build / integration (push) Successful in 1m4s
CI & Build / Python tests (push) Successful in 1m55s
CI & Build / Build & push image (push) Successful in 44s
Step 2 of the Scribe -> Grimoire rename. - src/scribe -> src/grimoire, and every import, patch target, module path, hypercorn entry point and `python -m grimoire.restore` with it; pyproject, uv.lock and the frontend package are named grimoire. - Image git.fabledsword.com/bvandeusen/fabledgrimoire; CI's Postgres service runs as grimoire / grimoire_test. - Compose files default the DB user, database and (prod) volume to grimoire, each overridable from .env, so an install created as Scribe keeps its data by setting POSTGRES_USER, POSTGRES_DB and PGDATA_VOLUME. - Backups are written as grimoire-<ts>.tar with format grimoire-backup-tar. Archives named scribe-* with the scribe-backup-tar manifest still restore and are still counted at the destination (folder and S3), with tests. - Exports, the MCP auth realm, the ASGI scope key and the persistent logger carry the new name. Kept on purpose: the secret-sealing key label stays "scribe.secrets.v1", because every stored secret was derived under it. Plugin identity (plugin name, hooks, env vars, .scribe marker, skills) is step 3. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
93 lines
3.4 KiB
Python
93 lines
3.4 KiB
Python
"""Guessed record ids are refused; `{{ref:N}}` placeholders resolve.
|
|
|
|
The failure: a session predicts the ids its next creates will get and writes
|
|
them into a body before the records exist; any other session's create takes
|
|
those numbers. These pin the recogniser — what counts as a `#N`, where a guess
|
|
can sit relative to the highest id — and the placeholder rewrite the batch
|
|
create uses instead of guessing.
|
|
"""
|
|
from unittest.mock import AsyncMock, patch
|
|
|
|
import pytest
|
|
|
|
from grimoire.services import record_refs
|
|
from grimoire.services.record_refs import (
|
|
GUESS_WINDOW,
|
|
cited_ids,
|
|
placeholder_keys,
|
|
resolve_placeholders,
|
|
)
|
|
|
|
|
|
@pytest.mark.parametrize(("text", "expected"), [
|
|
("see #12 and (#34)", {12, 34}),
|
|
("#7 at the start", {7}),
|
|
("an entity { is not a reference", set()),
|
|
("a fragment page#12 is not one", set()),
|
|
("a colour #123abc is not one", set()),
|
|
("path/#9 is not one", set()),
|
|
("", set()),
|
|
])
|
|
def test_cited_ids_reads_standalone_hash_numbers_only(text, expected):
|
|
assert cited_ids(text) == expected
|
|
|
|
|
|
def test_cited_ids_ignores_none_among_texts():
|
|
assert cited_ids(None, "#5", None) == {5}
|
|
|
|
|
|
async def test_a_number_just_above_the_highest_id_is_a_guess():
|
|
with patch.object(record_refs, "_max_note_id", AsyncMock(return_value=100)):
|
|
assert await record_refs.guessed_ids("next is #101, then #102") == [101, 102]
|
|
|
|
|
|
async def test_existing_ids_and_far_numbers_are_not_guesses():
|
|
"""Below the max is a real record; far above it is not a Grimoire id at all
|
|
(a PR, a forge issue) — neither may be refused."""
|
|
far = 100 + GUESS_WINDOW + 1
|
|
with patch.object(record_refs, "_max_note_id", AsyncMock(return_value=100)):
|
|
assert await record_refs.guessed_ids(f"#1 #100 #{far}") == []
|
|
|
|
|
|
async def test_the_window_edge_is_still_a_guess():
|
|
edge = 100 + GUESS_WINDOW
|
|
with patch.object(record_refs, "_max_note_id", AsyncMock(return_value=100)):
|
|
assert await record_refs.guessed_ids(f"#{edge}") == [edge]
|
|
|
|
|
|
async def test_text_without_references_never_queries():
|
|
"""Most writes cite nothing; they must not pay a query for it."""
|
|
probe = AsyncMock(return_value=100)
|
|
with patch.object(record_refs, "_max_note_id", probe):
|
|
await record_refs.refuse_guessed_ids("no numbers here", None, "")
|
|
probe.assert_not_awaited()
|
|
|
|
|
|
async def test_refusal_names_the_guess_and_the_fix():
|
|
with patch.object(record_refs, "_max_note_id", AsyncMock(return_value=100)):
|
|
with pytest.raises(ValueError) as exc:
|
|
await record_refs.refuse_guessed_ids("steps #101 and #103")
|
|
message = str(exc.value)
|
|
assert "#101, #103" in message
|
|
assert "create_records" in message and "{{ref:N}}" in message
|
|
|
|
|
|
def test_placeholder_keys_tolerates_spacing():
|
|
assert placeholder_keys("{{ref:1}} {{ ref: 2 }} {{ref:milestone}}") == {"1", "2", "milestone"}
|
|
|
|
|
|
def test_resolve_placeholders_rewrites_every_occurrence():
|
|
refs = {"1": '#40 "first"', "milestone": 'milestone 9 "plan"'}
|
|
out = resolve_placeholders("{{ref:1}} then {{ref:1}} in {{ref:milestone}}", refs)
|
|
assert out == '#40 "first" then #40 "first" in milestone 9 "plan"'
|
|
|
|
|
|
def test_resolve_placeholders_passes_empty_through():
|
|
assert resolve_placeholders(None, {}) is None
|
|
assert resolve_placeholders("", {}) == ""
|
|
|
|
|
|
def test_an_unknown_key_is_a_caller_bug_not_a_silent_leftover():
|
|
with pytest.raises(KeyError):
|
|
resolve_placeholders("{{ref:3}}", {"1": "#1"})
|