from unittest.mock import AsyncMock, patch import pytest from tests.helpers import fake_task pytestmark = pytest.mark.usefixtures("_bind_user") @pytest.fixture(autouse=True) def _no_plan_gate(): """The plan gate reads the database; the tests that are about it re-patch it.""" with patch("scribe.mcp.tools.tasks.dedup_svc.plan_gate", AsyncMock(return_value=None)): yield @pytest.mark.asyncio async def test_start_planning_tool_delegates_to_service(): payload = {"milestone": {"id": 5}, "applicable_rules": [], "project_rules": [], "applicable_rules_truncated": False, "project_goal": "", "open_task_count": 0} with patch("scribe.mcp.tools.tasks.planning_svc.start_planning", AsyncMock(return_value=payload)) as mock: from scribe.mcp.tools.tasks import start_planning out = await start_planning(project_id=3, title="Plan it") assert out["milestone"]["id"] == 5 # No body and no steps reach the service as None, so it seeds the template # and takes the single-milestone path. assert mock.call_args.kwargs == { "user_id": 7, "project_id": 3, "title": "Plan it", "body": None, "steps": None, } @pytest.mark.asyncio async def test_start_planning_returns_the_plan_that_already_covers_it(): """The FabledLibrarian failure (milestone 415): a session that could not see the existing plan made a second one. Now it is handed the first, and nothing is created.""" match = {"duplicate": True, "existing_id": 12} svc = AsyncMock() with patch("scribe.mcp.tools.tasks.dedup_svc.plan_gate", AsyncMock(return_value=match)) as gate, \ patch("scribe.mcp.tools.tasks.dedup_svc.find_duplicate_note", AsyncMock()) as steps, \ patch("scribe.mcp.tools.tasks.planning_svc.start_planning", svc): from scribe.mcp.tools.tasks import start_planning out = await start_planning(project_id=3, title="Metadata", body="design", steps=[{"title": "Resolve editions", "body": "via providers"}]) assert out is match svc.assert_not_awaited() steps.assert_not_awaited() # The candidate is judged by its steps as well as its design. assert gate.call_args.args[:3] == (7, 3, "Metadata") assert "design" in gate.call_args.args[3] assert "Resolve editions\nvia providers" in gate.call_args.args[3] @pytest.mark.asyncio async def test_force_creates_the_plan_without_asking_the_gate(): gate = AsyncMock(return_value={"duplicate": True}) with patch("scribe.mcp.tools.tasks.dedup_svc.plan_gate", gate), \ patch("scribe.mcp.tools.tasks.planning_svc.start_planning", AsyncMock(return_value={"milestone": {"id": 5}})) as svc: from scribe.mcp.tools.tasks import start_planning out = await start_planning(project_id=3, title="Metadata", force=True) assert out["milestone"]["id"] == 5 svc.assert_awaited_once() gate.assert_not_awaited() @pytest.mark.asyncio async def test_get_task_augments_plan_with_rules(): applicable = {"rules": [{"id": 1, "title": "r"}], "truncated": False, "project_rules": [{"id": 3, "title": "own"}]} with patch("scribe.mcp.tools.tasks.notes_svc.get_note_for_user", AsyncMock(return_value=(fake_task(task_kind="plan", id=9, project_id=3), "owner"))), \ patch("scribe.mcp.tools.tasks.rulebooks_svc.get_applicable_rules", AsyncMock(return_value=applicable)): from scribe.mcp.tools.tasks import get_task out = await get_task(task_id=9) assert out["applicable_rules"] == [{"id": 1, "title": "r"}] assert out["project_rules"] == [{"id": 3, "title": "own"}] assert "subscribed_rulebooks" not in out assert out["applicable_rules_truncated"] is False @pytest.mark.asyncio async def test_get_task_work_kind_has_no_rules(): with patch("scribe.mcp.tools.tasks.notes_svc.get_note_for_user", AsyncMock(return_value=(fake_task(task_kind="work", id=9, project_id=3), "owner"))), \ patch("scribe.mcp.tools.tasks.rulebooks_svc.get_applicable_rules", AsyncMock()) as mock_rules: from scribe.mcp.tools.tasks import get_task out = await get_task(task_id=9) assert "applicable_rules" not in out assert not mock_rules.called