"""services/notes.py — the inline embedding moved here from the routes (#2056).

Why it moved: embedding was triggered at each REST route and nowhere else, so a
record created through MCP stayed out of semantic search and auto-inject until
the next restart's backfill. Putting it in the service means every caller — REST,
MCP, recurrence, snippets — gets it by construction rather than by remembering.

These test the helper directly. The point of the change is that there is now ONE
place to test.
"""
from scribe.services import notes as notes_svc

# --- inline embedding (#2056) -----------------------------------------------

def test_embed_note_uses_the_OWNER_not_the_caller():
    """LOAD-BEARING for shared records. An embedding belongs to the record; a
    collaborator editing a shared note must refresh the owner's row rather than
    mint a second one under their own id. The routes this replaced passed the
    caller's uid on one path and the owner's on another — exactly the kind of
    inconsistency that moving it to one place removes."""
    from unittest.mock import MagicMock, patch

    note = MagicMock(id=5, user_id=42, title="T", body="B")
    with patch("scribe.services.embeddings.upsert_note_embedding") as upsert, \
         patch("asyncio.create_task") as create_task:
        notes_svc.embed_note(note)

    assert create_task.called
    upsert.assert_called_once()
    assert upsert.call_args.args[0] == 5
    assert upsert.call_args.args[1] == 42          # owner, never the caller
    assert upsert.call_args.args[2] == "T\nB"


def test_embed_note_skips_a_record_with_no_text():
    """An empty embedding is worse than none — it is a row that matches nothing
    and hides the fact that the record was never indexed."""
    from unittest.mock import MagicMock, patch

    note = MagicMock(id=5, user_id=42, title="", body="")
    with patch("asyncio.create_task") as create_task:
        notes_svc.embed_note(note)
    assert not create_task.called


def test_embed_note_without_a_running_loop_is_not_an_error():
    """Unit tests and scripts call create_note with no event loop. That must be
    an ordinary case: a write that succeeded cannot be failed by its index
    refresh."""
    from unittest.mock import MagicMock, patch

    note = MagicMock(id=5, user_id=42, title="T", body="B")
    with patch("asyncio.create_task", side_effect=RuntimeError("no running loop")):
        notes_svc.embed_note(note)          # must not raise


def test_embed_note_swallows_an_indexing_failure():
    """Same reason, wider net: the embedding model being unavailable must not
    turn a successful save into a 500."""
    from unittest.mock import MagicMock, patch

    note = MagicMock(id=5, user_id=42, title="T", body="B")
    with patch("asyncio.create_task", side_effect=ValueError("model gone")):
        notes_svc.embed_note(note)          # must not raise