"""update_task closes a task with a one-line reminder of what the report needs. The in-band half of milestone 409 step 3: the skill and static context only exist in the Claude Code plugin, and a tool response reaches every MCP client at the moment a piece of work closes. Pinned on the response, not the wording. Step 4 adds the operator's own completion-report preferences beside the cue, retrieved at that same moment — and only then, and only when there are any. """ from unittest.mock import AsyncMock, MagicMock, patch import pytest pytestmark = pytest.mark.usefixtures("_bind_user") _PREF = {"id": 41, "title": "Say how it was checked", "statement": "…", "kind": "preference"} async def _update(prefs=None, **kwargs): from scribe.mcp.tools.tasks import update_task note = MagicMock(id=5, user_id=7, project_id=3) note.to_dict.return_value = {"id": 5} lookup = AsyncMock(return_value=list(prefs or [])) with patch("scribe.mcp.tools.tasks.notes_svc.update_note", AsyncMock(return_value=note)), \ patch("scribe.mcp.tools.tasks.systems_tools.attach_systems", AsyncMock()), \ patch("scribe.mcp.tools.tasks.placement_svc.attach_placement", AsyncMock()), \ patch("scribe.mcp.tools.tasks.reply_prefs_svc.completion_preferences", lookup): return await update_task(task_id=5, **kwargs), lookup @pytest.mark.parametrize("status", ["done", "cancelled"]) async def test_closing_a_task_carries_the_cue(status): out, _ = await _update(status=status) assert "placement" in out["report_back"] and "needs them" in out["report_back"] @pytest.mark.parametrize("kwargs", [{"status": "in_progress"}, {"status": "todo"}, {"body": "more notes"}]) async def test_other_updates_do_not(kwargs): out, lookup = await _update(prefs=[_PREF], **kwargs) assert "report_back" not in out and "reply_preferences" not in out lookup.assert_not_awaited() async def test_closing_hands_back_the_operators_report_preferences(): out, lookup = await _update(prefs=[_PREF], status="done") assert out["reply_preferences"] == [_PREF] # The cue says the key is there, so it never arrives unexplained. assert "reply_preferences" in out["report_back"] lookup.assert_awaited_once_with(7, project_id=3) async def test_no_preferences_means_no_key_and_the_plain_cue(): from scribe.mcp.tools.tasks import REPORT_BACK_CUE out, _ = await _update(prefs=[], status="done") assert "reply_preferences" not in out assert out["report_back"] == REPORT_BACK_CUE