Two milestones: a note can carry its own check (317), and a rule keeps what it used to say (323) #135

Merged
bvandeusen merged 23 commits from dev into main 2026-08-31 00:01:15 -04:00
Showing only changes of commit 255c43a8fe - Show all commits
+8 -11
View File
@@ -35,10 +35,13 @@ OWNER_USERNAME = "rule_history_owner"
async def constraint(): async def constraint():
"""One rule carrying a check, with no history yet. """One rule carrying a check, with no history yet.
Cleanup is in this fixture's own teardown, never in an autouse one: CLEANED UP AT SETUP, NOT TEARDOWN, and that is forced. `update_rule` fires
`_dispose_engine` arrives through usefixtures, so it tears down BEFORE an a detached `asyncio.create_task(upsert_rule_embedding(...))` that opens
autouse fixture would, and a database call after that point orphans a its own connection and UPDATEs the rule row. A teardown that deleted the
pooled connection and breaks the NEXT test to touch Postgres (#3240). rulebook would race it: the delete cascade-locks the rule the embedding
task is writing, and Postgres kills one of them with a deadlock. Purging
at setup instead runs on a fresh loop, after the previous test's loop
closed and cancelled whatever it left in flight.
""" """
async with async_session() as s: async with async_session() as s:
owner = await ensure_user(s, OWNER_USERNAME) owner = await ensure_user(s, OWNER_USERNAME)
@@ -60,13 +63,7 @@ async def constraint():
verify_with="read the workflow's shell setting", verify_with="read the workflow's shell setting",
) )
yield {"uid": uid, "rule_id": rule.id} return {"uid": uid, "rule_id": rule.id}
async with async_session() as s:
row = await s.get(Rulebook, book.id)
if row is not None:
await s.delete(row)
await s.commit()
async def _versions(rule_id: int) -> list[RuleVersion]: async def _versions(rule_id: int) -> list[RuleVersion]: