4 Commits

Include renames

Author	SHA1	Message	Date
bvandeusenandClaude Opus 5.5	ba0b56018e	docs(6209): calibration stamp, after-write hook, usage seam, work log, duplicates, skill structure, tuning and rulebook routes, kind surface, prompt filter, moments, strict args, auth, lesson write path ... Fourteen more test files: docstrings state the failure each guard defends as a present-tense shape instead of the incident that found it, and issue, milestone and rule numbers leave comments and assertion messages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-21 21:35:44 -04:00
bvandeusenandClaude Opus 5.5	5c6d9a7b55	fix(mcp): a tool's refusal reaches the agent with its reason (#4794) ... SDK 2.x passes on only a ToolError's text. Any other exception becomes UnexpectedToolError("Error executing tool X") and its message stays on the server. ValueError is how every Scribe tool refuses — what was refused, why, what to do instead — so every refusal reached the agent bare, and it could only retry blind. Seen live: tune_retrieval(actor="operator") and judge_menu(verdicts=[]) both answered "Error executing tool …" and nothing else. StrictArgsMCPServer.call_tool re-raises an UnexpectedToolError caused by a ValueError as a ToolError carrying the message, in the SDK's own "Error executing tool X: <reason>" shape. Other exceptions are crashes and stay masked. The stale comment claiming the SDK returns ValueError text is corrected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-03 21:31:10 -04:00
bvandeusenandClaude Opus 5.5	c26b7f248e	feat(mcp): port the server to MCP Python SDK v2 (FastMCP → MCPServer) (#2196) ... - server.py: `mcp.server.mcpserver.MCPServer`; StrictArgsFastMCP becomes StrictArgsMCPServer, whose call_tool takes and forwards v2's `context` and raises ToolError (the SDK logs anything else as an unexpected crash; the message reaches the caller either way). - stateless_http and transport_security moved from the constructor to `streamable_http_app(...)` in mount_mcp, with their reasons. - Per-request user identity is unchanged: the contextvar set around the ASGI call reaches the handler on both v2 paths (legacy stateless spawns from the request task; the 2026-07-28 modern path opens its task group inside the request). - pyproject: mcp[cli]>=2.2, no ceiling (installs are --locked). uv.lock regenerated with --upgrade-package mcp in the ci-python image: only mcp and its own dependencies moved (106 → 110 packages). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-09-24 07:21:27 -04:00
bvandeusenandClaude Fable 5	d6c9f08a59	fix(mcp): reject undeclared tool arguments instead of silently dropping them (#2709) ... FastMCP validates tool arguments with a pydantic model whose extra-field policy is 'ignore', so create_note(content=...) — a plausible near-miss for body=, primed by add_task_log's content — ran successfully, stored body: '', and left a record embedding/search cannot see. Two real notes were persisted body-less before the pattern was noticed; create_task only 'worked' because those calls happened to use the right name. StrictArgsFastMCP rejects any tool call carrying arguments the tool does not declare, before dispatch, with a did-you-mean hint when one is close and the declared list when none is. Applied at the dispatch seam so every tool gets the guarantee — an error the caller sees once beats data half-written forever. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-17 12:54:58 -04:00