11 Commits

Include renames

Author	SHA1	Message	Date
bvandeusenandClaude Opus 5	bd60d679d9	refactor(theme): remove 184 var() fallbacks — every one was unreachable ... #2277 counted ~150 "raw colour literals bypassing the tokens". Measuring them told a different story: 184 sat in `var(--token, #fallback)` position, and a check against theme.css shows every one of those tokens IS declared. So the fallbacks could not render. Not drift — vestigial. They were also not this palette. The most common were Tailwind and Flat-UI defaults — #6366f1 indigo, #22c55e green, #f59e0b amber, #3b82f6 blue, #e74c3c and #27ae60 — a second, unsanctioned colour scheme sitting in the codebase looking like the app's colours to anyone reading it. Removing them is not tidying. #2319's lesson is that a fallback is WORSE than a missing token: a missing token renders as nothing and someone eventually notices, while a fallback renders something plausible forever. These 184 were one token rename away from silently repainting the app in Tailwind. The design token check would catch the rename — but the fallback is precisely the thing that would make it invisible if the check were ever bypassed. Literal count 152 -> 45, which matters beyond the number: a report that is mostly unreachable noise is one people stop reading, and then it stops working while still passing. What remains should be genuinely worth looking at. Done with a paren-aware transform, not a regex — `var(--x, rgba(0,0,0,.5))` nests parens and `[^)]+` would cut at the first one and leave `))` behind. Verified after: every changed line is a fallback strip and nothing else, and every var() reference still resolves. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UaYUaouG9jjhATyuxCKrQs	2026-08-03 11:52:04 -04:00
bvandeusenandClaude Opus 5	c7cf07824a	refactor(ui): the two workspace panels migrate onto the shared buttons ... Eighteen bespoke button rules across the two densest components, replaced by composition in the template. Net -279 lines. These files are where the size taxonomy earns itself: almost every button here is an inline affordance — a dismiss ×, a confirm tick, an add-chip — sitting inside a card or a line of text. Forcing them to the standard 8/16px would have broken the layouts, which is why the previous commit measured the clusters before assuming a button is a button. What the migration left behind is the useful signal. Each residual rule is now one line stating only what the shared classes genuinely cannot: .btn-add { font-size: 1rem; } a '+' glyph, not a label .btn-search-clear { padding: 0; flex-shrink: 0; } sits in the field .btn-suggest-tags { flex-shrink: 0; align-self: center; } .btn-delete-task { margin-left: 0.25rem; } Four residuals were deleted rather than kept, because the shared sheet already said the same thing: a disabled opacity, two hover colours, and a danger-outline hover fill. Keeping them would have recreated the drift in miniature. Two accent hovers went with them. .btn-suggest-tags tinted its border and label with the accent on hover, which is the same house-style violation corrected in f491b6d — it survived that pass because it was a hover, not a fill. .btn-tag-suggestion and .btn-chip-link stay bespoke, deliberately. They are tag-shaped rather than button-shaped, and the house style does put the accent on tags — so they are not drift, they are a different component wearing a btn- prefix. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UaYUaouG9jjhATyuxCKrQs	2026-08-01 22:44:21 -04:00
bvandeusenandClaude Opus 5	f491b6d7b9	refactor(ui): action buttons stop wearing the accent ... 21 buttons filled with --color-primary, which resolves to Scribe's violet accent: every auth Submit (Login, Register, Invite, Forgot, Reset), plus Invite, Add, Confirm, Restore, Generate, Log-save, Subtask-confirm, Toggle-open, the modal primary, the version-restore, the inline-assist button, the milestone-plan actions, the task-advance hover, and both empty-state CTAs. The house style is explicit that the accent never appears on an action button: action colours are universal across the family precisely so a Save button looks identical in every app, while the accent carries identity. Doing both makes the accent mean two things and neither clearly. Operator's call, and the reasoning is worth keeping: the violet-on-Scribe- actions treatment was a deliberate early choice to give the web UI its own personality, made when much more of the app was user-facing. That is no longer true, so consistency is now worth more than the distinction it was buying. Found in two passes, which is the part worth noting. The first scan looked for `.btn-*` and found 13. Seven more were the same thing under different names — .modal-btn-primary, .vh-btn-restore, .inline-assist-btn, .empty-action, .task-advance-btn — plus .ms-plan-actions .btn-primary, a compound override flagged in the previous commit. Searching by naming convention finds what was named consistently, which is never the whole set. Deliberately NOT changed: progress-bar fills, active tab / page / selection states, tag-pill hover, the duration badge, the skip link, the assist pulse. Those are identity and active-state, which is exactly where the accent belongs. After this the accent appears only there, which is what makes it read as identity rather than as decoration. Colour swaps only — 25 lines changed, no geometry, no structure, no templates. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UaYUaouG9jjhATyuxCKrQs	2026-08-01 22:13:58 -04:00
bvandeusenandClaude Opus 5	4c9a637507	fix(theme): text on a filled colour needs its own token — the old one inverts ... 76 hardcoded `color: #fff` now resolve to --fs-text-on-action, a new token that is parchment in BOTH modes. The design system said they should supersede to --fs-text-primary, on the recorded reasoning that "there is no 'text on action' colour, there is just the text colour." That is true on dark and wrong on light. --fs-text-primary inverts to #14171A; the surfaces underneath it do not invert at all — every one of these 76 sits on an action colour, a semantic colour, the accent, or the CTA gradient, all of which hold a single value across modes. Sweeping as recorded would have put obsidian text on moss green: roughly 2.4:1, against a house style whose stated floor is WCAG AA. It would have looked correct to me, because I checked it in the mode where it was correct. --color-accent-fg had the same defect independently and is repointed too. The token check now reports zero superseded literals, down from 30 files, and raw colour literals drop 246 -> 169. Closes #2275. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UaYUaouG9jjhATyuxCKrQs	2026-07-31 22:40:58 -04:00
bvandeusenandClaude Opus 4.7	30dfbce426	fix(typography): strip chrome italic; reserve italic for emphasis ... Per the design rule "italic is for emphasis, not for design", removed every chrome `font-style: italic` declaration across the frontend. 42 declarations gone across 24 files: empty-state placeholder copy, loading messages, "no results" hints, ghost text, voice/role labels, field placeholder text, brand wordmark, et al. Markdown content emphasis is unaffected — `<em>` and `<i>` tags from `*emphasis*` markup still render italic via browser default styling (prose.css doesn't override em behavior). User-typed emphasis in notes, journal entries, and chat messages keeps its italic. Specific spots that lost the decorative italic: - KnowledgeView .filter-label, .empty-narrator - NoteEditorView .ef-label, link-suggest related - ChatPanel .empty-msg, .empty-greeting, .role-label - ChatMessage .role-assistant .role-label (the "Fable" voice tag — was italic per the doc's Illuminated Transcript spec, but per the new typography rule the speaker tag stays regular and lets the border-left + glow do the bubble framing on their own) - AppHeader .brand-text ("Fabled" wordmark) - editor-shared.css .title-input::placeholder - ProjectView .project-title-input::placeholder - HomeView .urgency-loading - WorkspaceTaskPanel .empty-group - WeatherCard .weather-unavailable - SharedWithMeView .empty-msg - DiffView empty-state spans - ToolCallCard .tool-event-more - SettingsView 7 spots (.you-label, .geo-pending, hint text, etc.) - + several other empty-state / hint text spots Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-04-28 07:54:26 -04:00
bvandeusenandClaude Opus 4.7	ff498ce1a4	feat(design): surface phase PR 5 — Project + Workspace polish ... Per the surface-phase spec for the Project list, Project view, and 3-panel Workspace cluster: Button reclassification per Hybrid rule - ProjectView: - btn-workspace ("Open Workspace"): kept on accent gradient — the workspace is the project's central feature moment, a Scribe- flavored action, brand moment per the doc. - btn-share: muted-outline → Bronze action-secondary - btn-danger-outline (Delete project): generic-border + danger-on- hover → Oxblood outline + filled hover (proper destructive) - btn-save-panel: accent gradient → Moss action-primary - btn-ms-confirm (milestone confirm): flat accent → Moss - btn-ms-cancel: ghost → Bronze action-secondary - .modal-btn-danger: --color-danger → --color-action-destructive - ProjectListView: - btn-primary ("+ New Project"): flat accent → Moss action-primary. Empty-state CTA (.empty-action) keeps accent — that *is* a brand moment per Hybrid, "create your first project". - WorkspaceTaskPanel + WorkspaceNoteEditor: - btn-delete-task / btn-delete: hover --color-danger → Oxblood - btn-delete-confirm / btn-confirm-delete: --color-danger pair → --color-action-destructive pair, with filled hover for stronger affordance - btn-save (WorkspaceNoteEditor): flat accent → Moss - WorkspaceChatWidget: - History toggle: replaced unicode ▾ with Lucide ChevronDown (PR 1 carry-over for emoji-as-icon) Two-weights-only - Snapped every font-weight 600/700 to 500 across the cluster. Borders kept (per structural-not-decorative rule) - Milestone group cards: standalone containers, keep - Project cards in list: standalone containers, keep - Task slide-over panel: drawer modal, keep - Workspace 3-panel separators: major section dividers, keep Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-04-27 23:09:33 -04:00
bvandeusenandClaude Opus 4.7	93a3beb5d6	feat(design): surface phase PR 1 — Lucide icon migration + scale enforcement ... Replaces every hand-inlined SVG in the chrome (60 across 15 files) with Lucide components. Snaps icon sizes to the doc's 16/24 scale — all icons in this pass land at 16. AppLogo wordmark stays as the legitimate "custom app icon" exception per the doc; GraphView's <svg> mount point for D3 stays as well. Replaces emoji-as-icons in clear button-affordance cases with their Lucide equivalents: ✕ → X (close/dismiss buttons across 8 files), ✓ → Check (ProjectView task-advance button), 🎤 → Mic (ChatPanel voice CTA), 📎 → Paperclip (ChatView context toggle), &uarr; → ArrowUp (ChatInputBar Send), &times; → X (ChatPanel context-note remove), ☀/☾ → Sun/Moon (AppHeader theme toggle). Inline emoji punctuation in textual confirmation copy ("Saved ✓", "Created ✓", `done: "✓"` status maps, `'✓' : '📄'` interpolations) is left for surface-phase voice/tone touchups — replacing requires structural template changes and is best done per-component. Stroke weight stays at Lucide's default 2px; tightening to the doc's 1.5/1 is deferred per the surface-phase spec (option ii: drop-in + scale enforcement). Adds lucide-vue-next ^0.469.0 to frontend/package.json. Docker rebuild handles the install. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-04-27 19:56:01 -04:00
bvandeusenandClaude Sonnet 4.6	71301f631d	Workspace UI overhaul: rail note panel, split task detail, project goal header ... - WorkspaceNoteEditor: replace toggling list/editor views with always-visible left rail (155px) showing note list alongside editor pane; persist last-open note per project in localStorage (workspace_note_{projectId}) - WorkspaceTaskPanel: add priority dot + due date on task rows; replace full overlay detail with bottom-split (44% list / 56% detail); close button replaces back nav; active row highlighted; fade transition - WorkspaceView: show project goal in header instead of 'Workspace'; non-equal panel widths (0.8fr / 1.1fr / 1.1fr); empty chat quick-action chips (Project status / New note / Add tasks); prefill() helper Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-03-10 23:51:17 -04:00
bvandeusenandClaude Sonnet 4.6	ef141f07f8	UI polish pass: word count, slash commands, task lists, graph peek, bulk delete, export ... - WordCount component (toggle words/chars vs read time, persisted mode) - TipTap: TaskList/TaskItem extensions, slash command menu (H1-H3, lists, code, quote, task) - Markdown serializer: task list → `- [ ]` / `- [x]` roundtrip - GraphView: slide-in peek panel for note/task nodes (body, tags, linked nodes); tag nodes still navigate - ChatView: bulk-select conversations with two-click confirm delete + chat retention policy (default 90d) - NoteEditorView: pill tab bar with animated edit/preview toggle + WordCount in toolbar - WorkspaceNoteEditor: inline search with tag matching, inline new-note creation, WordCount - WorkspaceTaskPanel: task body rendered in slide-over + Edit link - Settings: data export (Markdown ZIP / JSON) via GET /api/export - Accessibility: skip-to-content link, aria-labels on all icon-only buttons - Fix: export route used non-existent fabledassistant.database — corrected to async_session() - Fix: ToolCallRecord.status type now includes "running" (was causing TS build error) - Dockerfile: upgrade npm to latest before install to suppress major-version notice - npm audit fix: patched minimatch (ReDoS) and rollup (path traversal) — 0 vulnerabilities Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-03-07 23:15:01 -05:00
bvandeusenandClaude Sonnet 4.6	320e879788	Workspace polish: milestone selector, streaming fix, push fix, log quieting ... - WorkspaceTaskPanel: add milestone <select> in task detail (PATCH /api/notes/:id), replace delete ✕ with trash can SVG icon - WorkspaceView: scroll to bottom when streaming ends so final message is visible without a page refresh - ToolCallCard: fix search_notes result count (was reading data.total; tool returns data.count), so results no longer show "0 found" - push.py: switch from deprecated WebPusher().send(vapid_private_key=...) to webpush() function (pywebpush 2.x API compatibility) - app.py: downgrade /api/health, /api/chat/status, and static asset requests from INFO to DEBUG in after_request logger to reduce log noise at default log level Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-03-07 12:58:09 -05:00
bvandeusenandClaude Sonnet 4.6	74ebb8a87f	Project Workspace view, abort button, session invalidation, workspace fixes ... Workspace (/workspace/:projectId): - Three-panel layout (tasks / chat / notes) with CSS grid collapse toggles - WorkspaceTaskPanel: tasks grouped by milestone, collapsible groups, task detail slide-over with status cycling, TaskLogSection work log, and inline-confirm delete - WorkspaceNoteEditor: list view (sorted by updated_at, inline tag pills, inline-confirm delete) with editor view (TipTap, TagInput, Suggest tags, 60s autosave) - Persistent workspace conversation stored in localStorage per project; reused on return visits - Thinking enabled (think: true) with Reasoning block in streaming bubble - workspace_project_id backend pipeline: chat.py → generation_task.py → llm.py; system prompt uses project title so agent passes project="Title" to tools (fixes create_note failing with numeric project string) - SSE tool-call watcher bridges agent actions to panel updates - Height fix: workspace-root uses height 100%; app-content switches to overflow hidden via :has() selector - Entry point: "Open Workspace" button on ProjectView Abort button: - Stop button in ChatView header and WorkspaceView input bar - Calls existing cancelGeneration() / POST .../generation/cancel Session invalidation: - POST /api/auth/invalidate-sessions bumps session_version, keeps current session alive; useful after SSO/OAuth password rotation - Button in Settings → Active Sessions section Other: - Dashboard recent notes limit increased from 8 to 16 - Workspace chat abort replaces Send button while streaming Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-03-07 11:34:06 -05:00