test(acl): give search/inject fixtures real owner ids; fail soft on name lookup

Run 2892: 3 pre-existing tests broke, 392 passed. Same shape as the last breakage — a DB-touching call landed in a path unit tests exercise, and their fixtures had auto-MagicMock user_id attributes that compare as "someone else's", sending the code off to look up a username. Fixed the fixtures rather than the assertion: _fake_note in the search tests and _note in the plugin-context tests now take a real user_id defaulting to the caller those tests bind. That makes "is this shared?" meaningful in both files instead of accidental, which is what the new provenance behaviour actually needs from them. Separately, and not as cover for the above: owner_names_for now fails soft. A lookup error yields no names and callers render "another user". The part that matters — that the record is NOT the caller's — comes from comparing owner ids, not from this query, so losing an attribution is cosmetic where failing the whole search would not be. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RLwAaV4DQEmVyn496HnEvt
2026-07-25 23:10:12 -04:00
parent ef1dbdfc86
commit e9cd3435ad
3 changed files with 31 additions and 10 deletions
@@ -10,9 +10,13 @@ def _rule(rid, title, topic_id):
    return r


-def _note(nid, title):
+def _note(nid, title, user_id=1):
    n = MagicMock()
    n.id, n.title = nid, title
+    # Real int, defaulting to the caller used in these tests: the injected menu
+    # compares it to decide whether the line needs a "shared by …" attribution,
+    # and an auto-MagicMock would read as another user's note.
+    n.user_id = user_id
    return n