refactor(tests): one definition each for the copied fixtures and fakes (#2825, milestone 296 area 1)

The shape ledger showed the same test scaffolding defined over and over:
_bind_user x12 (byte-identical), _dispose_engine x10 in three wordings,
_no_supersession x3, _make_mock_session x7 in three subsets, a get-or-create
User helper x2 (+3 inlined), and fifteen hand-rolled MagicMock note factories
each re-explaining the same "an auto-MagicMock attribute is truthy" hazard
(note 2109).

Now: conftest.py carries _bind_user / _dispose_engine / _no_supersession as
opt-in fixtures (pytestmark = usefixtures(...) per module, so unit tests pay
nothing), and tests/helpers.py carries make_mock_session(), ensure_user() and
fake_note(**attrs) — the hazard documented once, real values on every
attribute the product reads. Call sites were rewritten by AST so titles with
dashes and commas survived; the three SimpleNamespace _note stand-ins that
only feed a single function stay local.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

tests/test_integration_forge_keyring.py

@@ -13,12 +13,10 @@ from unittest.mock import patch
 
 import pytest
 import pytest_asyncio
-from sqlalchemy import select
 
 from scribe.config import Config
-from scribe.models import async_session, engine
+from scribe.models import async_session
 from scribe.models.project import Project
-from scribe.models.user import User
 from scribe.services.forge import get_forges
 from scribe.services.forge_connections import (
     create_connection,
@@ -27,39 +25,21 @@ from scribe.services.forge_connections import (
     set_project_pin,
     update_connection,
 )
+from tests.helpers import ensure_user
 
-pytestmark = pytest.mark.integration
+pytestmark = [pytest.mark.integration, pytest.mark.usefixtures("_dispose_engine")]
 
 GITEA = "https://git.example.com"
 GITHUB = "https://github.com"
 
 
-@pytest_asyncio.fixture(autouse=True)
-async def _dispose_engine():
-    # Per-loop pool: dispose after each test (see test_integration_db_maintenance).
-    yield
-    await engine.dispose()
-
-
-async def _user(session, username: str, role: str = "user") -> User:
-    existing = (
-        await session.execute(select(User).where(User.username == username))
-    ).scalar_one_or_none()
-    if existing is not None:
-        return existing
-    user = User(username=username, role=role)
-    session.add(user)
-    await session.flush()
-    return user
-
-
 @pytest_asyncio.fixture
 async def seeded():
     """An owner with a project, plus an unrelated user and an admin."""
     async with async_session() as s:
-        owner = await _user(s, "keyring_owner")
-        other = await _user(s, "keyring_other")
-        admin = await _user(s, "keyring_admin", role="admin")
+        owner = await ensure_user(s, "keyring_owner")
+        other = await ensure_user(s, "keyring_other")
+        admin = await ensure_user(s, "keyring_admin", role="admin")
         project = Project(user_id=owner.id, title="Keyring project")
         s.add(project)
         await s.flush()