refactor: rename package fabledassistant -> scribe (code-only)
CI & Build / Python lint (push) Successful in 3s
CI & Build / TypeScript typecheck (push) Successful in 35s
CI & Build / Python tests (push) Successful in 54s
CI & Build / Build & push image (push) Successful in 1m14s

Renames src/fabledassistant -> src/scribe and all imports, plus the
default DB name and DB user/password (fabled -> scribe) in config +
compose. 952 refs / 154 files. Reverses the old 'internal name stays
fabledassistant' convention.

Code-only: live databases are still physically named 'fabledassistant'.
Deployed environments must set POSTGRES_DB / POSTGRES_USER (or rename the
DB) since the defaults now resolve to 'scribe'. Repo (FabledScribe), git
host (fabledsword), MCP (fabled-git) and the image name (fabledscribe)
are intentionally unchanged.

ruff check src/ clean locally; CI (typecheck + pytest) is the gate.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-06-03 15:48:35 -04:00
parent 1d4c206563
commit b255a0f90e
167 changed files with 1183 additions and 2368 deletions
+45 -45
View File
@@ -3,7 +3,7 @@ from unittest.mock import AsyncMock, MagicMock, patch
import pytest
from fabledassistant.mcp._context import _user_id_ctx
from scribe.mcp._context import _user_id_ctx
@pytest.fixture(autouse=True)
@@ -43,10 +43,10 @@ def _fake_rule(id=100, title="r", statement="s"):
async def test_list_rulebooks_wraps_in_dict():
rows = [_fake_rulebook(id=1), _fake_rulebook(id=2)]
with patch(
"fabledassistant.mcp.tools.rulebooks.rulebooks_svc.list_rulebooks",
"scribe.mcp.tools.rulebooks.rulebooks_svc.list_rulebooks",
AsyncMock(return_value=rows),
):
from fabledassistant.mcp.tools.rulebooks import list_rulebooks
from scribe.mcp.tools.rulebooks import list_rulebooks
out = await list_rulebooks()
assert len(out["rulebooks"]) == 2
@@ -56,13 +56,13 @@ async def test_get_rulebook_includes_topics():
rb = _fake_rulebook(id=1)
topics = [_fake_topic(id=10), _fake_topic(id=11)]
with patch(
"fabledassistant.mcp.tools.rulebooks.rulebooks_svc.get_rulebook",
"scribe.mcp.tools.rulebooks.rulebooks_svc.get_rulebook",
AsyncMock(return_value=rb),
), patch(
"fabledassistant.mcp.tools.rulebooks.rulebooks_svc.list_topics",
"scribe.mcp.tools.rulebooks.rulebooks_svc.list_topics",
AsyncMock(return_value=topics),
):
from fabledassistant.mcp.tools.rulebooks import get_rulebook
from scribe.mcp.tools.rulebooks import get_rulebook
out = await get_rulebook(rulebook_id=1)
assert out["id"] == 1
assert len(out["topics"]) == 2
@@ -71,10 +71,10 @@ async def test_get_rulebook_includes_topics():
@pytest.mark.asyncio
async def test_get_rulebook_raises_when_not_found():
with patch(
"fabledassistant.mcp.tools.rulebooks.rulebooks_svc.get_rulebook",
"scribe.mcp.tools.rulebooks.rulebooks_svc.get_rulebook",
AsyncMock(return_value=None),
):
from fabledassistant.mcp.tools.rulebooks import get_rulebook
from scribe.mcp.tools.rulebooks import get_rulebook
with pytest.raises(ValueError, match="rulebook 999 not found"):
await get_rulebook(rulebook_id=999)
@@ -83,8 +83,8 @@ async def test_get_rulebook_raises_when_not_found():
async def test_create_rule_passes_required_fields():
rule = _fake_rule()
mock = AsyncMock(return_value=rule)
with patch("fabledassistant.mcp.tools.rulebooks.rulebooks_svc.create_rule", mock):
from fabledassistant.mcp.tools.rulebooks import create_rule
with patch("scribe.mcp.tools.rulebooks.rulebooks_svc.create_rule", mock):
from scribe.mcp.tools.rulebooks import create_rule
await create_rule(
topic_id=10, title="dev is home", statement="Work directly on dev",
)
@@ -98,8 +98,8 @@ async def test_create_rule_passes_required_fields():
async def test_update_rule_only_sends_non_default_fields():
rule = _fake_rule()
mock = AsyncMock(return_value=rule)
with patch("fabledassistant.mcp.tools.rulebooks.rulebooks_svc.update_rule", mock):
from fabledassistant.mcp.tools.rulebooks import update_rule
with patch("scribe.mcp.tools.rulebooks.rulebooks_svc.update_rule", mock):
from scribe.mcp.tools.rulebooks import update_rule
await update_rule(rule_id=1, statement="new statement")
args, kwargs = mock.call_args
assert args == (1, 7)
@@ -111,13 +111,13 @@ async def test_delete_rule_without_confirmed_returns_warning():
"""delete_rule with confirmed=False returns a preview, not an action."""
rule = _fake_rule()
with patch(
"fabledassistant.mcp.tools.rulebooks.rulebooks_svc.get_rule",
"scribe.mcp.tools.rulebooks.rulebooks_svc.get_rule",
AsyncMock(return_value=rule),
), patch(
"fabledassistant.mcp.tools.rulebooks.rulebooks_svc.delete_rule",
"scribe.mcp.tools.rulebooks.rulebooks_svc.delete_rule",
AsyncMock(),
) as mock_delete:
from fabledassistant.mcp.tools.rulebooks import delete_rule
from scribe.mcp.tools.rulebooks import delete_rule
out = await delete_rule(rule_id=1, confirmed=False)
assert out.get("confirmed_required") is True
assert "confirmed=True" in out.get("warning", "")
@@ -129,13 +129,13 @@ async def test_delete_rule_with_confirmed_soft_deletes():
rule = _fake_rule()
mock_delete = AsyncMock(return_value="batch-1")
with patch(
"fabledassistant.mcp.tools.rulebooks.rulebooks_svc.get_rule",
"scribe.mcp.tools.rulebooks.rulebooks_svc.get_rule",
AsyncMock(return_value=rule),
), patch(
"fabledassistant.mcp.tools.rulebooks.trash_svc.delete",
"scribe.mcp.tools.rulebooks.trash_svc.delete",
mock_delete,
):
from fabledassistant.mcp.tools.rulebooks import delete_rule
from scribe.mcp.tools.rulebooks import delete_rule
out = await delete_rule(rule_id=1, confirmed=True)
assert out["deleted"] == 1
assert out["deleted_batch_id"] == "batch-1"
@@ -146,9 +146,9 @@ async def test_delete_rule_with_confirmed_soft_deletes():
async def test_subscribe_project_to_rulebook_calls_service():
mock = AsyncMock()
with patch(
"fabledassistant.mcp.tools.rulebooks.rulebooks_svc.subscribe_project", mock,
"scribe.mcp.tools.rulebooks.rulebooks_svc.subscribe_project", mock,
):
from fabledassistant.mcp.tools.rulebooks import subscribe_project_to_rulebook
from scribe.mcp.tools.rulebooks import subscribe_project_to_rulebook
out = await subscribe_project_to_rulebook(project_id=3, rulebook_id=1)
assert out["subscribed"] is True
assert mock.called
@@ -158,9 +158,9 @@ async def test_subscribe_project_to_rulebook_calls_service():
async def test_unsubscribe_project_from_rulebook_calls_service():
mock = AsyncMock()
with patch(
"fabledassistant.mcp.tools.rulebooks.rulebooks_svc.unsubscribe_project", mock,
"scribe.mcp.tools.rulebooks.rulebooks_svc.unsubscribe_project", mock,
):
from fabledassistant.mcp.tools.rulebooks import unsubscribe_project_from_rulebook
from scribe.mcp.tools.rulebooks import unsubscribe_project_from_rulebook
out = await unsubscribe_project_from_rulebook(project_id=3, rulebook_id=1)
assert out["subscribed"] is False
assert mock.called
@@ -168,7 +168,7 @@ async def test_unsubscribe_project_from_rulebook_calls_service():
def test_register_attaches_all_sixteen_tools():
"""register(mcp) should call mcp.tool(name=...) for all 16 tools."""
from fabledassistant.mcp.tools.rulebooks import register
from scribe.mcp.tools.rulebooks import register
registered: list[str] = []
class FakeMCP:
@@ -195,10 +195,10 @@ def test_register_attaches_all_sixteen_tools():
@pytest.mark.asyncio
async def test_list_always_on_rules_returns_empty_when_no_always_on_rulebooks():
with patch(
"fabledassistant.mcp.tools.rulebooks.rulebooks_svc.list_always_on_rules",
"scribe.mcp.tools.rulebooks.rulebooks_svc.list_always_on_rules",
AsyncMock(return_value=[]),
):
from fabledassistant.mcp.tools.rulebooks import list_always_on_rules
from scribe.mcp.tools.rulebooks import list_always_on_rules
out = await list_always_on_rules()
assert out == {"rules": [], "total": 0}
@@ -207,10 +207,10 @@ async def test_list_always_on_rules_returns_empty_when_no_always_on_rulebooks():
async def test_list_always_on_rules_projects_each_rule():
rules = [_fake_rule(id=100), _fake_rule(id=101)]
with patch(
"fabledassistant.mcp.tools.rulebooks.rulebooks_svc.list_always_on_rules",
"scribe.mcp.tools.rulebooks.rulebooks_svc.list_always_on_rules",
AsyncMock(return_value=rules),
):
from fabledassistant.mcp.tools.rulebooks import list_always_on_rules
from scribe.mcp.tools.rulebooks import list_always_on_rules
out = await list_always_on_rules()
assert out["total"] == 2
assert {r["id"] for r in out["rules"]} == {100, 101}
@@ -221,8 +221,8 @@ async def test_list_always_on_rules_projects_each_rule():
async def test_update_rulebook_forwards_always_on_when_set():
rb = _fake_rulebook(id=1, title="t")
mock = AsyncMock(return_value=rb)
with patch("fabledassistant.mcp.tools.rulebooks.rulebooks_svc.update_rulebook", mock):
from fabledassistant.mcp.tools.rulebooks import update_rulebook
with patch("scribe.mcp.tools.rulebooks.rulebooks_svc.update_rulebook", mock):
from scribe.mcp.tools.rulebooks import update_rulebook
await update_rulebook(rulebook_id=1, always_on=True)
kwargs = mock.call_args.kwargs
assert kwargs.get("always_on") is True
@@ -234,8 +234,8 @@ async def test_update_rulebook_forwards_always_on_when_set():
async def test_update_rulebook_omits_always_on_when_none():
rb = _fake_rulebook(id=1, title="t")
mock = AsyncMock(return_value=rb)
with patch("fabledassistant.mcp.tools.rulebooks.rulebooks_svc.update_rulebook", mock):
from fabledassistant.mcp.tools.rulebooks import update_rulebook
with patch("scribe.mcp.tools.rulebooks.rulebooks_svc.update_rulebook", mock):
from scribe.mcp.tools.rulebooks import update_rulebook
await update_rulebook(rulebook_id=1, title="new title")
kwargs = mock.call_args.kwargs
assert "always_on" not in kwargs
@@ -246,8 +246,8 @@ async def test_update_rulebook_omits_always_on_when_none():
async def test_create_project_rule_passes_required_fields():
rule = _fake_rule()
mock = AsyncMock(return_value=rule)
with patch("fabledassistant.mcp.tools.rulebooks.rulebooks_svc.create_project_rule", mock):
from fabledassistant.mcp.tools.rulebooks import create_project_rule
with patch("scribe.mcp.tools.rulebooks.rulebooks_svc.create_project_rule", mock):
from scribe.mcp.tools.rulebooks import create_project_rule
await create_project_rule(
project_id=42,
statement="Always run migrations through alembic, not raw SQL.",
@@ -264,8 +264,8 @@ async def test_create_project_rule_passes_required_fields():
async def test_create_project_rule_derives_title_from_statement():
rule = _fake_rule()
mock = AsyncMock(return_value=rule)
with patch("fabledassistant.mcp.tools.rulebooks.rulebooks_svc.create_project_rule", mock):
from fabledassistant.mcp.tools.rulebooks import create_project_rule
with patch("scribe.mcp.tools.rulebooks.rulebooks_svc.create_project_rule", mock):
from scribe.mcp.tools.rulebooks import create_project_rule
await create_project_rule(
project_id=42,
statement="Avoid auto-generated docstrings. Reviewers find them noise.",
@@ -279,8 +279,8 @@ async def test_create_project_rule_derives_title_from_statement():
async def test_create_project_rule_uses_explicit_title_when_given():
rule = _fake_rule()
mock = AsyncMock(return_value=rule)
with patch("fabledassistant.mcp.tools.rulebooks.rulebooks_svc.create_project_rule", mock):
from fabledassistant.mcp.tools.rulebooks import create_project_rule
with patch("scribe.mcp.tools.rulebooks.rulebooks_svc.create_project_rule", mock):
from scribe.mcp.tools.rulebooks import create_project_rule
await create_project_rule(
project_id=42,
statement="anything",
@@ -293,8 +293,8 @@ async def test_create_project_rule_uses_explicit_title_when_given():
@pytest.mark.asyncio
async def test_suppress_rule_for_project_passes_through():
mock = AsyncMock(return_value=None)
with patch("fabledassistant.mcp.tools.rulebooks.rulebooks_svc.suppress_rule_for_project", mock):
from fabledassistant.mcp.tools.rulebooks import suppress_rule_for_project
with patch("scribe.mcp.tools.rulebooks.rulebooks_svc.suppress_rule_for_project", mock):
from scribe.mcp.tools.rulebooks import suppress_rule_for_project
out = await suppress_rule_for_project(project_id=3, rule_id=17)
kwargs = mock.call_args.kwargs
assert kwargs == {"project_id": 3, "rule_id": 17, "user_id": 7}
@@ -304,8 +304,8 @@ async def test_suppress_rule_for_project_passes_through():
@pytest.mark.asyncio
async def test_unsuppress_rule_for_project_passes_through():
mock = AsyncMock(return_value=None)
with patch("fabledassistant.mcp.tools.rulebooks.rulebooks_svc.unsuppress_rule_for_project", mock):
from fabledassistant.mcp.tools.rulebooks import unsuppress_rule_for_project
with patch("scribe.mcp.tools.rulebooks.rulebooks_svc.unsuppress_rule_for_project", mock):
from scribe.mcp.tools.rulebooks import unsuppress_rule_for_project
out = await unsuppress_rule_for_project(project_id=3, rule_id=17)
kwargs = mock.call_args.kwargs
assert kwargs == {"project_id": 3, "rule_id": 17, "user_id": 7}
@@ -315,8 +315,8 @@ async def test_unsuppress_rule_for_project_passes_through():
@pytest.mark.asyncio
async def test_suppress_topic_for_project_passes_through():
mock = AsyncMock(return_value=None)
with patch("fabledassistant.mcp.tools.rulebooks.rulebooks_svc.suppress_topic_for_project", mock):
from fabledassistant.mcp.tools.rulebooks import suppress_topic_for_project
with patch("scribe.mcp.tools.rulebooks.rulebooks_svc.suppress_topic_for_project", mock):
from scribe.mcp.tools.rulebooks import suppress_topic_for_project
out = await suppress_topic_for_project(project_id=3, topic_id=22)
kwargs = mock.call_args.kwargs
assert kwargs == {"project_id": 3, "topic_id": 22, "user_id": 7}
@@ -326,8 +326,8 @@ async def test_suppress_topic_for_project_passes_through():
@pytest.mark.asyncio
async def test_unsuppress_topic_for_project_passes_through():
mock = AsyncMock(return_value=None)
with patch("fabledassistant.mcp.tools.rulebooks.rulebooks_svc.unsuppress_topic_for_project", mock):
from fabledassistant.mcp.tools.rulebooks import unsuppress_topic_for_project
with patch("scribe.mcp.tools.rulebooks.rulebooks_svc.unsuppress_topic_for_project", mock):
from scribe.mcp.tools.rulebooks import unsuppress_topic_for_project
out = await unsuppress_topic_for_project(project_id=3, topic_id=22)
kwargs = mock.call_args.kwargs
assert kwargs == {"project_id": 3, "topic_id": 22, "user_id": 7}