feat(inject): label the record kind on each auto-inject menu line

Every injected hit rendered identically, so a recorded snippet was
indistinguishable from a stray dev-log in the one place prior art most
needs to stand out. Each line now carries its kind — [snippet],
[process], [task], [issue], [note] — and the header says "records"
rather than "notes", which it can no longer claim.

Task-ness wins over note_type in the marker: "there's an open issue
about this" is the more useful thing to know at a glance.

Still title-first: the marker is metadata already on the ORM object,
so no extra query and no bodies (#2084).

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RLwAaV4DQEmVyn496HnEvt

tests/test_retrieval_scopes.py

@@ -17,15 +17,19 @@ from unittest.mock import AsyncMock, MagicMock, patch
 import pytest
 
 
-def _note(id=1, user_id=7, title="A note"):
+def _note(id=1, user_id=7, title="A note", note_type="note",
+          is_task=False, task_kind="work"):
     n = MagicMock()
     n.id = id
     n.user_id = user_id
     n.title = title
     n.body = "body"
     n.tags = []
-    n.is_task = False
-    n.note_type = "note"
+    # Real values, not auto-attributes: the menu reads these to label each line,
+    # and a MagicMock is truthy — every record would render as a task (note 2109).
+    n.is_task = is_task
+    n.task_kind = task_kind
+    n.note_type = note_type
     return n
 
 
@@ -146,3 +150,39 @@ async def test_injected_menu_attributes_another_users_note():
     assert "suggestion" in theirs_line
     # The operator's own note stays unadorned — absence of a marker is the signal.
     assert "shared by" not in mine_line
+
+
+@pytest.mark.asyncio
+async def test_injected_menu_labels_the_record_kind():
+    """Every injected line renders the same shape, so without a kind marker a
+    recorded snippet is indistinguishable from a stray dev-log — exactly where
+    prior art most needs to stand out."""
+    from scribe.services import plugin_context
+
+    hits = [
+        (0.92, _note(1, title="debounce — rate-limit a callback", note_type="snippet")),
+        (0.91, _note(2, title="Release checklist", note_type="process")),
+        (0.90, _note(3, title="Auth token expiry", is_task=True, task_kind="issue")),
+        (0.89, _note(4, title="Ship the drafter", is_task=True)),
+        (0.88, _note(5, title="Why we dropped CalDAV")),
+    ]
+    with patch.object(plugin_context, "semantic_search_notes",
+                      AsyncMock(return_value=hits)), \
+         patch.object(plugin_context, "get_autoinject_config",
+                      AsyncMock(return_value={"enabled": True, "threshold": 0.5,
+                                              "top_k": 5})), \
+         patch.object(plugin_context, "record_retrieval", MagicMock()):
+        out = await plugin_context.build_autoinject_hint(7, "anything")
+
+    lines = out["context"].splitlines()
+    by_id = {n: next(ln for ln in lines if f"#{n} " in ln) for n in (1, 2, 3, 4, 5)}
+    assert "[snippet]" in by_id[1]
+    assert "[process]" in by_id[2]
+    # Task-ness wins over note_type, and an issue says so rather than "task".
+    assert "[issue]" in by_id[3]
+    assert "[task]" in by_id[4]
+    assert "[note]" in by_id[5]
+    # Still title-first: the marker is metadata, not an excuse to carry bodies.
+    assert "body" not in out["context"]
+    # The header can't claim they're all notes when the markers say otherwise.
+    assert "Scribe records" in lines[0]

tests/test_services_plugin_context.py

@@ -10,13 +10,15 @@ def _rule(rid, title, topic_id):
     return r
 
 
-def _note(nid, title, user_id=1):
+def _note(nid, title, user_id=1, note_type="note", is_task=False, task_kind="work"):
     n = MagicMock()
     n.id, n.title = nid, title
-    # Real int, defaulting to the caller used in these tests: the injected menu
-    # compares it to decide whether the line needs a "shared by …" attribution,
-    # and an auto-MagicMock would read as another user's note.
+    # Real values, defaulting to the caller used in these tests: the injected menu
+    # compares user_id to decide whether the line needs a "shared by …"
+    # attribution, and reads is_task/task_kind/note_type for the kind marker. An
+    # auto-MagicMock is truthy, so every line would read as another user's task.
     n.user_id = user_id
+    n.note_type, n.is_task, n.task_kind = note_type, is_task, task_kind
     return n
 
 
@@ -79,7 +81,7 @@ async def test_build_autoinject_hint_titles_only_with_margin_gate():
                                              exclude_ids=[99])
     # Margin gate kept the top two, dropped the straggler.
     assert out["note_ids"] == [11, 22]
-    assert '#11 "Pool sizing decision" (0.80)' in out["context"]
+    assert '#11 [note] "Pool sizing decision" (0.80)' in out["context"]
     assert "#33" not in out["context"]
     # Title-first: no body text, ever.
     assert "get_note(id)" in out["context"]