feat(moments): mounted rules arrive when their moment happens, through every door (milestone 458 step 4a, #4922)
CI & Build / Python lint (push) Successful in 2s
CI & Build / Plugin hooks (push) Successful in 13s
CI & Build / TypeScript typecheck (push) Successful in 54s
CI & Build / integration (push) Successful in 57s
CI & Build / Python tests (push) Failing after 1m19s
CI & Build / Build & push image (push) Skipped
CI & Build / Python lint (push) Successful in 2s
CI & Build / Plugin hooks (push) Successful in 13s
CI & Build / TypeScript typecheck (push) Successful in 54s
CI & Build / integration (push) Successful in 57s
CI & Build / Python tests (push) Failing after 1m19s
CI & Build / Build & push image (push) Skipped
A rule mounted on a moment now reaches the session when an act reaches
that moment, with no semantic match involved:
- run_moment_arm on the pipeline: a lookup, not a ranked search. Each
line names the moment and the act that reached it ("at work.deliver,
reached by `git push`"), so a misfire is visible where it lands and
can be unmapped in-session. A repeat is cited, not quoted; fresh
rules are recorded surfaced under source moment_rule with the moment
in detail. No retrieval_logs row, as for the other lookups, so no
latency is persisted for this arm.
- rule_scope: a rule's home clause, moved out of semantic_search_rules
so the moment lookup scopes by the same one.
- rulebooks.rules_on_moments / mounted_moments.
- The plugin door: a catch-all PreToolUse hook (scribe_moment.sh). It
keeps /moment-tools' answer on disk for five minutes, so a call to a
tool that cannot reach a mounted rule sends nothing, and an install
that has mounted nothing sends one request per window. It shares the
rules ledger with the other arms and fails open silently.
- The MCP door: Scribe's own tools named by the shipped mappings carry
moment_rules in their response, so a client without the plugin gets
them too. The hook skips those tools. A guard pins the attach on
every one.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -6,16 +6,20 @@ claim depends on:
|
||||
- only the owner can mount;
|
||||
- the rule's detail reads its mounts back;
|
||||
- a backup carries them, attached to the RESTORED rule's new id rather than
|
||||
the old number.
|
||||
the old number;
|
||||
- the delivery lookup (step 4) answers by home: a project's mounted rule
|
||||
reaches only work bound to that project, and nobody else's mount arrives.
|
||||
"""
|
||||
import pytest
|
||||
import pytest_asyncio
|
||||
from sqlalchemy import select
|
||||
|
||||
from scribe.models import async_session
|
||||
from scribe.models.project import Project
|
||||
from scribe.models.rulebook import Rule, Rulebook, RulebookTopic
|
||||
from scribe.models.user import User
|
||||
from scribe.services import backup
|
||||
from scribe.services import projects as projects_svc
|
||||
from scribe.services import rulebooks as rulebooks_svc
|
||||
from tests.helpers import ensure_user
|
||||
|
||||
@@ -155,3 +159,43 @@ async def test_a_backup_carries_the_mounts_to_the_restored_rule(world):
|
||||
assert (await rulebooks_svc.list_rule_moments([restored_rule.id]))[restored_rule.id] == [
|
||||
"work.finish", "reply.report",
|
||||
]
|
||||
|
||||
|
||||
async def _purge_projects(username: str) -> None:
|
||||
async with async_session() as s:
|
||||
for user in (await s.execute(
|
||||
select(User).where(User.username == username)
|
||||
)).scalars().all():
|
||||
for project in (await s.execute(
|
||||
select(Project).where(Project.user_id == user.id)
|
||||
)).scalars().all():
|
||||
await s.delete(project)
|
||||
await s.commit()
|
||||
|
||||
|
||||
async def test_the_delivery_lookup_answers_by_home(world):
|
||||
uid, sid, rule = world["uid"], world["sid"], world["rule"]
|
||||
await _purge_projects(OWNER_USERNAME)
|
||||
project = await projects_svc.create_project(uid, "Moment delivery fixture")
|
||||
local = await rulebooks_svc.create_project_rule(
|
||||
project.id, uid, "Ship notes with the release",
|
||||
"A release carries its notes.", when_to_apply="publishing a release",
|
||||
)
|
||||
await rulebooks_svc.set_rule_moments(rule.id, uid, ["work.finish", "reply.report"])
|
||||
await rulebooks_svc.set_rule_moments(local.id, uid, ["work.deliver"])
|
||||
|
||||
# Unbound: the global rule, under the FIRST of the given moments it is on.
|
||||
got = await rulebooks_svc.rules_on_moments(uid, ["reply.report", "work.finish"])
|
||||
assert [(r.id, m) for r, m in got] == [(rule.id, "reply.report")]
|
||||
assert await rulebooks_svc.rules_on_moments(uid, ["work.deliver"]) == []
|
||||
|
||||
# Bound to the project: its own rule arrives too.
|
||||
got = await rulebooks_svc.rules_on_moments(uid, ["work.deliver"], project.id)
|
||||
assert [(r.id, m) for r, m in got] == [(local.id, "work.deliver")]
|
||||
|
||||
# Somebody else's mount never arrives — not even naming their project.
|
||||
assert await rulebooks_svc.rules_on_moments(sid, ["work.finish", "work.deliver"], project.id) == []
|
||||
|
||||
# The plugin's "can anything arrive" answer spans every home.
|
||||
assert await rulebooks_svc.mounted_moments(uid) >= {"work.finish", "reply.report", "work.deliver"}
|
||||
assert not (await rulebooks_svc.mounted_moments(sid)) & {"work.finish", "work.deliver"}
|
||||
|
||||
Reference in New Issue
Block a user