feat(moments): mounted rules arrive when their moment happens, through every door (milestone 458 step 4a, #4922)
CI & Build / Python lint (push) Successful in 2s
CI & Build / Plugin hooks (push) Successful in 13s
CI & Build / TypeScript typecheck (push) Successful in 54s
CI & Build / integration (push) Successful in 57s
CI & Build / Python tests (push) Failing after 1m19s
CI & Build / Build & push image (push) Skipped
CI & Build / Python lint (push) Successful in 2s
CI & Build / Plugin hooks (push) Successful in 13s
CI & Build / TypeScript typecheck (push) Successful in 54s
CI & Build / integration (push) Successful in 57s
CI & Build / Python tests (push) Failing after 1m19s
CI & Build / Build & push image (push) Skipped
A rule mounted on a moment now reaches the session when an act reaches
that moment, with no semantic match involved:
- run_moment_arm on the pipeline: a lookup, not a ranked search. Each
line names the moment and the act that reached it ("at work.deliver,
reached by `git push`"), so a misfire is visible where it lands and
can be unmapped in-session. A repeat is cited, not quoted; fresh
rules are recorded surfaced under source moment_rule with the moment
in detail. No retrieval_logs row, as for the other lookups, so no
latency is persisted for this arm.
- rule_scope: a rule's home clause, moved out of semantic_search_rules
so the moment lookup scopes by the same one.
- rulebooks.rules_on_moments / mounted_moments.
- The plugin door: a catch-all PreToolUse hook (scribe_moment.sh). It
keeps /moment-tools' answer on disk for five minutes, so a call to a
tool that cannot reach a mounted rule sends nothing, and an install
that has mounted nothing sends one request per window. It shares the
rules ledger with the other arms and fails open silently.
- The MCP door: Scribe's own tools named by the shipped mappings carry
moment_rules in their response, so a client without the plugin gets
them too. The hook skips those tools. A guard pins the attach on
every one.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,55 @@
|
||||
"""Which rules a caller may be shown — a rule's HOME, stated once (milestone 414).
|
||||
|
||||
A rule lives in a rulebook topic — GLOBAL, it applies wherever its owner
|
||||
works — or on one project, where it applies to that project and nowhere else.
|
||||
Every read that hands rules to a session answers the same question about that
|
||||
home, so it is answered here and nowhere else:
|
||||
|
||||
- `project_id` unset: global rules only. A caller that does not say gets the
|
||||
safe failure, which is surfacing less rather than another project's rules.
|
||||
- `project_id=N`: global rules plus project N's own, and N's only when the
|
||||
caller can read that project (access.can_read_project, so a shared project's
|
||||
rules reach its collaborators too).
|
||||
- `everywhere=True`: every rule the caller owns, in any home — the explicit
|
||||
whole-rulebook question.
|
||||
|
||||
It was written inline in `semantic_search_rules` until the moment lookup
|
||||
(milestone 458) needed the same answer. Two copies of a scope clause is how
|
||||
one of them starts surfacing another project's rules, so it moved here first.
|
||||
"""
|
||||
from __future__ import annotations
|
||||
|
||||
from sqlalchemy import or_
|
||||
|
||||
from scribe.services.access import can_read_project
|
||||
|
||||
|
||||
async def rule_home(user_id: int, project_id: int | None = None, *, everywhere: bool = False):
|
||||
"""The WHERE clause for the rules this caller may be shown here.
|
||||
|
||||
Needs the statement joined through `joined_to_homes`, which outer-joins
|
||||
the three tables the clause reads. A rule is in a topic XOR on a project
|
||||
(migration 0059), so it matches exactly one arm of whichever clause
|
||||
applies.
|
||||
"""
|
||||
from scribe.models.project import Project
|
||||
from scribe.models.rulebook import Rule, Rulebook
|
||||
|
||||
global_rule = Rulebook.owner_user_id == user_id
|
||||
if everywhere:
|
||||
return or_(global_rule, Project.user_id == user_id)
|
||||
if project_id and await can_read_project(user_id, project_id):
|
||||
return or_(global_rule, Rule.project_id == project_id)
|
||||
return global_rule
|
||||
|
||||
|
||||
def joined_to_homes(stmt):
|
||||
"""Outer-join a statement over `Rule` to the tables `rule_home` reads."""
|
||||
from scribe.models.project import Project
|
||||
from scribe.models.rulebook import Rule, Rulebook, RulebookTopic
|
||||
|
||||
return (
|
||||
stmt.outerjoin(RulebookTopic, Rule.topic_id == RulebookTopic.id)
|
||||
.outerjoin(Rulebook, RulebookTopic.rulebook_id == Rulebook.id)
|
||||
.outerjoin(Project, Rule.project_id == Project.id)
|
||||
)
|
||||
Reference in New Issue
Block a user