refactor(tests): per-model fakes, FakeMCP and session mocks come from tests/helpers (#2825, milestone 296 area 1, batch 2)

Second pass over the tests/ ledger after bbee0d0. fake_record(**attrs) is the
one MagicMock-with-real-attributes builder (to_dict mirrors them; the
note-2109 hazard documented once); fake_note/fake_task/fake_snippet/
fake_project/fake_milestone/fake_system/fake_rulebook/fake_topic/fake_rule
carry each model's ordinary defaults on top of it, replacing 14 per-file
factories (two rulebook trios in tool-vs-service wordings, _fake_task, _fake_ms,
_fake_project, _plan_note, _fake_snippet, two _snippet adapters now one-liners
over fake_snippet). FakeMCP replaces the five closure-over-a-list registrar
fakes (+ _Recorder); loc() and design_token_stub() replace the paired _loc /
_token / _T stand-ins; every hand-built async_session mock (9 helper defs and
14 inline copies) now starts from make_mock_session(). Call sites rewritten by
AST with each file's former defaults made explicit, so behaviour is unchanged.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

tests/test_mcp_tool_rulebooks.py

@@ -1,41 +1,16 @@
 """Tests for MCP rulebook tools — patches the service layer."""
-from unittest.mock import AsyncMock, MagicMock, patch
+from unittest.mock import AsyncMock, patch
 
 import pytest
+from tests.helpers import FakeMCP, fake_rule, fake_rulebook, fake_topic
 
 
 pytestmark = pytest.mark.usefixtures("_bind_user")
 
 
-def _fake_rulebook(id=1, title="t"):
-    rb = MagicMock()
-    rb.id = id
-    rb.title = title
-    rb.to_dict.return_value = {"id": id, "title": title}
-    return rb
-
-
-def _fake_topic(id=10, title="git"):
-    t = MagicMock()
-    t.id = id
-    t.title = title
-    t.to_dict.return_value = {"id": id, "title": title}
-    return t
-
-
-def _fake_rule(id=100, title="r", statement="s"):
-    r = MagicMock()
-    r.id = id
-    r.title = title
-    r.topic_id = 10
-    r.statement = statement
-    r.to_dict.return_value = {"id": id, "title": title, "statement": statement}
-    return r
-
-
 @pytest.mark.asyncio
 async def test_list_rulebooks_wraps_in_dict():
-    rows = [_fake_rulebook(id=1), _fake_rulebook(id=2)]
+    rows = [fake_rulebook(id=1, title="t"), fake_rulebook(id=2, title="t")]
     with patch(
         "scribe.mcp.tools.rulebooks.rulebooks_svc.list_rulebooks",
         AsyncMock(return_value=rows),
@@ -47,8 +22,8 @@ async def test_list_rulebooks_wraps_in_dict():
 
 @pytest.mark.asyncio
 async def test_get_rulebook_includes_topics():
-    rb = _fake_rulebook(id=1)
-    topics = [_fake_topic(id=10), _fake_topic(id=11)]
+    rb = fake_rulebook(id=1, title="t")
+    topics = [fake_topic(id=10, title="git"), fake_topic(id=11, title="git")]
     with patch(
         "scribe.mcp.tools.rulebooks.rulebooks_svc.get_rulebook",
         AsyncMock(return_value=rb),
@@ -75,7 +50,7 @@ async def test_get_rulebook_raises_when_not_found():
 
 @pytest.mark.asyncio
 async def test_create_rule_passes_required_fields():
-    rule = _fake_rule()
+    rule = fake_rule(id=100, title="r", statement="s", topic_id=10)
     mock = AsyncMock(return_value=rule)
     with patch("scribe.mcp.tools.rulebooks.rulebooks_svc.create_rule", mock):
         from scribe.mcp.tools.rulebooks import create_rule
@@ -109,7 +84,7 @@ async def test_create_rule_force_bypasses_duplicate_gate():
     find_mock = AsyncMock()
     with patch("scribe.mcp.tools.rulebooks.dedup_svc.find_duplicate_rule", find_mock), \
          patch("scribe.mcp.tools.rulebooks.rulebooks_svc.create_rule",
-               AsyncMock(return_value=_fake_rule(id=5))):
+               AsyncMock(return_value=fake_rule(id=5, title="r", statement="s", topic_id=10))):
         from scribe.mcp.tools.rulebooks import create_rule
         out = await create_rule(topic_id=10, title="dev is home", statement="x", force=True)
     assert out["id"] == 5
@@ -118,7 +93,7 @@ async def test_create_rule_force_bypasses_duplicate_gate():
 
 @pytest.mark.asyncio
 async def test_update_rule_only_sends_non_default_fields():
-    rule = _fake_rule()
+    rule = fake_rule(id=100, title="r", statement="s", topic_id=10)
     mock = AsyncMock(return_value=rule)
     with patch("scribe.mcp.tools.rulebooks.rulebooks_svc.update_rule", mock):
         from scribe.mcp.tools.rulebooks import update_rule
@@ -131,7 +106,7 @@ async def test_update_rule_only_sends_non_default_fields():
 @pytest.mark.asyncio
 async def test_delete_rule_without_confirmed_returns_warning():
     """delete_rule with confirmed=False returns a preview, not an action."""
-    rule = _fake_rule()
+    rule = fake_rule(id=100, title="r", statement="s", topic_id=10)
     with patch(
         "scribe.mcp.tools.rulebooks.rulebooks_svc.get_rule",
         AsyncMock(return_value=rule),
@@ -148,7 +123,7 @@ async def test_delete_rule_without_confirmed_returns_warning():
 
 @pytest.mark.asyncio
 async def test_delete_rule_with_confirmed_soft_deletes():
-    rule = _fake_rule()
+    rule = fake_rule(id=100, title="r", statement="s", topic_id=10)
     mock_delete = AsyncMock(return_value="batch-1")
     with patch(
         "scribe.mcp.tools.rulebooks.rulebooks_svc.get_rule",
@@ -191,27 +166,20 @@ async def test_unsubscribe_project_from_rulebook_calls_service():
 def test_register_attaches_all_sixteen_tools():
     """register(mcp) should call mcp.tool(name=...) for all 16 tools."""
     from scribe.mcp.tools.rulebooks import register
-    registered: list[str] = []
+    mcp = FakeMCP()
 
-    class FakeMCP:
-        def tool(self, name=None):
-            def decorator(fn):
-                registered.append(name)
-                return fn
-            return decorator
-
-    register(FakeMCP())
-    assert len(registered) == 22
+    register(mcp)
+    assert len(mcp.names) == 22
     # spot-check a few names
-    assert "list_rulebooks" in registered
-    assert "create_rule" in registered
-    assert "subscribe_project_to_rulebook" in registered
-    assert "list_always_on_rules" in registered
-    assert "create_project_rule" in registered
-    assert "suppress_rule_for_project" in registered
-    assert "unsuppress_rule_for_project" in registered
-    assert "suppress_topic_for_project" in registered
-    assert "unsuppress_topic_for_project" in registered
+    assert "list_rulebooks" in mcp.names
+    assert "create_rule" in mcp.names
+    assert "subscribe_project_to_rulebook" in mcp.names
+    assert "list_always_on_rules" in mcp.names
+    assert "create_project_rule" in mcp.names
+    assert "suppress_rule_for_project" in mcp.names
+    assert "unsuppress_rule_for_project" in mcp.names
+    assert "suppress_topic_for_project" in mcp.names
+    assert "unsuppress_topic_for_project" in mcp.names
 
 
 @pytest.mark.asyncio
@@ -227,7 +195,7 @@ async def test_list_always_on_rules_returns_empty_when_no_always_on_rulebooks():
 
 @pytest.mark.asyncio
 async def test_list_always_on_rules_projects_each_rule():
-    rules = [_fake_rule(id=100), _fake_rule(id=101)]
+    rules = [fake_rule(id=100, title="r", statement="s", topic_id=10), fake_rule(id=101, title="r", statement="s", topic_id=10)]
     with patch(
         "scribe.mcp.tools.rulebooks.rulebooks_svc.list_always_on_rules",
         AsyncMock(return_value=rules),
@@ -241,7 +209,7 @@ async def test_list_always_on_rules_projects_each_rule():
 
 @pytest.mark.asyncio
 async def test_update_rulebook_forwards_always_on_when_set():
-    rb = _fake_rulebook(id=1, title="t")
+    rb = fake_rulebook(id=1, title="t")
     mock = AsyncMock(return_value=rb)
     with patch("scribe.mcp.tools.rulebooks.rulebooks_svc.update_rulebook", mock):
         from scribe.mcp.tools.rulebooks import update_rulebook
@@ -254,7 +222,7 @@ async def test_update_rulebook_forwards_always_on_when_set():
 
 @pytest.mark.asyncio
 async def test_update_rulebook_omits_always_on_when_none():
-    rb = _fake_rulebook(id=1, title="t")
+    rb = fake_rulebook(id=1, title="t")
     mock = AsyncMock(return_value=rb)
     with patch("scribe.mcp.tools.rulebooks.rulebooks_svc.update_rulebook", mock):
         from scribe.mcp.tools.rulebooks import update_rulebook
@@ -266,7 +234,7 @@ async def test_update_rulebook_omits_always_on_when_none():
 
 @pytest.mark.asyncio
 async def test_create_project_rule_passes_required_fields():
-    rule = _fake_rule()
+    rule = fake_rule(id=100, title="r", statement="s", topic_id=10)
     mock = AsyncMock(return_value=rule)
     with patch("scribe.mcp.tools.rulebooks.rulebooks_svc.create_project_rule", mock):
         from scribe.mcp.tools.rulebooks import create_project_rule
@@ -284,7 +252,7 @@ async def test_create_project_rule_passes_required_fields():
 
 @pytest.mark.asyncio
 async def test_create_project_rule_derives_title_from_statement():
-    rule = _fake_rule()
+    rule = fake_rule(id=100, title="r", statement="s", topic_id=10)
     mock = AsyncMock(return_value=rule)
     with patch("scribe.mcp.tools.rulebooks.rulebooks_svc.create_project_rule", mock):
         from scribe.mcp.tools.rulebooks import create_project_rule
@@ -299,7 +267,7 @@ async def test_create_project_rule_derives_title_from_statement():
 
 @pytest.mark.asyncio
 async def test_create_project_rule_uses_explicit_title_when_given():
-    rule = _fake_rule()
+    rule = fake_rule(id=100, title="r", statement="s", topic_id=10)
     mock = AsyncMock(return_value=rule)
     with patch("scribe.mcp.tools.rulebooks.rulebooks_svc.create_project_rule", mock):
         from scribe.mcp.tools.rulebooks import create_project_rule