bvandeusen/FabledScribe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 50 Wiki Activity

refactor(mcp): drop fable_ prefix from tool names; rebrand to Scribe

Browse Source 
MCP clients see tools namespaced by the server's local name already
(mcp__<server>__<tool>), so the fable_ prefix on every tool name was
redundant and ate tokens in the model's tool list.

Tools renamed (34 total):
  fable_search → search
  fable_list_notes / get_note / create_note / update_note / delete_note → list_notes / ...
  fable_list_tasks / get_task / create_task / update_task / add_task_log → list_tasks / ...
  fable_list_projects / get_project / create_project / update_project → list_projects / ...
  fable_list_milestones / create_milestone / update_milestone → list_milestones / ...
  fable_list_events / create_event / get_event / update_event / delete_event → list_events / ...
  fable_list_tags → list_tags
  fable_get_recent → get_recent
  fable_list_persons / create_person / update_person → list_persons / ...
  fable_list_places / create_place / update_place → list_places / ...
  fable_list_lists / create_list / update_list → list_lists / ...

Also rebranded in MCP scope:
  FastMCP("fable", ...) → FastMCP("scribe", ...)
  auth realm "fable-mcp" → "scribe-mcp"
  ASGI scope key fable_user_id → scribe_user_id
  ContextVar label fable_mcp_user_id → scribe_mcp_user_id
  Tool docstrings "in Fable" / "Fable task" → "in Scribe" / "Scribe task"
  Server _INSTRUCTIONS prose

Deliberately kept:
  - The internal Python package name `fabledassistant` (per project naming
    convention — internal stays).
  - "Fabled Scribe" as the official product/brand name (page footer,
    smtp_from_name default).
  - References to the legacy `fable-mcp/` standalone package in docstrings
    explaining what we ported from — accurate until that directory is
    deleted in Phase 10.

Client impact: existing MCP registrations need
  claude mcp remove <name> && claude mcp add ...
once with a freshly-copied snippet from Settings → MCP Access. Claude
Code then re-discovers tools on connect — old conversations that
referenced fable_* tool names will see "tool not found" on those calls
until updated.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Bryan Van Deusen
2026-05-27 11:48:55 -04:00
parent 97c22941a8
commit 6aa84002b3
19 changed files with 191 additions and 190 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_mcp_tool_events.py
+14 -14
View File
@@ -6,8 +6,8 @@ import pytest
from fabledassistant.mcp._context import _user_id_ctx
from fabledassistant.mcp.tools.events import (
fable_list_events, fable_create_event, fable_get_event,
fable_update_event, fable_delete_event,
list_events, create_event, get_event,
update_event, delete_event,
)
@@ -36,7 +36,7 @@ async def test_list_events_passes_datetime_range():
{"id": 1, "title": "morning standup"},
])
with patch("fabledassistant.mcp.tools.events.events_svc.list_events", mock):
out = await fable_list_events(date_from="2026-06-01", date_to="2026-06-08")
out = await list_events(date_from="2026-06-01", date_to="2026-06-08")
args, _ = mock.call_args
assert args[0] == 7 # user_id
assert args[1] == datetime(2026, 6, 1)
@@ -49,7 +49,7 @@ async def test_create_event_combines_date_and_time():
e = _fake_event()
mock = AsyncMock(return_value=e)
with patch("fabledassistant.mcp.tools.events.events_svc.create_event", mock):
await fable_create_event(
await create_event(
title="standup", start_date="2026-06-01", start_time="09:30",
duration_minutes=15,
)
@@ -64,7 +64,7 @@ async def test_create_event_zero_duration_means_point_event():
e = _fake_event()
mock = AsyncMock(return_value=e)
with patch("fabledassistant.mcp.tools.events.events_svc.create_event", mock):
await fable_create_event(title="x", start_date="2026-06-01")
await create_event(title="x", start_date="2026-06-01")
assert mock.call_args.kwargs["duration_minutes"] is None
@@ -75,7 +75,7 @@ async def test_get_event_raises_when_not_found():
AsyncMock(return_value=None),
):
with pytest.raises(ValueError, match="event 999 not found"):
await fable_get_event(event_id=999)
await get_event(event_id=999)
@pytest.mark.asyncio
@@ -83,7 +83,7 @@ async def test_update_event_only_sends_non_default_fields():
e = _fake_event()
mock = AsyncMock(return_value=e)
with patch("fabledassistant.mcp.tools.events.events_svc.update_event", mock):
await fable_update_event(event_id=1, title="new title")
await update_event(event_id=1, title="new title")
args, kwargs = mock.call_args
assert args == (7, 1)
assert kwargs == {"title": "new title"}
@@ -94,7 +94,7 @@ async def test_update_event_duration_minus_one_means_unchanged():
e = _fake_event()
mock = AsyncMock(return_value=e)
with patch("fabledassistant.mcp.tools.events.events_svc.update_event", mock):
await fable_update_event(event_id=1, duration_minutes=-1)
await update_event(event_id=1, duration_minutes=-1)
assert "duration_minutes" not in mock.call_args.kwargs
@@ -104,7 +104,7 @@ async def test_update_event_duration_zero_clears_to_point():
e = _fake_event()
mock = AsyncMock(return_value=e)
with patch("fabledassistant.mcp.tools.events.events_svc.update_event", mock):
await fable_update_event(event_id=1, duration_minutes=0)
await update_event(event_id=1, duration_minutes=0)
assert mock.call_args.kwargs["duration_minutes"] is None
@@ -113,12 +113,12 @@ async def test_update_event_requires_both_date_and_time_to_move():
e = _fake_event()
mock = AsyncMock(return_value=e)
with patch("fabledassistant.mcp.tools.events.events_svc.update_event", mock):
await fable_update_event(event_id=1, start_date="2026-06-02")
await update_event(event_id=1, start_date="2026-06-02")
# Only start_date, no start_time → start_dt NOT in fields
assert "start_dt" not in mock.call_args.kwargs
mock.reset_mock()
await fable_update_event(
await update_event(
event_id=1, start_date="2026-06-02", start_time="11:00",
)
assert mock.call_args.kwargs["start_dt"] == datetime(2026, 6, 2, 11)
@@ -131,7 +131,7 @@ async def test_update_event_raises_when_not_found():
AsyncMock(return_value=None),
):
with pytest.raises(ValueError, match="event 999 not found"):
await fable_update_event(event_id=999, title="x")
await update_event(event_id=999, title="x")
@pytest.mark.asyncio
@@ -144,7 +144,7 @@ async def test_delete_event_checks_existence_then_returns_confirmation():
"fabledassistant.mcp.tools.events.events_svc.delete_event",
AsyncMock(return_value=None),
):
result = await fable_delete_event(event_id=7)
result = await delete_event(event_id=7)
assert result == "Event 7 deleted."
@@ -155,4 +155,4 @@ async def test_delete_event_raises_when_not_found():
AsyncMock(return_value=None),
):
with pytest.raises(ValueError, match="event 999 not found"):
await fable_delete_event(event_id=999)
await delete_event(event_id=999)