feat(rules): always_on rulebook flag + Scribe-first prompt
Adds rulebooks.always_on (migration 0058) and a new list_always_on_rules MCP tool so a session-start eager pull can fetch standing rules without needing an active-project notion. Updates _INSTRUCTIONS so Claude calls the new tool at session start and codifies engineering rules in Scribe rather than CLAUDE.md / auto-memory. Seeds FabledSword family rulebook to always_on=true on migrate, matching its design role as the cross-project standards rulebook. Frontend: badge in RulebookListPane for always-on rulebooks; toggle in RulebookDetailPane header bound to a new toggleAlwaysOn store action. This is S1+S2 of the rules-consolidation plan (Scribe task #508). S3 (project-scoped rules) and S4 (enter_project handshake) follow. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,39 @@
|
|||||||
|
"""rulebook always_on flag
|
||||||
|
|
||||||
|
Revision ID: 0058
|
||||||
|
Revises: 0057
|
||||||
|
Create Date: 2026-06-01
|
||||||
|
|
||||||
|
Adds a boolean `always_on` to the `rulebooks` table. Rules from rulebooks
|
||||||
|
flagged always_on are loaded at session start by the new
|
||||||
|
`list_always_on_rules` MCP tool — they apply regardless of which project
|
||||||
|
(if any) is in scope. Seeds the FabledSword family rulebook to always_on
|
||||||
|
because that's the cross-project standards rulebook by design.
|
||||||
|
"""
|
||||||
|
from alembic import op
|
||||||
|
import sqlalchemy as sa
|
||||||
|
|
||||||
|
|
||||||
|
revision = "0058"
|
||||||
|
down_revision = "0057"
|
||||||
|
branch_labels = None
|
||||||
|
depends_on = None
|
||||||
|
|
||||||
|
|
||||||
|
def upgrade() -> None:
|
||||||
|
op.add_column(
|
||||||
|
"rulebooks",
|
||||||
|
sa.Column(
|
||||||
|
"always_on",
|
||||||
|
sa.Boolean(),
|
||||||
|
nullable=False,
|
||||||
|
server_default=sa.text("false"),
|
||||||
|
),
|
||||||
|
)
|
||||||
|
op.execute(
|
||||||
|
"UPDATE rulebooks SET always_on = TRUE WHERE title = 'FabledSword family'"
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
def downgrade() -> None:
|
||||||
|
op.drop_column("rulebooks", "always_on")
|
||||||
@@ -5,6 +5,7 @@ export interface Rulebook {
|
|||||||
owner_user_id: number;
|
owner_user_id: number;
|
||||||
title: string;
|
title: string;
|
||||||
description: string;
|
description: string;
|
||||||
|
always_on: boolean;
|
||||||
created_at: string | null;
|
created_at: string | null;
|
||||||
updated_at: string | null;
|
updated_at: string | null;
|
||||||
}
|
}
|
||||||
@@ -65,7 +66,7 @@ export async function createRulebook(data: { title: string; description?: string
|
|||||||
return apiPost("/api/rulebooks", data);
|
return apiPost("/api/rulebooks", data);
|
||||||
}
|
}
|
||||||
|
|
||||||
export async function updateRulebook(id: number, data: Partial<{ title: string; description: string }>): Promise<Rulebook> {
|
export async function updateRulebook(id: number, data: Partial<{ title: string; description: string; always_on: boolean }>): Promise<Rulebook> {
|
||||||
return apiPatch(`/api/rulebooks/${id}`, data);
|
return apiPatch(`/api/rulebooks/${id}`, data);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -1,5 +1,5 @@
|
|||||||
<script setup lang="ts">
|
<script setup lang="ts">
|
||||||
import { ref, onMounted, watch } from "vue";
|
import { ref, computed, onMounted, watch } from "vue";
|
||||||
import { useRulebooksStore } from "@/stores/rulebooks";
|
import { useRulebooksStore } from "@/stores/rulebooks";
|
||||||
import { apiGet } from "@/api/client";
|
import { apiGet } from "@/api/client";
|
||||||
import {
|
import {
|
||||||
@@ -18,6 +18,10 @@ const store = useRulebooksStore();
|
|||||||
const isCreating = ref(false);
|
const isCreating = ref(false);
|
||||||
const newTitle = ref("");
|
const newTitle = ref("");
|
||||||
|
|
||||||
|
const currentRulebook = computed(() =>
|
||||||
|
store.rulebooks.find((rb) => rb.id === props.rulebookId),
|
||||||
|
);
|
||||||
|
|
||||||
interface ProjectLite { id: number; title: string }
|
interface ProjectLite { id: number; title: string }
|
||||||
const projects = ref<ProjectLite[]>([]);
|
const projects = ref<ProjectLite[]>([]);
|
||||||
// Map<project_id, Set<rulebook_id>>
|
// Map<project_id, Set<rulebook_id>>
|
||||||
@@ -68,7 +72,17 @@ watch(() => props.rulebookId, () => {/* re-render of isSubscribed from existing
|
|||||||
|
|
||||||
<template>
|
<template>
|
||||||
<section class="pane">
|
<section class="pane">
|
||||||
<header><h2>Topics</h2></header>
|
<header>
|
||||||
|
<h2>Topics</h2>
|
||||||
|
<label v-if="currentRulebook" class="always-on-toggle" title="When on, rules from this rulebook load at session start regardless of project context">
|
||||||
|
<input
|
||||||
|
type="checkbox"
|
||||||
|
:checked="currentRulebook.always_on"
|
||||||
|
@change="store.toggleAlwaysOn(currentRulebook.id)"
|
||||||
|
/>
|
||||||
|
<span>Always on</span>
|
||||||
|
</label>
|
||||||
|
</header>
|
||||||
<ul>
|
<ul>
|
||||||
<li
|
<li
|
||||||
v-for="t in topics"
|
v-for="t in topics"
|
||||||
@@ -109,7 +123,14 @@ watch(() => props.rulebookId, () => {/* re-render of isSubscribed from existing
|
|||||||
|
|
||||||
<style scoped>
|
<style scoped>
|
||||||
.pane { background: var(--color-surface, #18181b); padding: 1rem; overflow-y: auto; }
|
.pane { background: var(--color-surface, #18181b); padding: 1rem; overflow-y: auto; }
|
||||||
|
header { display: flex; align-items: center; justify-content: space-between; gap: 1rem; }
|
||||||
header h2 { font-family: Fraunces, serif; font-style: italic; margin: 0 0 0.5rem 0; }
|
header h2 { font-family: Fraunces, serif; font-style: italic; margin: 0 0 0.5rem 0; }
|
||||||
|
.always-on-toggle {
|
||||||
|
display: flex; align-items: center; gap: 0.4rem;
|
||||||
|
font-size: 0.85rem; opacity: 0.85; cursor: pointer;
|
||||||
|
user-select: none;
|
||||||
|
}
|
||||||
|
.always-on-toggle input { cursor: pointer; }
|
||||||
ul { list-style: none; padding: 0; margin: 1rem 0; }
|
ul { list-style: none; padding: 0; margin: 1rem 0; }
|
||||||
li { padding: 0.5rem; cursor: pointer; border-radius: 6px; }
|
li { padding: 0.5rem; cursor: pointer; border-radius: 6px; }
|
||||||
li.active { background: var(--color-primary-bg, rgba(99,102,241,0.15)); }
|
li.active { background: var(--color-primary-bg, rgba(99,102,241,0.15)); }
|
||||||
|
|||||||
@@ -31,6 +31,7 @@ async function submitNew() {
|
|||||||
@click="emit('select', rb.id)"
|
@click="emit('select', rb.id)"
|
||||||
>
|
>
|
||||||
<span class="title">{{ rb.title }}</span>
|
<span class="title">{{ rb.title }}</span>
|
||||||
|
<span v-if="rb.always_on" class="always-on-badge" title="Loaded at session start">always on</span>
|
||||||
</li>
|
</li>
|
||||||
</ul>
|
</ul>
|
||||||
<div class="new-rulebook">
|
<div class="new-rulebook">
|
||||||
@@ -50,9 +51,19 @@ async function submitNew() {
|
|||||||
.pane { background: var(--color-surface, #18181b); padding: 1rem; overflow-y: auto; }
|
.pane { background: var(--color-surface, #18181b); padding: 1rem; overflow-y: auto; }
|
||||||
header h2 { font-family: Fraunces, serif; font-style: italic; margin: 0 0 0.5rem 0; }
|
header h2 { font-family: Fraunces, serif; font-style: italic; margin: 0 0 0.5rem 0; }
|
||||||
ul { list-style: none; padding: 0; margin: 1rem 0; }
|
ul { list-style: none; padding: 0; margin: 1rem 0; }
|
||||||
li { padding: 0.5rem; cursor: pointer; border-radius: 6px; }
|
li { padding: 0.5rem; cursor: pointer; border-radius: 6px; display: flex; align-items: center; gap: 0.5rem; }
|
||||||
li.active { background: var(--color-primary-bg, rgba(99,102,241,0.15)); }
|
li.active { background: var(--color-primary-bg, rgba(99,102,241,0.15)); }
|
||||||
li:hover { background: var(--color-hover, rgba(255,255,255,0.05)); }
|
li:hover { background: var(--color-hover, rgba(255,255,255,0.05)); }
|
||||||
|
.always-on-badge {
|
||||||
|
font-size: 0.7rem;
|
||||||
|
text-transform: uppercase;
|
||||||
|
letter-spacing: 0.05em;
|
||||||
|
padding: 0.1rem 0.4rem;
|
||||||
|
border-radius: 3px;
|
||||||
|
background: var(--color-accent, rgba(91,74,138,0.25));
|
||||||
|
color: var(--color-accent-fg, inherit);
|
||||||
|
margin-left: auto;
|
||||||
|
}
|
||||||
.new-rulebook { margin-top: 1rem; }
|
.new-rulebook { margin-top: 1rem; }
|
||||||
.new-rulebook input {
|
.new-rulebook input {
|
||||||
width: 100%; margin-bottom: 0.5rem;
|
width: 100%; margin-bottom: 0.5rem;
|
||||||
|
|||||||
@@ -54,13 +54,19 @@ export const useRulebooksStore = defineStore("rulebooks", () => {
|
|||||||
return rb;
|
return rb;
|
||||||
}
|
}
|
||||||
|
|
||||||
async function updateRulebook(id: number, data: Partial<Pick<Rulebook, "title" | "description">>) {
|
async function updateRulebook(id: number, data: Partial<Pick<Rulebook, "title" | "description" | "always_on">>) {
|
||||||
const rb = await api.updateRulebook(id, data);
|
const rb = await api.updateRulebook(id, data);
|
||||||
const idx = rulebooks.value.findIndex((r) => r.id === id);
|
const idx = rulebooks.value.findIndex((r) => r.id === id);
|
||||||
if (idx >= 0) rulebooks.value[idx] = rb;
|
if (idx >= 0) rulebooks.value[idx] = rb;
|
||||||
return rb;
|
return rb;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
async function toggleAlwaysOn(id: number) {
|
||||||
|
const current = rulebooks.value.find((r) => r.id === id);
|
||||||
|
if (!current) return;
|
||||||
|
return updateRulebook(id, { always_on: !current.always_on });
|
||||||
|
}
|
||||||
|
|
||||||
async function deleteRulebook(id: number) {
|
async function deleteRulebook(id: number) {
|
||||||
await api.deleteRulebook(id);
|
await api.deleteRulebook(id);
|
||||||
rulebooks.value = rulebooks.value.filter((r) => r.id !== id);
|
rulebooks.value = rulebooks.value.filter((r) => r.id !== id);
|
||||||
@@ -121,7 +127,7 @@ export const useRulebooksStore = defineStore("rulebooks", () => {
|
|||||||
return {
|
return {
|
||||||
rulebooks, topicsByRulebook, rulesByTopic, currentRule, loading,
|
rulebooks, topicsByRulebook, rulesByTopic, currentRule, loading,
|
||||||
fetchRulebooks, fetchTopics, fetchRules, fetchRule,
|
fetchRulebooks, fetchTopics, fetchRules, fetchRule,
|
||||||
createRulebook, updateRulebook, deleteRulebook,
|
createRulebook, updateRulebook, toggleAlwaysOn, deleteRulebook,
|
||||||
createTopic, updateTopic, deleteTopic,
|
createTopic, updateTopic, deleteTopic,
|
||||||
createRule, updateRule, deleteRule,
|
createRule, updateRule, deleteRule,
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -39,14 +39,21 @@ Mechanics:
|
|||||||
"not set".
|
"not set".
|
||||||
|
|
||||||
Scribe maintains a Rulebook system (Rulebook -> Topic -> Rule). Rules carry
|
Scribe maintains a Rulebook system (Rulebook -> Topic -> Rule). Rules carry
|
||||||
an actionable statement plus optional Why and How-to-apply context. When you
|
an actionable statement plus optional Why and How-to-apply context. At the
|
||||||
start work on a project, get_project(id) returns applicable_rules (the rules
|
start of any session that touches Scribe, call list_always_on_rules() to
|
||||||
from rulebooks the project subscribes to) and subscribed_rulebooks. Consult
|
load the standing rules — treat them as binding. When you also have a project
|
||||||
these before making decisions about workflow, conventions, or scope. Full
|
in scope, get_project(id) returns applicable_rules (rules from rulebooks the
|
||||||
text (Why / How-to-apply) is available via get_rule(id). You may create new
|
project subscribes to) and subscribed_rulebooks; consult those too. Full text
|
||||||
rules via create_rule when you notice a pattern worth codifying — coordinate
|
(Why / How-to-apply) is available via get_rule(id).
|
||||||
with the operator on whether it belongs in an existing rulebook+topic or a
|
|
||||||
new one.
|
Engineering and workflow rules live in Scribe. When you notice a pattern
|
||||||
|
worth codifying, call create_rule. Do NOT add new engineering rules to
|
||||||
|
CLAUDE.md or to ~/.claude/.../memory/feedback_*.md — those stores are
|
||||||
|
reserved for facts about the user (preferences, role, communication style)
|
||||||
|
and codebase onboarding pointers, respectively. Before creating a rule,
|
||||||
|
call list_always_on_rules and list_rules(project_id=...) to avoid duplicates.
|
||||||
|
Coordinate with the operator on whether a new rule belongs in an existing
|
||||||
|
rulebook+topic or a new one.
|
||||||
|
|
||||||
Plans are tasks with kind=plan, and Scribe is the canonical home for them.
|
Plans are tasks with kind=plan, and Scribe is the canonical home for them.
|
||||||
When you begin non-trivial work, call start_planning(project_id, title) FIRST —
|
When you begin non-trivial work, call start_planning(project_id, title) FIRST —
|
||||||
|
|||||||
@@ -54,14 +54,26 @@ async def create_rulebook(title: str, description: str = "") -> dict:
|
|||||||
|
|
||||||
async def update_rulebook(
|
async def update_rulebook(
|
||||||
rulebook_id: int, title: str = "", description: str = "",
|
rulebook_id: int, title: str = "", description: str = "",
|
||||||
|
always_on: bool | None = None,
|
||||||
) -> dict:
|
) -> dict:
|
||||||
"""Update an existing rulebook. Only non-empty fields are changed."""
|
"""Update an existing rulebook. Only non-empty fields are changed.
|
||||||
|
|
||||||
|
Args:
|
||||||
|
rulebook_id: Rulebook to update.
|
||||||
|
title: New title. Empty string leaves unchanged.
|
||||||
|
description: New description. Empty string leaves unchanged.
|
||||||
|
always_on: When True, rules in this rulebook are loaded at session
|
||||||
|
start by list_always_on_rules regardless of project context.
|
||||||
|
Pass None to leave unchanged.
|
||||||
|
"""
|
||||||
uid = current_user_id()
|
uid = current_user_id()
|
||||||
fields: dict = {}
|
fields: dict = {}
|
||||||
if title:
|
if title:
|
||||||
fields["title"] = title
|
fields["title"] = title
|
||||||
if description:
|
if description:
|
||||||
fields["description"] = description
|
fields["description"] = description
|
||||||
|
if always_on is not None:
|
||||||
|
fields["always_on"] = always_on
|
||||||
rb = await rulebooks_svc.update_rulebook(rulebook_id, uid, **fields)
|
rb = await rulebooks_svc.update_rulebook(rulebook_id, uid, **fields)
|
||||||
if rb is None:
|
if rb is None:
|
||||||
raise ValueError(f"rulebook {rulebook_id} not found")
|
raise ValueError(f"rulebook {rulebook_id} not found")
|
||||||
@@ -200,6 +212,28 @@ async def list_rules(
|
|||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
|
async def list_always_on_rules() -> dict:
|
||||||
|
"""Return all rules from rulebooks flagged always_on for the current user.
|
||||||
|
|
||||||
|
Call this at session start. Treat the returned rules as binding for the
|
||||||
|
session — they apply regardless of which project (if any) is in scope.
|
||||||
|
Pair with get_project(id).applicable_rules when working on a specific
|
||||||
|
project to also load that project's subscription-derived rules.
|
||||||
|
"""
|
||||||
|
uid = current_user_id()
|
||||||
|
rules = await rulebooks_svc.list_always_on_rules(uid)
|
||||||
|
return {
|
||||||
|
"rules": [
|
||||||
|
{
|
||||||
|
"id": r.id, "title": r.title, "statement": r.statement,
|
||||||
|
"topic_id": r.topic_id,
|
||||||
|
}
|
||||||
|
for r in rules
|
||||||
|
],
|
||||||
|
"total": len(rules),
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
async def get_rule(rule_id: int) -> dict:
|
async def get_rule(rule_id: int) -> dict:
|
||||||
"""Fetch a rule by id — full statement + why + how_to_apply."""
|
"""Fetch a rule by id — full statement + why + how_to_apply."""
|
||||||
uid = current_user_id()
|
uid = current_user_id()
|
||||||
@@ -302,7 +336,7 @@ def register(mcp) -> None:
|
|||||||
for fn in (
|
for fn in (
|
||||||
list_rulebooks, get_rulebook, create_rulebook, update_rulebook, delete_rulebook,
|
list_rulebooks, get_rulebook, create_rulebook, update_rulebook, delete_rulebook,
|
||||||
list_topics, create_topic, update_topic, delete_topic,
|
list_topics, create_topic, update_topic, delete_topic,
|
||||||
list_rules, get_rule, create_rule, update_rule, delete_rule,
|
list_rules, list_always_on_rules, get_rule, create_rule, update_rule, delete_rule,
|
||||||
subscribe_project_to_rulebook, unsubscribe_project_from_rulebook,
|
subscribe_project_to_rulebook, unsubscribe_project_from_rulebook,
|
||||||
):
|
):
|
||||||
mcp.tool(name=fn.__name__)(fn)
|
mcp.tool(name=fn.__name__)(fn)
|
||||||
|
|||||||
@@ -1,6 +1,6 @@
|
|||||||
from datetime import datetime, timezone
|
from datetime import datetime, timezone
|
||||||
|
|
||||||
from sqlalchemy import BigInteger, Column, DateTime, ForeignKey, Integer, Table, Text, UniqueConstraint
|
from sqlalchemy import BigInteger, Boolean, Column, DateTime, ForeignKey, Integer, Table, Text, UniqueConstraint
|
||||||
from sqlalchemy.orm import Mapped, mapped_column
|
from sqlalchemy.orm import Mapped, mapped_column
|
||||||
|
|
||||||
from fabledassistant.models import Base
|
from fabledassistant.models import Base
|
||||||
@@ -16,6 +16,9 @@ class Rulebook(Base, SoftDeleteMixin):
|
|||||||
)
|
)
|
||||||
title: Mapped[str] = mapped_column(Text)
|
title: Mapped[str] = mapped_column(Text)
|
||||||
description: Mapped[str | None] = mapped_column(Text, nullable=True)
|
description: Mapped[str | None] = mapped_column(Text, nullable=True)
|
||||||
|
always_on: Mapped[bool] = mapped_column(
|
||||||
|
Boolean, default=False, nullable=False, server_default="false"
|
||||||
|
)
|
||||||
created_at: Mapped[datetime] = mapped_column(
|
created_at: Mapped[datetime] = mapped_column(
|
||||||
DateTime(timezone=True), default=lambda: datetime.now(timezone.utc)
|
DateTime(timezone=True), default=lambda: datetime.now(timezone.utc)
|
||||||
)
|
)
|
||||||
@@ -31,6 +34,7 @@ class Rulebook(Base, SoftDeleteMixin):
|
|||||||
"owner_user_id": self.owner_user_id,
|
"owner_user_id": self.owner_user_id,
|
||||||
"title": self.title,
|
"title": self.title,
|
||||||
"description": self.description or "",
|
"description": self.description or "",
|
||||||
|
"always_on": self.always_on,
|
||||||
"created_at": self.created_at.isoformat() if self.created_at else None,
|
"created_at": self.created_at.isoformat() if self.created_at else None,
|
||||||
"updated_at": self.updated_at.isoformat() if self.updated_at else None,
|
"updated_at": self.updated_at.isoformat() if self.updated_at else None,
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -55,7 +55,7 @@ async def get_rulebook(rulebook_id: int):
|
|||||||
@login_required
|
@login_required
|
||||||
async def update_rulebook(rulebook_id: int):
|
async def update_rulebook(rulebook_id: int):
|
||||||
data = await request.get_json() or {}
|
data = await request.get_json() or {}
|
||||||
fields = {k: v for k, v in data.items() if k in ("title", "description")}
|
fields = {k: v for k, v in data.items() if k in ("title", "description", "always_on")}
|
||||||
rb = await rulebooks_svc.update_rulebook(rulebook_id, _uid(), **fields)
|
rb = await rulebooks_svc.update_rulebook(rulebook_id, _uid(), **fields)
|
||||||
if rb is None:
|
if rb is None:
|
||||||
return jsonify({"error": "rulebook not found"}), 404
|
return jsonify({"error": "rulebook not found"}), 404
|
||||||
|
|||||||
@@ -72,7 +72,7 @@ async def update_rulebook(
|
|||||||
rb = result.scalar_one_or_none()
|
rb = result.scalar_one_or_none()
|
||||||
if rb is None:
|
if rb is None:
|
||||||
return None
|
return None
|
||||||
allowed = {"title", "description"}
|
allowed = {"title", "description", "always_on"}
|
||||||
for key, value in fields.items():
|
for key, value in fields.items():
|
||||||
if key in allowed and value is not None:
|
if key in allowed and value is not None:
|
||||||
setattr(rb, key, value)
|
setattr(rb, key, value)
|
||||||
@@ -305,6 +305,33 @@ async def list_rules(
|
|||||||
return list(result.scalars().all())
|
return list(result.scalars().all())
|
||||||
|
|
||||||
|
|
||||||
|
async def list_always_on_rules(user_id: int, limit: int = 100) -> list[Rule]:
|
||||||
|
"""Return all rules from rulebooks flagged always_on for the user.
|
||||||
|
|
||||||
|
Called by the MCP tool of the same name at session start to load the
|
||||||
|
standing rules that apply regardless of which project (if any) is in
|
||||||
|
scope. Ordering matches list_rules so results are stable across calls.
|
||||||
|
"""
|
||||||
|
async with async_session() as session:
|
||||||
|
result = await session.execute(
|
||||||
|
select(Rule)
|
||||||
|
.join(RulebookTopic, Rule.topic_id == RulebookTopic.id)
|
||||||
|
.join(Rulebook, RulebookTopic.rulebook_id == Rulebook.id)
|
||||||
|
.where(
|
||||||
|
Rulebook.owner_user_id == user_id,
|
||||||
|
Rulebook.always_on.is_(True),
|
||||||
|
Rule.deleted_at.is_(None),
|
||||||
|
RulebookTopic.deleted_at.is_(None),
|
||||||
|
Rulebook.deleted_at.is_(None),
|
||||||
|
)
|
||||||
|
.order_by(
|
||||||
|
Rulebook.id, RulebookTopic.order_index, Rule.order_index, Rule.title,
|
||||||
|
)
|
||||||
|
.limit(limit)
|
||||||
|
)
|
||||||
|
return list(result.scalars().all())
|
||||||
|
|
||||||
|
|
||||||
async def get_rule(rule_id: int, user_id: int) -> Optional[Rule]:
|
async def get_rule(rule_id: int, user_id: int) -> Optional[Rule]:
|
||||||
async with async_session() as session:
|
async with async_session() as session:
|
||||||
result = await session.execute(
|
result = await session.execute(
|
||||||
|
|||||||
@@ -179,8 +179,59 @@ def test_register_attaches_all_sixteen_tools():
|
|||||||
return decorator
|
return decorator
|
||||||
|
|
||||||
register(FakeMCP())
|
register(FakeMCP())
|
||||||
assert len(registered) == 16
|
assert len(registered) == 17
|
||||||
# spot-check a few names
|
# spot-check a few names
|
||||||
assert "list_rulebooks" in registered
|
assert "list_rulebooks" in registered
|
||||||
assert "create_rule" in registered
|
assert "create_rule" in registered
|
||||||
assert "subscribe_project_to_rulebook" in registered
|
assert "subscribe_project_to_rulebook" in registered
|
||||||
|
assert "list_always_on_rules" in registered
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_list_always_on_rules_returns_empty_when_no_always_on_rulebooks():
|
||||||
|
with patch(
|
||||||
|
"fabledassistant.mcp.tools.rulebooks.rulebooks_svc.list_always_on_rules",
|
||||||
|
AsyncMock(return_value=[]),
|
||||||
|
):
|
||||||
|
from fabledassistant.mcp.tools.rulebooks import list_always_on_rules
|
||||||
|
out = await list_always_on_rules()
|
||||||
|
assert out == {"rules": [], "total": 0}
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_list_always_on_rules_projects_each_rule():
|
||||||
|
rules = [_fake_rule(id=100), _fake_rule(id=101)]
|
||||||
|
with patch(
|
||||||
|
"fabledassistant.mcp.tools.rulebooks.rulebooks_svc.list_always_on_rules",
|
||||||
|
AsyncMock(return_value=rules),
|
||||||
|
):
|
||||||
|
from fabledassistant.mcp.tools.rulebooks import list_always_on_rules
|
||||||
|
out = await list_always_on_rules()
|
||||||
|
assert out["total"] == 2
|
||||||
|
assert {r["id"] for r in out["rules"]} == {100, 101}
|
||||||
|
assert all("topic_id" in r for r in out["rules"])
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_update_rulebook_forwards_always_on_when_set():
|
||||||
|
rb = _fake_rulebook(id=1, title="t")
|
||||||
|
mock = AsyncMock(return_value=rb)
|
||||||
|
with patch("fabledassistant.mcp.tools.rulebooks.rulebooks_svc.update_rulebook", mock):
|
||||||
|
from fabledassistant.mcp.tools.rulebooks import update_rulebook
|
||||||
|
await update_rulebook(rulebook_id=1, always_on=True)
|
||||||
|
kwargs = mock.call_args.kwargs
|
||||||
|
assert kwargs.get("always_on") is True
|
||||||
|
assert "title" not in kwargs
|
||||||
|
assert "description" not in kwargs
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_update_rulebook_omits_always_on_when_none():
|
||||||
|
rb = _fake_rulebook(id=1, title="t")
|
||||||
|
mock = AsyncMock(return_value=rb)
|
||||||
|
with patch("fabledassistant.mcp.tools.rulebooks.rulebooks_svc.update_rulebook", mock):
|
||||||
|
from fabledassistant.mcp.tools.rulebooks import update_rulebook
|
||||||
|
await update_rulebook(rulebook_id=1, title="new title")
|
||||||
|
kwargs = mock.call_args.kwargs
|
||||||
|
assert "always_on" not in kwargs
|
||||||
|
assert kwargs["title"] == "new title"
|
||||||
|
|||||||
@@ -44,13 +44,34 @@ def test_service_signatures_require_user_id():
|
|||||||
"create_rulebook", "list_rulebooks", "get_rulebook",
|
"create_rulebook", "list_rulebooks", "get_rulebook",
|
||||||
"update_rulebook", "delete_rulebook", "find_rulebook_by_title",
|
"update_rulebook", "delete_rulebook", "find_rulebook_by_title",
|
||||||
"create_topic", "list_topics", "get_topic", "update_topic", "delete_topic",
|
"create_topic", "list_topics", "get_topic", "update_topic", "delete_topic",
|
||||||
"create_rule", "list_rules", "get_rule", "update_rule", "delete_rule",
|
"create_rule", "list_rules", "list_always_on_rules",
|
||||||
|
"get_rule", "update_rule", "delete_rule",
|
||||||
"subscribe_project", "unsubscribe_project", "get_applicable_rules",
|
"subscribe_project", "unsubscribe_project", "get_applicable_rules",
|
||||||
):
|
):
|
||||||
sig = inspect.signature(getattr(svc, fn_name))
|
sig = inspect.signature(getattr(svc, fn_name))
|
||||||
assert "user_id" in sig.parameters, f"{fn_name} missing user_id param"
|
assert "user_id" in sig.parameters, f"{fn_name} missing user_id param"
|
||||||
|
|
||||||
|
|
||||||
|
def test_rulebook_model_carries_always_on():
|
||||||
|
"""Migration 0058 added rulebooks.always_on — verify the model declares it."""
|
||||||
|
from fabledassistant.models.rulebook import Rulebook
|
||||||
|
assert "always_on" in Rulebook.__table__.columns
|
||||||
|
col = Rulebook.__table__.columns["always_on"]
|
||||||
|
assert col.nullable is False
|
||||||
|
|
||||||
|
|
||||||
|
def test_update_rulebook_route_accepts_always_on():
|
||||||
|
"""PATCH /api/rulebooks/<id> must pass always_on through to the service.
|
||||||
|
|
||||||
|
The handler filters body keys against a whitelist; that whitelist needs to
|
||||||
|
include always_on or toggling from the UI silently drops the field.
|
||||||
|
"""
|
||||||
|
import inspect as _inspect
|
||||||
|
from fabledassistant.routes import rulebooks as rb_routes
|
||||||
|
src = _inspect.getsource(rb_routes.update_rulebook)
|
||||||
|
assert "always_on" in src, "update_rulebook handler missing always_on in field whitelist"
|
||||||
|
|
||||||
|
|
||||||
def test_rule_and_subscription_handlers_callable():
|
def test_rule_and_subscription_handlers_callable():
|
||||||
from fabledassistant.routes import rulebooks as rb_routes
|
from fabledassistant.routes import rulebooks as rb_routes
|
||||||
for name in (
|
for name in (
|
||||||
|
|||||||
Reference in New Issue
Block a user