feat(placement): a record you only cite carries its status (#4154)

Step 1 made placement cheap for a task whose status CHANGES: create_task
and update_task return where it sits, and the report is written from
that. It did nothing for a task a reply merely cites.

This milestone's own step-6 review reported "#4014 is the open step of
milestone 409". #4014 had been done for four days; the open step was
#4015. The id did not come from a read — it came from a retrieval hint,
which carries an id, a kind and a title and says nothing about status,
while list_milestones said "8 of 9" and would not say which one. The
gap was there to be filled and the nearest-looking id filled it.

Two surfaces, one principle: the status arrives with the id.

1. get_project_milestone_summaries gains next_step — the earliest open
   step, {id, title, status} or None — carried through _BRIEF_FIELDS to
   enter_project, get_project and list_milestones. One extra flat query
   for the whole batch, so #2384's fan-out does not come back.

   OPEN_STEP_STATUSES moves to services/milestones.py and placement.py
   imports it; both surfaces now answer "what is next" and must not
   drift on what counts as open. Both step queries take the same
   readable_notes_clause (rule 78), so a row cannot name a step its own
   progress numbers exclude.

2. _record_kind renders a task's status: [task (done)], [issue (todo)].
   A finished step and an open one read identically before, which is
   exactly the line the misreport was taken from. Only tasks — is_task
   IS status-is-not-None on the model, so there is no fallback branch.

reporting-back gains the practice, owned and registered in the guidance
ownership table: a record you only mention is a record to read.

The guards are structural and each fails on the regression it names:
the query count is asserted rather than the payload shape, and the two
surfaces' agreement is pinned on the rendered ORDER BY, since a mocked
session hands back whatever order the test chose.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01821k5B3Ysecp9fNYs92Kuy

tests/test_retrieval_scopes.py

@@ -148,8 +148,10 @@ async def test_injected_menu_labels_the_record_kind():
     hits = [
         (0.92, fake_note(id=1, title="debounce — rate-limit a callback", note_type="snippet")),
         (0.91, fake_note(id=2, title="Release checklist", note_type="process")),
-        (0.90, fake_note(id=3, title="Auth token expiry", is_task=True, task_kind="issue")),
-        (0.89, fake_note(id=4, title="Ship the drafter", is_task=True)),
+        (0.90, fake_note(id=3, title="Auth token expiry", is_task=True,
+                         task_kind="issue", status="todo")),
+        (0.89, fake_note(id=4, title="Ship the drafter", is_task=True,
+                         status="done")),
         (0.88, fake_note(id=5, title="Why we dropped CalDAV")),
     ]
     with patch.object(plugin_context, "semantic_search_notes",
@@ -165,8 +167,10 @@ async def test_injected_menu_labels_the_record_kind():
     assert "[snippet]" in by_id[1]
     assert "[process]" in by_id[2]
     # Task-ness wins over note_type, and an issue says so rather than "task".
-    assert "[issue]" in by_id[3]
-    assert "[task]" in by_id[4]
+    # A task also carries its status (#4154): #4 is DONE, and a line that said
+    # only "[task]" is what let a finished step be cited as an open one.
+    assert "[issue (todo)]" in by_id[3]
+    assert "[task (done)]" in by_id[4]
     assert "[note]" in by_id[5]
     # Still title-first: the marker is metadata, not an excuse to carry bodies.
     assert "body" not in out["context"]