fix(theme): text on a filled colour needs its own token — the old one inverts

76 hardcoded `color: #fff` now resolve to --fs-text-on-action, a new token
that is parchment in BOTH modes.

The design system said they should supersede to --fs-text-primary, on the
recorded reasoning that "there is no 'text on action' colour, there is just the
text colour." That is true on dark and wrong on light. --fs-text-primary
inverts to #14171A; the surfaces underneath it do not invert at all — every one
of these 76 sits on an action colour, a semantic colour, the accent, or the CTA
gradient, all of which hold a single value across modes.

Sweeping as recorded would have put obsidian text on moss green: roughly 2.4:1,
against a house style whose stated floor is WCAG AA. It would have looked
correct to me, because I checked it in the mode where it was correct.

--color-accent-fg had the same defect independently and is repointed too.

The token check now reports zero superseded literals, down from 30 files, and
raw colour literals drop 246 -> 169.

Closes #2275.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UaYUaouG9jjhATyuxCKrQs

frontend/src/views/DesignSystemsView.vue

@@ -1273,14 +1273,9 @@ textarea.input {
   border: 1px solid transparent;
 }
 
-/* Background matches the house convention (--color-action-primary, as in
-   ProjectListView and four others). The text colour deliberately does NOT:
-   every existing copy uses `color: #fff`, which is 67 live violations of the
-   rule that pure white is never text (#2275). Parchment is what the rulebook
-   actually specifies. */
 .btn-primary {
   background: var(--color-action-primary);
-  color: #E8E4D8;
+  color: var(--fs-text-on-action);
 }
 
 .btn-primary:not(:disabled):hover {

frontend/src/views/ForgotPasswordView.vue

@@ -141,7 +141,7 @@ async function handleSubmit() {
   width: 100%;
   padding: 0.6rem;
   background: var(--color-primary);
-  color: #fff;
+  color: var(--fs-text-on-action);
   border: none;
   border-radius: var(--radius-sm);
   cursor: pointer;

frontend/src/views/KnowledgeView.vue

@@ -574,7 +574,7 @@ onUnmounted(() => {
   border-radius: 10px;
   border: none;
   background: var(--gradient-cta);
-  color: #fff;
+  color: var(--fs-text-on-action);
   cursor: pointer;
   font-size: 0.85rem;
   font-weight: 500;

frontend/src/views/LoginView.vue

@@ -180,7 +180,7 @@ function loginWithOAuth() {
   width: 100%;
   padding: 0.6rem;
   background: var(--color-primary);
-  color: #fff;
+  color: var(--fs-text-on-action);
   border: none;
   border-radius: var(--radius-sm);
   cursor: pointer;

frontend/src/views/NoteEditorView.vue

@@ -748,7 +748,7 @@ onUnmounted(() => assist.clearSelection());
   cursor: pointer;
   font-family: inherit;
 }
-.btn-link-all:hover { background: var(--color-primary); color: #fff; }
+.btn-link-all:hover { background: var(--color-primary); color: var(--fs-text-on-action); }
 
 .link-suggest-list {
   display: flex;

frontend/src/views/NoteViewerView.vue

@@ -354,7 +354,7 @@ async function convertToTask() {
   border: none;
   border-radius: var(--radius-sm);
   background: var(--color-action-primary);
-  color: #fff;
+  color: var(--fs-text-on-action);
   text-decoration: none;
   cursor: pointer;
   font-size: 0.875rem;
@@ -363,14 +363,14 @@ async function convertToTask() {
 }
 .btn-edit:hover {
   background: var(--color-action-primary-hover);
-  color: #fff;
+  color: var(--fs-text-on-action);
 }
 /* Convert + Share: Bronze action-secondary — alternate paths */
 .btn-convert {
   margin-left: auto;
   padding: 0.3rem 0.75rem;
   background: var(--color-action-secondary);
-  color: #fff;
+  color: var(--fs-text-on-action);
   border: none;
   border-radius: var(--radius-sm);
   cursor: pointer;
@@ -388,7 +388,7 @@ async function convertToTask() {
   background: var(--color-action-secondary);
   border: none;
   border-radius: var(--radius-sm);
-  color: #fff;
+  color: var(--fs-text-on-action);
   cursor: pointer;
   font-size: 0.85rem;
   font-family: inherit;

frontend/src/views/ProjectListView.vue

@@ -287,7 +287,7 @@ function overallPct(project: Project): { total: number; pct: number } {
 .btn-primary {
   padding: 0.45rem 1rem;
   background: var(--color-action-primary);
-  color: #fff;
+  color: var(--fs-text-on-action);
   border: none;
   border-radius: var(--radius-sm);
   cursor: pointer;
@@ -341,7 +341,7 @@ function overallPct(project: Project): { total: number; pct: number } {
 .empty-title { font-size: 1rem; font-weight: 500; color: var(--color-text-secondary); margin: 0 0 0.35rem; }
 .empty-sub { font-size: 0.85rem; margin: 0 0 1rem; }
 .empty-action { display: inline-block; padding: 0.4rem 1rem; border: 1px solid var(--color-primary); border-radius: var(--radius-sm); color: var(--color-primary); background: none; cursor: pointer; font-size: 0.85rem; transition: background 0.15s, color 0.15s; }
-.empty-action:hover { background: var(--color-primary); color: #fff; }
+.empty-action:hover { background: var(--color-primary); color: var(--fs-text-on-action); }
 
 .skeleton-card {
   height: 140px;
@@ -594,7 +594,7 @@ function overallPct(project: Project): { total: number; pct: number } {
 .modal-btn-primary {
   background: var(--color-primary);
   border-color: var(--color-primary);
-  color: #fff;
+  color: var(--fs-text-on-action);
 }
 .modal-btn-primary:hover:not(:disabled) {
   opacity: 0.9;

frontend/src/views/ProjectView.vue

@@ -879,7 +879,7 @@ async function confirmDelete() {
   gap: 0.35rem;
   padding: 0.45rem 1rem;
   background: var(--gradient-cta);
-  color: #fff;
+  color: var(--fs-text-on-action);
   border: none;
   border-radius: var(--radius-sm);
   font-size: 0.875rem;
@@ -888,14 +888,14 @@ async function confirmDelete() {
   box-shadow: var(--glow-cta);
   transition: box-shadow 0.15s, opacity 0.15s;
 }
-.btn-workspace:hover { box-shadow: var(--glow-cta-hover); opacity: 0.95; color: #fff; }
+.btn-workspace:hover { box-shadow: var(--glow-cta-hover); opacity: 0.95; color: var(--fs-text-on-action); }
 
 /* Share: Bronze action-secondary — alternate path */
 .btn-share {
   padding: 0.4rem 0.8rem;
   background: var(--color-action-secondary);
   border: none;
-  color: #fff;
+  color: var(--fs-text-on-action);
   border-radius: var(--radius-sm);
   cursor: pointer;
   font-size: 0.85rem;
@@ -917,7 +917,7 @@ async function confirmDelete() {
   font-family: inherit;
   transition: background 0.15s, color 0.15s;
 }
-.btn-danger-outline:hover { background: var(--color-action-destructive); color: #fff; }
+.btn-danger-outline:hover { background: var(--color-action-destructive); color: var(--fs-text-on-action); }
 
 .error-msg { color: var(--color-danger); font-size: 0.9rem; }
 
@@ -1065,7 +1065,7 @@ async function confirmDelete() {
 .btn-save-panel {
   padding: 0.45rem 0.9rem;
   background: var(--color-action-primary);
-  color: #fff;
+  color: var(--fs-text-on-action);
   border: none;
   border-radius: var(--radius-sm);
   cursor: pointer;
@@ -1151,7 +1151,7 @@ async function confirmDelete() {
 .btn-ms-confirm {
   padding: 0.3rem 0.65rem;
   background: var(--color-action-primary);
-  color: #fff;
+  color: var(--fs-text-on-action);
   border: none;
   border-radius: var(--radius-sm);
   cursor: pointer;
@@ -1165,7 +1165,7 @@ async function confirmDelete() {
   padding: 0.3rem 0.65rem;
   background: var(--color-action-secondary);
   border: none;
-  color: #fff;
+  color: var(--fs-text-on-action);
   border-radius: var(--radius-sm);
   cursor: pointer;
   font-size: 0.78rem;
@@ -1224,7 +1224,7 @@ async function confirmDelete() {
   cursor: pointer;
   border: 1px solid var(--color-border);
 }
-.ms-plan-actions .btn-primary { background: var(--color-primary); color: #fff; border-color: var(--color-primary); }
+.ms-plan-actions .btn-primary { background: var(--color-primary); color: var(--fs-text-on-action); border-color: var(--color-primary); }
 .ms-plan-actions .btn-primary:disabled { opacity: 0.6; cursor: default; }
 .ms-plan-actions .btn-secondary { background: var(--color-bg-card); color: var(--color-text); }
 
@@ -1393,8 +1393,8 @@ async function confirmDelete() {
   line-height: 1;
 }
 .task-card:hover .task-advance-btn { opacity: 1; }
-.task-advance-btn:hover { background: var(--color-primary); border-color: var(--color-primary); color: #fff; }
-.task-advance-btn--done:hover { background: var(--color-success, #22c55e); border-color: var(--color-success, #22c55e); color: #fff; }
+.task-advance-btn:hover { background: var(--color-primary); border-color: var(--color-primary); color: var(--fs-text-on-action); }
+.task-advance-btn--done:hover { background: var(--color-success, #22c55e); border-color: var(--color-success, #22c55e); color: var(--fs-text-on-action); }
 .task-advance-btn:disabled { opacity: 0.4; cursor: default; }
 
 .priority-dot {
@@ -1475,7 +1475,7 @@ async function confirmDelete() {
   font-family: inherit;
 }
 .modal-btn:hover { background: var(--color-bg); }
-.modal-btn-danger { background: var(--color-action-destructive); border-color: var(--color-action-destructive); color: #fff; }
+.modal-btn-danger { background: var(--color-action-destructive); border-color: var(--color-action-destructive); color: var(--fs-text-on-action); }
 .modal-btn-danger:hover { background: var(--color-action-destructive-hover); border-color: var(--color-action-destructive-hover); }
 
 /* ── Skeleton ────────────────────────────────────────────────── */

frontend/src/views/RegisterInviteView.vue

@@ -251,7 +251,7 @@ async function handleSubmit() {
   width: 100%;
   padding: 0.6rem;
   background: var(--color-primary);
-  color: #fff;
+  color: var(--fs-text-on-action);
   border: none;
   border-radius: var(--radius-sm);
   cursor: pointer;

frontend/src/views/RegisterView.vue

@@ -220,7 +220,7 @@ async function handleSubmit() {
   width: 100%;
   padding: 0.6rem;
   background: var(--color-primary);
-  color: #fff;
+  color: var(--fs-text-on-action);
   border: none;
   border-radius: var(--radius-sm);
   cursor: pointer;

frontend/src/views/ResetPasswordView.vue

@@ -199,7 +199,7 @@ async function handleSubmit() {
   width: 100%;
   padding: 0.6rem;
   background: var(--color-primary);
-  color: #fff;
+  color: var(--fs-text-on-action);
   border: none;
   border-radius: var(--radius-sm);
   cursor: pointer;

frontend/src/views/SettingsView.vue

@@ -2567,7 +2567,7 @@ function formatUserDate(iso: string): string {
 .btn-save {
   padding: 0.4rem 0.9rem;
   background: var(--color-action-primary);
-  color: #fff;
+  color: var(--fs-text-on-action);
   border: none;
   border-radius: var(--radius-sm);
   cursor: pointer;
@@ -2595,7 +2595,7 @@ function formatUserDate(iso: string): string {
 }
 .btn-danger-outline:hover:not(:disabled) {
   background: var(--color-action-destructive);
-  color: #fff;
+  color: var(--fs-text-on-action);
 }
 .btn-danger-outline:disabled { opacity: 0.5; cursor: default; }
 
@@ -2603,7 +2603,7 @@ function formatUserDate(iso: string): string {
 .btn-danger {
   padding: 0.4rem 0.9rem;
   background: var(--color-action-destructive);
-  color: #fff;
+  color: var(--fs-text-on-action);
   border: none;
   border-radius: var(--radius-sm);
   cursor: pointer;
@@ -2620,7 +2620,7 @@ function formatUserDate(iso: string): string {
 .btn-secondary {
   padding: 0.4rem 0.9rem;
   background: var(--color-action-secondary);
-  color: #fff;
+  color: var(--fs-text-on-action);
   border: none;
   border-radius: var(--radius-sm);
   cursor: pointer;
@@ -2685,7 +2685,7 @@ function formatUserDate(iso: string): string {
 .db-health-table tr.dh-warn td:first-child code { color: var(--color-warning); }
 .btn-warn:hover:not(:disabled) {
   background: var(--color-warning);
-  color: #fff;
+  color: var(--fs-text-on-action);
 }
 
 .saved-msg {
@@ -3000,7 +3000,7 @@ function formatUserDate(iso: string): string {
 .btn-confirm-delete {
   padding: 0.25rem 0.6rem;
   background: var(--color-action-destructive);
-  color: #fff;
+  color: var(--fs-text-on-action);
   border: none;
   border-radius: var(--radius-sm);
   cursor: pointer;
@@ -3033,7 +3033,7 @@ function formatUserDate(iso: string): string {
   transition: background 0.15s;
 }
 .btn-toggle:disabled { opacity: 0.6; cursor: default; }
-.btn-toggle-open { background: var(--color-action-primary); color: #fff; }
+.btn-toggle-open { background: var(--color-action-primary); color: var(--fs-text-on-action); }
 .btn-toggle-open:hover:not(:disabled) { background: var(--color-action-primary-hover); }
 .btn-toggle-close {
   background: var(--color-bg-secondary);
@@ -3151,7 +3151,7 @@ function formatUserDate(iso: string): string {
 .btn-primary {
   padding: 0.4rem 0.9rem;
   background: var(--color-action-primary);
-  color: #fff;
+  color: var(--fs-text-on-action);
   border: none;
   border-radius: var(--radius-sm);
   cursor: pointer;
@@ -3391,7 +3391,7 @@ function formatUserDate(iso: string): string {
 }
 .unit-btn.active {
   background: var(--color-action-primary);
-  color: #fff;
+  color: var(--fs-text-on-action);
 }
 .unit-btn:hover:not(.active) {
   color: var(--color-text);
@@ -3863,7 +3863,7 @@ function formatUserDate(iso: string): string {
 }
 .btn-danger-outline:hover:not(:disabled) {
   background: var(--color-action-destructive);
-  color: #fff;
+  color: var(--fs-text-on-action);
 }
 .btn-danger-outline:disabled { opacity: 0.5; cursor: default; }
 @keyframes va-dot-bounce {

frontend/src/views/SnippetDetailView.vue

@@ -268,7 +268,7 @@ async function confirmDelete() {
   padding: 0.35rem 0.8rem;
   border: none;
   background: var(--color-action-destructive, #6B2118);
-  color: #fff;
+  color: var(--fs-text-on-action);
   border-radius: var(--radius-sm);
   cursor: pointer;
   font-size: 0.85rem;

frontend/src/views/SnippetEditorView.vue

@@ -575,7 +575,7 @@ function cancel() {
 .btn-primary {
   padding: 0.5rem 1.1rem;
   background: var(--color-action-primary);
-  color: #fff;
+  color: var(--fs-text-on-action);
   border: none;
   border-radius: var(--radius-sm);
   cursor: pointer;

frontend/src/views/SnippetListView.vue

@@ -546,7 +546,7 @@ function usageTitle(s: SnippetListItem): string {
 .btn-primary {
   padding: 0.45rem 1rem;
   background: var(--color-action-primary);
-  color: #fff;
+  color: var(--fs-text-on-action);
   border: none;
   border-radius: var(--radius-sm);
   cursor: pointer;
@@ -679,7 +679,7 @@ function usageTitle(s: SnippetListItem): string {
 }
 .empty-action:hover {
   background: var(--color-primary);
-  color: #fff;
+  color: var(--fs-text-on-action);
 }
 
 .skeleton-grid,
@@ -1021,7 +1021,7 @@ function usageTitle(s: SnippetListItem): string {
 .modal-btn-primary {
   background: var(--color-action-primary);
   border-color: var(--color-action-primary);
-  color: #fff;
+  color: var(--fs-text-on-action);
 }
 .modal-btn-primary:hover:not(:disabled) {
   background: var(--color-action-primary-hover);

frontend/src/views/TaskEditorView.vue

@@ -971,7 +971,7 @@ useEditorGuards(dirty, save);
 .btn-subtask-confirm {
   padding: 0.25rem 0.5rem;
   background: var(--color-primary);
-  color: #fff;
+  color: var(--fs-text-on-action);
   border: none;
   border-radius: var(--radius-sm);
   cursor: pointer;

frontend/src/views/TaskViewerView.vue

@@ -501,7 +501,7 @@ const subTaskProgress = computed(() => {
   border: none;
   border-radius: var(--radius-sm);
   background: var(--color-action-primary);
-  color: #fff;
+  color: var(--fs-text-on-action);
   text-decoration: none;
   cursor: pointer;
   font-size: 0.875rem;
@@ -511,14 +511,14 @@ const subTaskProgress = computed(() => {
 .btn-edit:hover,
 .btn-advance:hover {
   background: var(--color-action-primary-hover);
-  color: #fff;
+  color: var(--fs-text-on-action);
 }
 /* Convert + Share: Bronze action-secondary — alternate paths */
 .btn-convert {
   margin-left: auto;
   padding: 0.3rem 0.75rem;
   background: var(--color-action-secondary);
-  color: #fff;
+  color: var(--fs-text-on-action);
   border: none;
   border-radius: var(--radius-sm);
   cursor: pointer;
@@ -536,7 +536,7 @@ const subTaskProgress = computed(() => {
   background: var(--color-action-secondary);
   border: none;
   border-radius: var(--radius-sm);
-  color: #fff;
+  color: var(--fs-text-on-action);
   cursor: pointer;
   font-size: 0.85rem;
   font-family: inherit;

frontend/src/views/UserManagementView.vue

@@ -331,7 +331,7 @@ function formatDate(iso: string): string {
 .btn-invite {
   padding: 0.45rem 1rem;
   background: var(--color-primary);
-  color: #fff;
+  color: var(--fs-text-on-action);
   border: none;
   border-radius: var(--radius-sm);
   cursor: pointer;
@@ -395,7 +395,7 @@ function formatDate(iso: string): string {
 }
 .btn-toggle-open {
   background: var(--color-primary);
-  color: #fff;
+  color: var(--fs-text-on-action);
 }
 .btn-toggle-open:hover:not(:disabled) {
   opacity: 0.9;
@@ -498,7 +498,7 @@ function formatDate(iso: string): string {
 .btn-confirm-delete {
   padding: 0.25rem 0.6rem;
   background: var(--color-danger);
-  color: #fff;
+  color: var(--fs-text-on-action);
   border: none;
   border-radius: var(--radius-sm);
   cursor: pointer;