fix(theme): text on a filled colour needs its own token — the old one inverts
CI & Build / Python lint (push) Successful in 4s
CI & Build / Plugin hooks (push) Successful in 13s
CI & Build / integration (push) Successful in 29s
CI & Build / TypeScript typecheck (push) Successful in 33s
CI & Build / Python tests (push) Successful in 55s
CI & Build / Build & push image (push) Successful in 41s

76 hardcoded `color: #fff` now resolve to --fs-text-on-action, a new token
that is parchment in BOTH modes.

The design system said they should supersede to --fs-text-primary, on the
recorded reasoning that "there is no 'text on action' colour, there is just the
text colour." That is true on dark and wrong on light. --fs-text-primary
inverts to #14171A; the surfaces underneath it do not invert at all — every one
of these 76 sits on an action colour, a semantic colour, the accent, or the CTA
gradient, all of which hold a single value across modes.

Sweeping as recorded would have put obsidian text on moss green: roughly 2.4:1,
against a house style whose stated floor is WCAG AA. It would have looked
correct to me, because I checked it in the mode where it was correct.

--color-accent-fg had the same defect independently and is repointed too.

The token check now reports zero superseded literals, down from 30 files, and
raw colour literals drop 246 -> 169.

Closes #2275.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UaYUaouG9jjhATyuxCKrQs
This commit is contained in:
2026-07-31 22:40:58 -04:00
co-authored by Claude Opus 5
parent 731ca284c3
commit 4c9a637507
32 changed files with 86 additions and 87 deletions
+8 -8
View File
@@ -56,7 +56,7 @@
.btn-save {
padding: 0.45rem 1.1rem;
background: var(--color-action-primary);
color: #fff;
color: var(--fs-text-on-action);
border: none;
border-radius: var(--radius-sm);
cursor: pointer;
@@ -76,7 +76,7 @@
.btn-delete {
padding: 0.45rem 1rem;
background: var(--color-action-destructive);
color: #fff;
color: var(--fs-text-on-action);
border: none;
border-radius: var(--radius-sm);
cursor: pointer;
@@ -187,12 +187,12 @@
}
.tag-pill:hover:not(:disabled) {
background: var(--color-primary);
color: #fff;
color: var(--fs-text-on-action);
}
.tag-pill.applied {
background: var(--color-success, #2ecc71);
border-color: var(--color-success, #2ecc71);
color: #fff;
color: var(--fs-text-on-action);
cursor: default;
}
.tag-check {
@@ -345,7 +345,7 @@
.btn-generate {
padding: 0.4rem 0.9rem;
background: var(--color-primary);
color: #fff;
color: var(--fs-text-on-action);
border: none;
border-radius: var(--radius-sm);
cursor: pointer;
@@ -478,7 +478,7 @@
.btn-accept {
padding: 0.4rem 1rem;
background: var(--color-success);
color: #fff;
color: var(--fs-text-on-action);
border: none;
border-radius: var(--radius-sm);
cursor: pointer;
@@ -537,7 +537,7 @@
}
.modal-btn-danger {
background: var(--color-danger);
color: #fff;
color: var(--fs-text-on-action);
border-color: var(--color-danger);
}
@@ -548,7 +548,7 @@
transform: translateX(-50%);
padding: 0.3rem 0.75rem;
background: var(--color-primary);
color: #fff;
color: var(--fs-text-on-action);
border: none;
border-radius: var(--radius-sm);
cursor: pointer;