refactor(settings): one bounded_float for every numeric bar read from settings
CI & Build / Python lint (push) Successful in 3s
CI & Build / Plugin hooks (push) Successful in 13s
CI & Build / integration (push) Successful in 52s
CI & Build / TypeScript typecheck (push) Successful in 54s
CI & Build / Python tests (push) Successful in 1m36s
CI & Build / Build & push image (push) Successful in 32s
CI & Build / Python lint (push) Successful in 3s
CI & Build / Plugin hooks (push) Successful in 13s
CI & Build / integration (push) Successful in 52s
CI & Build / TypeScript typecheck (push) Successful in 54s
CI & Build / Python tests (push) Successful in 1m36s
CI & Build / Build & push image (push) Successful in 32s
The shape ledger's divergence readout flagged _gate_setting (#4385). Reading it turned up a family with no canon: floor_for, get_duplicate_threshold, get_plan_match_threshold and _gate_setting each parsed a stored string, fell back to the default (never 0) and clamped into [lo, 1]. - services/settings.bounded_float(raw, default, lo=0, hi=1) is the pure parse, fallback and clamp. Each caller keeps its own get_setting read, so tests patching get_setting per module still take effect, and _gate_setting still fails open on an unreadable setting. - SettingsView.saveKbInject: eleven inline Math.min/Math.max clamps and the local gateAt become one asBar(v, d, lo = 0), mirroring the server. No behaviour change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -275,41 +275,44 @@ function actorLabel(actor: string): string {
|
||||
}
|
||||
|
||||
async function saveKbInject() {
|
||||
const t = Math.min(1, Math.max(0, Number(kbInjectThreshold.value) || 0));
|
||||
// Every similarity bar, clamped the way the server's `bounded_float` clamps
|
||||
// it: an unparseable value falls back to its default, never to 0, and `lo`
|
||||
// is the floor a bar that BLOCKS must not go under (0.80 block, 0.70 overlap).
|
||||
const asBar = (v: string, d: number, lo = 0) => Math.min(1, Math.max(lo, Number(v) || d));
|
||||
const t = asBar(kbInjectThreshold.value, 0);
|
||||
const k = Math.min(10, Math.max(1, Math.floor(Number(kbInjectTopK.value) || 1)));
|
||||
// `|| default` not `|| 0`: an unparseable value here should fall back to the
|
||||
// per-kind default, not to 0 — a 0 floor would report every record as a
|
||||
// duplicate of every other one.
|
||||
const dupSnip = Math.min(1, Math.max(0, Number(kbDupThresholdSnippet.value) || 0.82));
|
||||
const dupNote = Math.min(1, Math.max(0, Number(kbDupThresholdNote.value) || 0.93));
|
||||
const dupTask = Math.min(1, Math.max(0, Number(kbDupThresholdTask.value) || 0.93));
|
||||
const dupSnip = asBar(kbDupThresholdSnippet.value, 0.82);
|
||||
const dupNote = asBar(kbDupThresholdNote.value, 0.93);
|
||||
const dupTask = asBar(kbDupThresholdTask.value, 0.93);
|
||||
// The gate BLOCKS a write, so its bars have a floor the server enforces too:
|
||||
// 0.80 for a block, 0.70 for the overlap list.
|
||||
const gateAt = (v: string, d: number, lo: number) => Math.min(1, Math.max(lo, Number(v) || d));
|
||||
const gate = gateAt(kbGateThreshold.value, 0.9, 0.8);
|
||||
const gateSnip = gateAt(kbGateThresholdSnippet.value, 0.96, 0.8);
|
||||
const gateLesson = gateAt(kbGateThresholdLesson.value, 0.96, 0.8);
|
||||
const gateCopy = gateAt(kbGateThresholdNoteCopy.value, 0.98, 0.8);
|
||||
const gateOverlap = gateAt(kbGateNoteOverlapFloor.value, 0.87, 0.7);
|
||||
const gate = asBar(kbGateThreshold.value, 0.9, 0.8);
|
||||
const gateSnip = asBar(kbGateThresholdSnippet.value, 0.96, 0.8);
|
||||
const gateLesson = asBar(kbGateThresholdLesson.value, 0.96, 0.8);
|
||||
const gateCopy = asBar(kbGateThresholdNoteCopy.value, 0.98, 0.8);
|
||||
const gateOverlap = asBar(kbGateNoteOverlapFloor.value, 0.87, 0.7);
|
||||
// Same `|| default` guard: a floor of 0 would hand back an existing plan
|
||||
// for every new one, and no plan could be started without force.
|
||||
const planT = Math.min(1, Math.max(0, Number(kbPlanMatchThreshold.value) || 0.8));
|
||||
const planT = asBar(kbPlanMatchThreshold.value, 0.8);
|
||||
// Same `|| default` reasoning: falling back to 0 would surface every
|
||||
// snippet in the corpus on every edit, which is the failure this knob fixes.
|
||||
const wpT = Math.min(1, Math.max(0, Number(kbWritePathThreshold.value) || 0.68));
|
||||
const wpT = asBar(kbWritePathThreshold.value, 0.68);
|
||||
// Same `|| default` reasoning again, and it bites harder here: a rule hint
|
||||
// fires on every write, so a fallback of 0 would attach a standing rule to
|
||||
// every edit in the session.
|
||||
const rhT = Math.min(1, Math.max(0, Number(kbRuleHintThreshold.value) || 0.72));
|
||||
const rhT = asBar(kbRuleHintThreshold.value, 0.72);
|
||||
// Same `|| default` guard, and the same reason: this arm fires before every
|
||||
// Bash call, so a fallback of 0 would put a rule in front of every command.
|
||||
const trT = Math.min(1, Math.max(0, Number(kbToolRuleThreshold.value) || 0.68));
|
||||
const prT = Math.min(1, Math.max(0, Number(kbPromptRuleThreshold.value) || 0.72));
|
||||
const trT = asBar(kbToolRuleThreshold.value, 0.68);
|
||||
const prT = asBar(kbPromptRuleThreshold.value, 0.72);
|
||||
// The checkpoint bar, and the `|| default` guard matters most here of all:
|
||||
// this is the only number that can STOP a call, so a fallback of 0 would
|
||||
// hold the first command of every session behind whatever ranked first.
|
||||
const cpT = Math.min(1, Math.max(0, Number(kbCheckpointThreshold.value) || 0.8));
|
||||
const rpT = Math.min(1, Math.max(0, Number(kbReportPrefThreshold.value) || 0.72));
|
||||
const cpT = asBar(kbCheckpointThreshold.value, 0.8);
|
||||
const rpT = asBar(kbReportPrefThreshold.value, 0.72);
|
||||
// The budgets, clamped the way the server clamps them: a whole number in
|
||||
// [1, 10]. Never 0 — an arm turned off is turned off by its switch, and a
|
||||
// budget of zero would run the search, log the retrieval and render nothing,
|
||||
|
||||
Reference in New Issue
Block a user