fix(design-systems): declare tokenRationale — the ref its usages referenced
CI & Build / Python lint (push) Successful in 4s
CI & Build / Plugin hooks (push) Successful in 9s
CI & Build / integration (push) Successful in 14s
CI & Build / TypeScript typecheck (push) Successful in 32s
CI & Build / Python tests (push) Successful in 42s
CI & Build / Build & push image (push) Successful in 34s
CI & Build / Python lint (push) Successful in 4s
CI & Build / Plugin hooks (push) Successful in 9s
CI & Build / integration (push) Successful in 14s
CI & Build / TypeScript typecheck (push) Successful in 32s
CI & Build / Python tests (push) Successful in 42s
CI & Build / Build & push image (push) Successful in 34s
Broke the typecheck on 0f80b79. The scripted edit that added the three
`tokenRationale` usages and the one that declared the ref were separate
replacements, and only the declaration's anchor was wrong — so three usages
landed against a name that did not exist.
The declaration's replacement had no assertion on it while its neighbours did.
An anchor that matches nothing is a no-op, and a no-op looks exactly like
success.
This commit is contained in:
@@ -254,6 +254,8 @@ const showAddToken = ref(false);
|
|||||||
const tokenName = ref("");
|
const tokenName = ref("");
|
||||||
const tokenGroup = ref("");
|
const tokenGroup = ref("");
|
||||||
const tokenPurpose = ref("");
|
const tokenPurpose = ref("");
|
||||||
|
/** Why the token is this value — a different question from what it is for. */
|
||||||
|
const tokenRationale = ref("");
|
||||||
/** Mode/value pairs, edited as a list so a token can carry any number of modes. */
|
/** Mode/value pairs, edited as a list so a token can carry any number of modes. */
|
||||||
const tokenModes = ref<{ mode: string; value: string }[]>([{ mode: "base", value: "" }]);
|
const tokenModes = ref<{ mode: string; value: string }[]>([{ mode: "base", value: "" }]);
|
||||||
/** Literals this token should be written instead of, comma-separated in the
|
/** Literals this token should be written instead of, comma-separated in the
|
||||||
|
|||||||
Reference in New Issue
Block a user