bvandeusenandClaude Opus 5.5
79655fd19f
CI & Build / Python lint (push) Successful in 2s
CI & Build / Plugin hooks (push) Successful in 13s
CI & Build / TypeScript typecheck (push) Successful in 59s
CI & Build / integration (push) Successful in 1m32s
CI & Build / Python tests (push) Successful in 2m33s
CI & Build / Build & push image (push) Successful in 26s
Record, milestone, phase and plan citations go from every migration header; the "end before start" fix (0043) and the suppressed-count column (0095) state the condition they prevent rather than the incident. 0053 and 0055 pointed at design specs under docs/superpowers that are not in the repo; those pointers are removed. Kept: alembic's generated "Create Date:" headers (template metadata, not rationale), 0121's ARM_BORN justification beside the constant, and 0051's illustrative "update task 42" format example. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
72 lines
2.3 KiB
Python
72 lines
2.3 KiB
Python
"""replace events.end_dt with duration_minutes
|
|
|
|
Revision ID: 0043
|
|
Revises: 0042
|
|
Create Date: 2026-04-29
|
|
|
|
Structural fix for the "end before start" bug class: an event whose end_dt
|
|
precedes its start_dt disappears from upcoming-list filters. Storing duration instead of end_dt makes the invalid state
|
|
inexpressible at the schema level (duration_minutes >= 0).
|
|
|
|
Backfill rules:
|
|
- end_dt valid (end_dt > start_dt) → duration_minutes = total minutes
|
|
- end_dt == start_dt → duration_minutes = 0 (zero-duration point)
|
|
- end_dt NULL OR end_dt < start_dt → duration_minutes = NULL (corrupt
|
|
or open-ended; treated as a point event from here on)
|
|
|
|
Existing API consumers continue to receive `end_dt` in responses — the
|
|
field is now derived from `start_dt + duration_minutes` in
|
|
``Event.to_dict()`` rather than stored.
|
|
"""
|
|
from alembic import op
|
|
import sqlalchemy as sa
|
|
|
|
|
|
revision = "0043"
|
|
down_revision = "0042"
|
|
branch_labels = None
|
|
depends_on = None
|
|
|
|
|
|
def upgrade() -> None:
|
|
op.add_column(
|
|
"events",
|
|
sa.Column("duration_minutes", sa.Integer(), nullable=True),
|
|
)
|
|
op.create_check_constraint(
|
|
"events_duration_minutes_non_negative",
|
|
"events",
|
|
"duration_minutes IS NULL OR duration_minutes >= 0",
|
|
)
|
|
# Backfill: convert valid end_dt into a minute count; leave NULL for
|
|
# corrupt or absent end_dt. Bad rows (end_dt <= start_dt) collapse
|
|
# cleanly to point events instead of forcing a recovery guess.
|
|
op.execute(
|
|
"""
|
|
UPDATE events
|
|
SET duration_minutes = CAST(
|
|
EXTRACT(EPOCH FROM (end_dt - start_dt)) / 60 AS INTEGER
|
|
)
|
|
WHERE end_dt IS NOT NULL AND end_dt >= start_dt
|
|
"""
|
|
)
|
|
op.drop_column("events", "end_dt")
|
|
|
|
|
|
def downgrade() -> None:
|
|
op.add_column(
|
|
"events",
|
|
sa.Column("end_dt", sa.DateTime(timezone=True), nullable=True),
|
|
)
|
|
# Restore end_dt = start_dt + duration_minutes minutes for rows that
|
|
# had a duration. NULL duration → NULL end_dt (point event).
|
|
op.execute(
|
|
"""
|
|
UPDATE events
|
|
SET end_dt = start_dt + (duration_minutes || ' minutes')::interval
|
|
WHERE duration_minutes IS NOT NULL
|
|
"""
|
|
)
|
|
op.drop_constraint("events_duration_minutes_non_negative", "events")
|
|
op.drop_column("events", "duration_minutes")
|