bvandeusenandClaude Opus 5.5
0f5ef0be63
CI & Build / Python lint (push) Successful in 3s
CI & Build / Plugin hooks (push) Successful in 12s
CI & Build / TypeScript typecheck (push) Successful in 56s
CI & Build / integration (push) Successful in 1m4s
CI & Build / Python tests (push) Successful in 1m55s
CI & Build / Build & push image (push) Successful in 44s
Step 2 of the Scribe -> Grimoire rename. - src/scribe -> src/grimoire, and every import, patch target, module path, hypercorn entry point and `python -m grimoire.restore` with it; pyproject, uv.lock and the frontend package are named grimoire. - Image git.fabledsword.com/bvandeusen/fabledgrimoire; CI's Postgres service runs as grimoire / grimoire_test. - Compose files default the DB user, database and (prod) volume to grimoire, each overridable from .env, so an install created as Scribe keeps its data by setting POSTGRES_USER, POSTGRES_DB and PGDATA_VOLUME. - Backups are written as grimoire-<ts>.tar with format grimoire-backup-tar. Archives named scribe-* with the scribe-backup-tar manifest still restore and are still counted at the destination (folder and S3), with tests. - Exports, the MCP auth realm, the ASGI scope key and the persistent logger carry the new name. Kept on purpose: the secret-sealing key label stays "scribe.secrets.v1", because every stored secret was derived under it. Plugin identity (plugin name, hooks, env vars, .scribe marker, skills) is step 3. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
64 lines
2.7 KiB
Python
64 lines
2.7 KiB
Python
"""The canonical-slug matcher — the line between what maps mechanically and
|
|
what a human is asked to confirm.
|
|
|
|
These cases are real-world drift: one area carrying three spellings, and two areas that LOOK alike and are not the same.
|
|
Getting the boundary wrong in either direction is a silent failure — a missed
|
|
mapping nobody thinks to make again, or a cross-project record surfacing in the
|
|
wrong project.
|
|
"""
|
|
import pytest
|
|
|
|
from grimoire.services.canonical_systems import canonical_slug
|
|
|
|
|
|
@pytest.mark.parametrize("name", ["CI & Release", "CI and Release", "CI & release",
|
|
" ci and release "])
|
|
def test_spelling_variants_of_one_area_collapse_to_one_key(name):
|
|
"""Case, spacing, punctuation and "&" vs "and" are not real differences.
|
|
All three of the first spellings were live in different projects at once."""
|
|
assert canonical_slug(name) == "ci-and-release"
|
|
|
|
|
|
@pytest.mark.parametrize("name,expected", [
|
|
("Auth & Access", "auth-and-access"),
|
|
("Data Model & Storage", "data-model-and-storage"),
|
|
("UI & Design", "ui-and-design"),
|
|
("Background Jobs", "background-jobs"),
|
|
("Observability", "observability"),
|
|
])
|
|
def test_the_seeded_vocabulary_slugs_match_the_migration(name, expected):
|
|
"""Migration 0087 writes these slugs literally. If the function and the
|
|
migration disagree, every seeded entry becomes unreachable by exact match
|
|
and every mapping silently degrades to a proposal."""
|
|
assert canonical_slug(name) == expected
|
|
|
|
|
|
@pytest.mark.parametrize("a,b", [
|
|
("CI & Release", "CI & runners"),
|
|
("Auth & Access", "Auth & Accounts"),
|
|
("UI & Design", "Frontend (Vue app)"),
|
|
("UI & Design", "Web Shell and Theme"),
|
|
])
|
|
def test_genuinely_different_names_do_not_collapse(a, b):
|
|
"""These pairs may or may not be the same area — that is a judgment call,
|
|
so they must NOT map automatically. They reach the operator as proposals."""
|
|
assert canonical_slug(a) != canonical_slug(b)
|
|
|
|
|
|
def test_a_nameless_system_yields_no_key():
|
|
"""An empty slug is the one value callers must special-case: two unnameable
|
|
Systems must not map onto each other. Both propose_mappings and find_by_name
|
|
bail on a falsy slug for this reason."""
|
|
assert canonical_slug("") == ""
|
|
assert canonical_slug(" ") == ""
|
|
assert canonical_slug("---") == ""
|
|
|
|
|
|
def test_a_punctuation_separator_is_not_read_as_the_word_and():
|
|
""""CI/Release" is a real spelling and it does NOT collapse onto
|
|
"CI & Release" — only "&" carries that meaning. It still reaches the
|
|
operator through the overlap path, where both words match; what it must not
|
|
do is map itself silently."""
|
|
assert canonical_slug("CI/Release") == "ci-release"
|
|
assert canonical_slug("CI/Release") != canonical_slug("CI & Release")
|