Files
FabledGrimoire/tests/test_version_pinning_pin_unpin.py
bvandeusenandClaude Opus 5.5 0f5ef0be63
CI & Build / Python lint (push) Successful in 3s
CI & Build / Plugin hooks (push) Successful in 12s
CI & Build / TypeScript typecheck (push) Successful in 56s
CI & Build / integration (push) Successful in 1m4s
CI & Build / Python tests (push) Successful in 1m55s
CI & Build / Build & push image (push) Successful in 44s
rename(547): the server is grimoire — package, image, DB defaults, backups
Step 2 of the Scribe -> Grimoire rename.

- src/scribe -> src/grimoire, and every import, patch target, module path,
  hypercorn entry point and `python -m grimoire.restore` with it; pyproject,
  uv.lock and the frontend package are named grimoire.
- Image git.fabledsword.com/bvandeusen/fabledgrimoire; CI's Postgres service
  runs as grimoire / grimoire_test.
- Compose files default the DB user, database and (prod) volume to grimoire,
  each overridable from .env, so an install created as Scribe keeps its data
  by setting POSTGRES_USER, POSTGRES_DB and PGDATA_VOLUME.
- Backups are written as grimoire-<ts>.tar with format grimoire-backup-tar.
  Archives named scribe-* with the scribe-backup-tar manifest still restore
  and are still counted at the destination (folder and S3), with tests.
- Exports, the MCP auth realm, the ASGI scope key and the persistent logger
  carry the new name.

Kept on purpose: the secret-sealing key label stays "scribe.secrets.v1",
because every stored secret was derived under it.

Plugin identity (plugin name, hooks, env vars, .scribe marker, skills) is
step 3.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 10:50:45 -04:00

126 lines
4.4 KiB
Python

"""Tests for manual pin / unpin on note versions."""
from unittest.mock import AsyncMock, MagicMock, patch
from tests.helpers import make_mock_session
def _mock_session_for_version(mock_version):
mock_session = make_mock_session()
result = MagicMock()
result.scalars.return_value.first.return_value = mock_version
mock_session.execute = AsyncMock(return_value=result)
mock_session.commit = AsyncMock()
mock_session.refresh = AsyncMock()
return mock_session
async def test_pin_version_sets_manual_kind_and_label():
mock_version = MagicMock()
mock_version.pin_kind = None
mock_version.pin_label = None
with patch(
"grimoire.services.version_pinning.async_session",
return_value=_mock_session_for_version(mock_version),
):
from grimoire.services.version_pinning import pin_version
result = await pin_version(
user_id=1, note_id=42, version_id=7, label="the runbook circa Q2",
)
assert result is mock_version
assert mock_version.pin_kind == "manual"
assert mock_version.pin_label == "the runbook circa Q2"
async def test_pin_version_accepts_null_label():
"""label is optional — pinning with no label is allowed."""
mock_version = MagicMock()
mock_version.pin_kind = None
mock_version.pin_label = None
with patch(
"grimoire.services.version_pinning.async_session",
return_value=_mock_session_for_version(mock_version),
):
from grimoire.services.version_pinning import pin_version
await pin_version(user_id=1, note_id=42, version_id=7, label=None)
assert mock_version.pin_kind == "manual"
assert mock_version.pin_label is None
async def test_pin_version_promotes_auto_to_manual_with_label_update():
"""Pinning an already-auto-pinned version promotes it and updates label."""
mock_version = MagicMock()
mock_version.pin_kind = "auto"
mock_version.pin_label = "stable 2026-04-01 → 2026-04-05"
with patch(
"grimoire.services.version_pinning.async_session",
return_value=_mock_session_for_version(mock_version),
):
from grimoire.services.version_pinning import pin_version
await pin_version(
user_id=1, note_id=42, version_id=7, label="post-network-refresh",
)
assert mock_version.pin_kind == "manual"
assert mock_version.pin_label == "post-network-refresh"
async def test_pin_version_rejects_overlong_label():
"""Labels are capped at 500 chars to keep the UI sane."""
mock_version = MagicMock()
mock_version.pin_kind = None
# The cap is checked before any DB access, so the session shouldn't
# even be entered. We still patch it to avoid accidental DB lookups
# if the implementation order changes.
with patch(
"grimoire.services.version_pinning.async_session",
return_value=_mock_session_for_version(mock_version),
):
from grimoire.services.version_pinning import pin_version
try:
await pin_version(
user_id=1, note_id=42, version_id=7, label="x" * 501,
)
assert False, "expected ValueError"
except ValueError as e:
assert "500" in str(e) or "long" in str(e).lower()
async def test_pin_version_returns_none_when_not_found():
mock_session = make_mock_session()
result = MagicMock()
result.scalars.return_value.first.return_value = None
mock_session.execute = AsyncMock(return_value=result)
mock_session.commit = AsyncMock()
mock_session.refresh = AsyncMock()
with patch(
"grimoire.services.version_pinning.async_session",
return_value=mock_session,
):
from grimoire.services.version_pinning import pin_version
out = await pin_version(user_id=1, note_id=42, version_id=99, label=None)
assert out is None
async def test_unpin_version_clears_kind_and_label():
mock_version = MagicMock()
mock_version.pin_kind = "manual"
mock_version.pin_label = "previous label"
with patch(
"grimoire.services.version_pinning.async_session",
return_value=_mock_session_for_version(mock_version),
):
from grimoire.services.version_pinning import unpin_version
result = await unpin_version(user_id=1, note_id=42, version_id=7)
assert result is mock_version
assert mock_version.pin_kind is None
assert mock_version.pin_label is None