bvandeusenandClaude Opus 5.5
0f5ef0be63
CI & Build / Python lint (push) Successful in 3s
CI & Build / Plugin hooks (push) Successful in 12s
CI & Build / TypeScript typecheck (push) Successful in 56s
CI & Build / integration (push) Successful in 1m4s
CI & Build / Python tests (push) Successful in 1m55s
CI & Build / Build & push image (push) Successful in 44s
Step 2 of the Scribe -> Grimoire rename. - src/scribe -> src/grimoire, and every import, patch target, module path, hypercorn entry point and `python -m grimoire.restore` with it; pyproject, uv.lock and the frontend package are named grimoire. - Image git.fabledsword.com/bvandeusen/fabledgrimoire; CI's Postgres service runs as grimoire / grimoire_test. - Compose files default the DB user, database and (prod) volume to grimoire, each overridable from .env, so an install created as Scribe keeps its data by setting POSTGRES_USER, POSTGRES_DB and PGDATA_VOLUME. - Backups are written as grimoire-<ts>.tar with format grimoire-backup-tar. Archives named scribe-* with the scribe-backup-tar manifest still restore and are still counted at the destination (folder and S3), with tests. - Exports, the MCP auth realm, the ASGI scope key and the persistent logger carry the new name. Kept on purpose: the secret-sealing key label stays "scribe.secrets.v1", because every stored secret was derived under it. Plugin identity (plugin name, hooks, env vars, .scribe marker, skills) is step 3. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
51 lines
2.2 KiB
Python
51 lines
2.2 KiB
Python
"""/api/search — the kind filter it offers, and what it does with a bad one.
|
|
|
|
The route reads its kinds from the one table the vocabulary lives in, rather
|
|
than keeping a map of its own (`note`/`task`/everything else is `all`). Both
|
|
halves are pinned here: every declared kind is
|
|
reachable, and a kind that does not exist is refused rather than widened.
|
|
"""
|
|
import pytest
|
|
|
|
from grimoire.services.knowledge import FACET_TYPES, content_type_filters
|
|
|
|
|
|
def test_the_three_historical_values_still_mean_what_they_meant():
|
|
assert content_type_filters("all") == {"is_task": None}
|
|
assert content_type_filters("task")["is_task"] is True
|
|
# BROAD on purpose: any non-task, so snippets and lessons stay in scope.
|
|
assert content_type_filters("note") == {"is_task": False}
|
|
|
|
|
|
@pytest.mark.parametrize("facet", sorted(FACET_TYPES))
|
|
def test_every_declared_kind_is_reachable_through_this_door(facet):
|
|
"""The engine took `note_type` and `task_kind` all along — the route was
|
|
simply unable to say them."""
|
|
filters = content_type_filters(facet)
|
|
assert "is_task" in filters
|
|
if facet not in ("all", "note", "task"):
|
|
assert filters.get("note_type") == facet or filters.get("task_kind") == facet
|
|
|
|
|
|
def test_an_unknown_kind_is_refused_instead_of_silently_widening():
|
|
"""The old map read anything unrecognised as "no filter", so
|
|
`?content_type=snippets` returned the whole corpus while looking like a
|
|
narrowed search — the failure mode that answers a question nobody asked."""
|
|
with pytest.raises(ValueError) as err:
|
|
content_type_filters("snippets")
|
|
assert "snippets" in str(err.value)
|
|
assert "snippet" in str(err.value) # names the real ones
|
|
|
|
|
|
def test_a_doors_refusal_lists_only_what_that_door_accepts():
|
|
"""`rule` and `milestone` are the MCP tool's own searches. This route has
|
|
neither, so offering them in its error would send a caller at a parameter
|
|
that does not work here."""
|
|
with pytest.raises(ValueError) as plain:
|
|
content_type_filters("nonsense")
|
|
assert "rule" not in str(plain.value)
|
|
|
|
with pytest.raises(ValueError) as extra:
|
|
content_type_filters("nonsense", extra=("rule", "milestone"))
|
|
assert "rule" in str(extra.value) and "milestone" in str(extra.value)
|