Files
FabledGrimoire/tests/test_notes_description_field.py
bvandeusenandClaude Opus 5.5 0f5ef0be63
CI & Build / Python lint (push) Successful in 3s
CI & Build / Plugin hooks (push) Successful in 12s
CI & Build / TypeScript typecheck (push) Successful in 56s
CI & Build / integration (push) Successful in 1m4s
CI & Build / Python tests (push) Successful in 1m55s
CI & Build / Build & push image (push) Successful in 44s
rename(547): the server is grimoire — package, image, DB defaults, backups
Step 2 of the Scribe -> Grimoire rename.

- src/scribe -> src/grimoire, and every import, patch target, module path,
  hypercorn entry point and `python -m grimoire.restore` with it; pyproject,
  uv.lock and the frontend package are named grimoire.
- Image git.fabledsword.com/bvandeusen/fabledgrimoire; CI's Postgres service
  runs as grimoire / grimoire_test.
- Compose files default the DB user, database and (prod) volume to grimoire,
  each overridable from .env, so an install created as Scribe keeps its data
  by setting POSTGRES_USER, POSTGRES_DB and PGDATA_VOLUME.
- Backups are written as grimoire-<ts>.tar with format grimoire-backup-tar.
  Archives named scribe-* with the scribe-backup-tar manifest still restore
  and are still counted at the destination (folder and S3), with tests.
- Exports, the MCP auth realm, the ASGI scope key and the persistent logger
  carry the new name.

Kept on purpose: the secret-sealing key label stays "scribe.secrets.v1",
because every stored secret was derived under it.

Plugin identity (plugin name, hooks, env vars, .scribe marker, skills) is
step 3.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 10:50:45 -04:00

72 lines
2.5 KiB
Python

"""Tests for the description-field roundtrip through the notes service.
The description field is the user-stated goal/context on a task; distinct
from `body` which (post-Task-as-Durable-Record) becomes the LLM-maintained
consolidation summary.
"""
from unittest.mock import AsyncMock, MagicMock, patch
from tests.helpers import make_mock_session
def _mock_session_for_update(mock_note):
mock_session = make_mock_session()
mock_result = MagicMock()
mock_result.scalars.return_value.first.return_value = mock_note
mock_session.execute = AsyncMock(return_value=mock_result)
mock_session.commit = AsyncMock()
mock_session.refresh = AsyncMock()
return mock_session
async def test_update_note_persists_description():
"""update_note(description=...) should assign to note.description.
update_note already accepts **fields and uses setattr, so this exercises
that the new model column is reachable through the existing dynamic-fields
path (no service-layer change required beyond the model column).
"""
mock_note = MagicMock()
# Pre-existing state — None description, no recurrence, status untouched.
mock_note.description = None
mock_note.status = None
mock_note.recurrence_rule = None
mock_note.project_id = None
with patch(
"grimoire.services.notes.async_session",
return_value=_mock_session_for_update(mock_note),
):
from grimoire.services.notes import update_note
await update_note(1, 1, description="the goal text")
assert mock_note.description == "the goal text"
async def test_create_note_forwards_description_to_model():
"""create_note(description=...) should pass description into the Note
constructor so it gets persisted alongside title/body/etc."""
captured: dict = {}
class FakeNote:
def __init__(self, **kw):
captured.update(kw)
self.id = 1
self.project_id = kw.get("project_id")
for k, v in kw.items():
setattr(self, k, v)
mock_session = make_mock_session()
mock_session.add = MagicMock()
mock_session.commit = AsyncMock()
mock_session.refresh = AsyncMock()
with patch(
"grimoire.services.notes.async_session", return_value=mock_session
), patch("grimoire.services.notes.Note", FakeNote):
from grimoire.services.notes import create_note
await create_note(
user_id=1, title="renew cert", description="the goal text",
)
assert captured.get("description") == "the goal text"