bvandeusenandClaude Opus 5.5
0f5ef0be63
CI & Build / Python lint (push) Successful in 3s
CI & Build / Plugin hooks (push) Successful in 12s
CI & Build / TypeScript typecheck (push) Successful in 56s
CI & Build / integration (push) Successful in 1m4s
CI & Build / Python tests (push) Successful in 1m55s
CI & Build / Build & push image (push) Successful in 44s
Step 2 of the Scribe -> Grimoire rename. - src/scribe -> src/grimoire, and every import, patch target, module path, hypercorn entry point and `python -m grimoire.restore` with it; pyproject, uv.lock and the frontend package are named grimoire. - Image git.fabledsword.com/bvandeusen/fabledgrimoire; CI's Postgres service runs as grimoire / grimoire_test. - Compose files default the DB user, database and (prod) volume to grimoire, each overridable from .env, so an install created as Scribe keeps its data by setting POSTGRES_USER, POSTGRES_DB and PGDATA_VOLUME. - Backups are written as grimoire-<ts>.tar with format grimoire-backup-tar. Archives named scribe-* with the scribe-backup-tar manifest still restore and are still counted at the destination (folder and S3), with tests. - Exports, the MCP auth realm, the ASGI scope key and the persistent logger carry the new name. Kept on purpose: the secret-sealing key label stays "scribe.secrets.v1", because every stored secret was derived under it. Plugin identity (plugin name, hooks, env vars, .scribe marker, skills) is step 3. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
100 lines
3.8 KiB
Python
100 lines
3.8 KiB
Python
from unittest.mock import AsyncMock, patch
|
|
|
|
import pytest
|
|
from tests.helpers import fake_note
|
|
|
|
|
|
pytestmark = pytest.mark.usefixtures("_bind_user")
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_create_task_passes_kind():
|
|
# kind=plan is retired (plans are milestones); 'issue' exercises passthrough.
|
|
mock = AsyncMock(return_value=fake_note(task_kind="issue"))
|
|
with patch("grimoire.mcp.tools.tasks.notes_svc.create_note", mock):
|
|
from grimoire.mcp.tools.tasks import create_task
|
|
await create_task(title="P", kind="issue")
|
|
assert mock.call_args.kwargs["task_kind"] == "issue"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_list_tasks_passes_kind_filter():
|
|
mock = AsyncMock(return_value=([], 0))
|
|
with patch("grimoire.mcp.tools.tasks.notes_svc.list_notes", mock):
|
|
from grimoire.mcp.tools.tasks import list_tasks
|
|
await list_tasks(kind="plan")
|
|
assert mock.call_args.kwargs["task_kind"] == "plan"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_list_tasks_kind_empty_means_no_filter():
|
|
mock = AsyncMock(return_value=([], 0))
|
|
with patch("grimoire.mcp.tools.tasks.notes_svc.list_notes", mock):
|
|
from grimoire.mcp.tools.tasks import list_tasks
|
|
await list_tasks()
|
|
assert mock.call_args.kwargs["task_kind"] is None
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_create_task_passes_spike():
|
|
"""The kind a failed rule-check asks for.
|
|
|
|
Time-boxed, and its output is knowledge rather than a change — filing one
|
|
as `work` makes a finished investigation look like an abandoned change.
|
|
"""
|
|
mock = AsyncMock(return_value=fake_note(task_kind="spike"))
|
|
with patch("grimoire.mcp.tools.tasks.notes_svc.create_note", mock):
|
|
from grimoire.mcp.tools.tasks import create_task
|
|
await create_task(title="Can the runner be given a bash shell?", kind="spike")
|
|
assert mock.call_args.kwargs["task_kind"] == "spike"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_update_task_can_re_file_a_kind():
|
|
"""A task's kind must be CORRECTABLE, not write-once.
|
|
|
|
What a piece of work turns out to be is often clear only once it is under
|
|
way. Without a `kind` parameter on `update_task`, and with a REST route that
|
|
drops the field the editor sends, the save reports success and reverts on
|
|
reload.
|
|
"""
|
|
mock = AsyncMock(return_value=fake_note(task_kind="spike"))
|
|
with patch("grimoire.mcp.tools.tasks.notes_svc.update_note", mock):
|
|
from grimoire.mcp.tools.tasks import update_task
|
|
await update_task(task_id=1, kind="spike")
|
|
assert mock.call_args.kwargs["task_kind"] == "spike"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_update_task_leaves_kind_alone_when_not_given():
|
|
""""" means leave unchanged, as it does for every other field here."""
|
|
mock = AsyncMock(return_value=fake_note())
|
|
with patch("grimoire.mcp.tools.tasks.notes_svc.update_note", mock):
|
|
from grimoire.mcp.tools.tasks import update_task
|
|
await update_task(task_id=1, title="renamed")
|
|
assert "task_kind" not in mock.call_args.kwargs
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_minting_a_plan_is_refused_at_both_doors():
|
|
"""`plan` is a valid stored value and NOT a mintable one.
|
|
|
|
Historical plan-tasks carry it and must stay writable, so the column
|
|
keeps accepting it — but plans became milestones in 0066, so no door
|
|
hands out a new one. The error names start_planning rather than just
|
|
refusing, because a caller reaching for kind='plan' wants a plan.
|
|
"""
|
|
from grimoire.services.notes import minted_kind
|
|
|
|
with pytest.raises(ValueError, match="start_planning"):
|
|
minted_kind("plan")
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_an_unknown_kind_raises_rather_than_defaulting():
|
|
"""A silently-corrected kind is the defect this whole fix exists to end."""
|
|
from grimoire.services.notes import minted_kind
|
|
|
|
with pytest.raises(ValueError, match="kind must be one of"):
|
|
minted_kind("investigation")
|