Release: a verdict on a vanished shape revives its row #222

Merged

bvandeusen merged 1 commits from dev into main 2026-11-05 16:51:10 -05:00

Conversation 0 Commits 1 Files Changed 2

+121 -7

bvandeusen commented 2026-11-05 16:51:05 -05:00

Owner

Copy Link

Copy Source

• #6872: classify_shapes(repo=…) and the write-path hook revive a soft-vanished shape row instead of inserting a duplicate that broke uq_code_shapes_identity and lost the whole batch. A concurrent insert of the same identity falls back to the other request's row inside a savepoint.

CI run 10253 green on dev 6be4401.

🤖 Generated with Claude Code

- #6872: `classify_shapes(repo=…)` and the write-path hook revive a soft-vanished shape row instead of inserting a duplicate that broke `uq_code_shapes_identity` and lost the whole batch. A concurrent insert of the same identity falls back to the other request's row inside a savepoint. CI run 10253 green on dev 6be4401. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

bvandeusen added 1 commit 2026-11-05 16:51:06 -05:00

fix(6872): a verdict or write-path stamp on a vanished shape revives its row instead of inserting a duplicate ... 6be44013bb

classify_shapes(repo=...) and the write-path hook looked only at live rows,
so a shape whose row had vanished got a second provisional row under the
same (project, repo, path, symbol, kind). The unique constraint refused it,
and the whole classify batch was lost as a tool error.

provisional_row() now finds the row under that identity, vanished or not.
A vanished row is revived with a reappeared event and keeps its judgment.
A new row is inserted inside a savepoint, so a concurrent insert of the
same identity falls back to that row instead of failing the transaction.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

bvandeusen merged commit 7e733ab966 into main 2026-11-05 16:51:10 -05:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

renovate-bot bvandeusen

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: bvandeusen/FabledGrimoire#222