4 Commits

Include renames

Author	SHA1	Message	Date
bvandeusenandClaude Opus 4.8	c363a5a6df	fix(retention): add cleanup sweeps + CalDAV orphan reconciliation ... Drift-audit Group 4 (retention / unbounded growth): - CalDAV pull now reconciles deletions: a previously-synced event whose caldav_uid no longer appears remotely within the synced window is soft-deleted (one batch_id per run, restorable), so a remote delete propagates locally instead of orphaning forever. Guarded on a non-empty fetch so a spurious empty result can't wipe every local copy. Also wrap the blocking fetch in a 120s wait_for and log run duration. - Notifications: hourly loop now purges read notifications older than 30d (unread kept). Table no longer grows without bound. - Auth tokens: new daily sweep deletes password-reset / invitation tokens whose validity window ended >7d ago; wired via start_auth_token_retention_loop in app startup. Both tables previously only flipped used=True, never pruned. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-06-02 18:55:23 -04:00
bvandeusenandClaude Opus 4.8	5fe0fd126d	fix(soft-delete): filter trashed rows across read/write paths ... Drift-audit Group 3 (soft-delete lifecycle gaps). Trashed rows were leaking into reads and being mutated/resurrected by writes: - update SELECTs now exclude trashed rows: update_milestone, update_project, update_event, and get_milestone_in_project (the latter backs all four milestone routes). Mutating a trashed row silently persisted and reappeared on restore. - MCP get_recent (notes/projects/events) and list_tags now filter deleted_at IS NULL, so trashed items stop surfacing in the agent's bootstrap context and tag counts. - convert_task_to_note clears recurrence_rule + recurrence_next_spawn_at so a demoted note can't spawn children via the (now-live) sweep. - caldav pull skips locally-trashed events (by caldav_uid) instead of resurrecting them via update or creating a duplicate live copy. - trash _cascade now stamps the FULL sub-task subtree (iterative descent), not just direct children, so deeply nested sub-tasks restore as one batch. Test updated for the new descent query. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-06-02 18:51:40 -04:00
bvandeusenandClaude Opus 4.7	4c58603009	feat(events): replace end_dt column with duration_minutes (#160) ... Structural fix for the "end before start" bug class observed on prod 2026-04-29. Bad data became inexpressible at the schema level instead of getting trapped in defensive read-path filters. The hotfix that landed earlier today (94b169f) is reverted by the preceding revert commit; this commit supersedes it cleanly with a proper data-model change. ## Schema (migration 0043) - Add `duration_minutes INTEGER NULLABLE` column on `events`. - CHECK constraint: ``duration_minutes IS NULL OR duration_minutes >= 0``. - Backfill from existing `end_dt`: - end_dt valid (end > start) → duration_minutes = total minutes - end_dt == start → duration_minutes = 0 (zero-duration point) - end_dt NULL or end_dt < start → duration_minutes = NULL (the corrupt prod row collapses cleanly to a point event) - Drop the `end_dt` column. The wire format is preserved — `to_dict()` emits `end_dt` as a derived `start_dt + duration_minutes`. Existing API consumers (Flutter app, web frontend, CalDAV sync) keep receiving the same response shape; they just no longer have a way to PUT a stored `end_dt` that disagrees with `start_dt`. ## Service layer - `Event.end_dt` becomes a `@property`. Setting it would require a setter we deliberately don't define — writes always go through `duration_minutes`. - `_normalize_duration` is the single source-of-truth for input reduction. Accepts (start, end_dt, duration_minutes), returns the canonical `duration_minutes`, raises `ValueError` for negative durations, end-before-start, or end/duration disagreement. - `create_event` and `update_event` accept either `end_dt` or `duration_minutes` for ergonomic compat; both convert via `_normalize_duration`. Update validates the post-update state when the patch includes either. - `list_events` filter is simpler now: a coarse SQL prefilter (`start_dt <= date_to`) plus Python-side refinement using the derived `end_dt`. Avoids Postgres-specific interval arithmetic in the WHERE clause; refinement runs over a per-user result set so there's no scan-cost concern at personal scale. - Recurring-event expansion uses `event.duration_minutes` directly instead of computing `end - start`. No more negative-timedelta hazard. ## CalDAV sync (incoming + outgoing) - `caldav_sync.py` (pull) and `calendar_sync.py` (Radicale upsert) both convert iCal `DTEND` → `duration_minutes` on the way in. Outbound iCal still emits `DTEND` as `start_dt + duration_minutes` via the model's derived property. iCal interop is unchanged. ## Behavioral upgrade for `update_event` Pure end_dt model: moving start past the existing end_dt would either silently corrupt or hard-reject. Duration model: the duration is preserved by default, so moving start slides the effective end forward — which is what users mean when they "move" an event. Explicit clear is still possible via `end_dt=None`. ## Tests `tests/test_events_service.py`: - 6 new `_normalize_duration` unit tests (sugar conversion, zero duration valid as point event, end-before-start rejected, negative duration rejected, inconsistent end+duration rejected, none → None) - New behavioral test: `update_event` preserves duration when only start_dt changes (sliding semantics) - New: clearing `end_dt=None` on update collapses to point event - New: list_events surfaces a point event in the upcoming window - New: list_events excludes a timed event whose effective end has already passed - Existing mock-event helper updated to use `duration_minutes` instead of stored `end_dt`. 44 event-related tests pass; ruff clean. ## Out of scope (separate task) Fable #161 — `find_events_by_query` returning multiple matches and silently picking matches[0]. The exact root cause of how event id=2 got mutated in the first place; orthogonal to the storage model. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-04-29 14:19:44 -04:00
bvandeusenandClaude Sonnet 4.6	edfed6b5bb	feat(events): recurring expansion, CalDAV pull sync, past search, reminders ... - RRULE expansion: list_events now expands recurring events into individual occurrences within the query window using python-dateutil - CalDAV pull sync: new caldav_sync.py + POST /api/events/sync route; imports remote events into the internal store by caldav_uid - Past event search: search_events accepts include_past=true to search historical events; exposed in the LLM tool definition - Internal reminders: migration 0037 adds reminder_minutes + reminder_sent_at columns; event_scheduler.py checks every 5 min and fires push notifications; CalDAV sync job runs hourly - reminder_minutes now stored and returned in create/update routes + tools Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-04-04 12:15:37 -04:00