docs(6209): calibration stamp, after-write hook, usage seam, work log, duplicates, skill structure, tuning and rulebook routes, kind surface, prompt filter, moments, strict args, auth, lesson write path
Fourteen more test files: docstrings state the failure each guard defends as a present-tense shape instead of the incident that found it, and issue, milestone and rule numbers leave comments and assertion messages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -1,19 +1,14 @@
|
||||
"""One seam attaches `usage`, and every door that shows it uses that seam (#4230).
|
||||
"""One seam attaches `usage`, and every door that shows it uses that seam.
|
||||
|
||||
WHAT WENT WRONG. `usage_for_notes` is named for notes and works on every note
|
||||
row. Yet the surfaced-vs-opened chip reached snippets and rules only: notes had
|
||||
it nowhere, and lessons had it collected but shown nowhere a person could
|
||||
reach, because the only lesson LIST in the UI is the Knowledge browse and that
|
||||
route never attached it.
|
||||
|
||||
The cause was not any one missing line. Seven call sites carried their own copy
|
||||
of the same few lines — two REST lists, two REST details, two MCP lists, one
|
||||
MCP detail — and each read perfectly well on its own. Nobody was comparing
|
||||
them, so "which doors attach usage?" had no answer anywhere in the code. That
|
||||
is the same failure `test_system_tagging_door_parity.py` records for System
|
||||
tagging (#4249): whichever door nobody exercised for a kind is the one that
|
||||
never grew the feature, and a human reviewer does not reliably catch it because
|
||||
each door is only ever read alone.
|
||||
WHY. `usage_for_notes` is named for notes and works on every note row, and
|
||||
seven doors show its result — two REST lists, two REST details, two MCP
|
||||
lists, one MCP detail. Seven copies of the same few lines each read perfectly
|
||||
well on their own, and nobody compares them, so "which doors attach usage?"
|
||||
has no answer anywhere in the code. That is the same failure
|
||||
`test_system_tagging_door_parity.py` records for System tagging: whichever
|
||||
door nobody exercises for a kind is the one that
|
||||
never grows the feature, and a human reviewer does not reliably catch it
|
||||
because each door is only ever read alone.
|
||||
|
||||
So this file asserts the PROPERTY, not the behaviour of one route: the attach
|
||||
logic exists once, and no door re-implements it. A kind added next month either
|
||||
@@ -156,7 +151,7 @@ def test_no_door_calls_the_aggregate_directly() -> None:
|
||||
|
||||
Keyed on the CALL, not on the text, so a module that merely names the
|
||||
function in a comment explaining the seam is not a false positive — and a
|
||||
hand-kept skip list, which would itself go stale, is not needed (rule 167).
|
||||
hand-kept skip list, which would itself go stale, is not needed.
|
||||
"""
|
||||
offenders = []
|
||||
for path in _door_modules():
|
||||
|
||||
Reference in New Issue
Block a user