rename(547): the server is grimoire — package, image, DB defaults, backups
CI & Build / Python lint (push) Successful in 3s
CI & Build / Plugin hooks (push) Successful in 12s
CI & Build / TypeScript typecheck (push) Successful in 56s
CI & Build / integration (push) Successful in 1m4s
CI & Build / Python tests (push) Successful in 1m55s
CI & Build / Build & push image (push) Successful in 44s
CI & Build / Python lint (push) Successful in 3s
CI & Build / Plugin hooks (push) Successful in 12s
CI & Build / TypeScript typecheck (push) Successful in 56s
CI & Build / integration (push) Successful in 1m4s
CI & Build / Python tests (push) Successful in 1m55s
CI & Build / Build & push image (push) Successful in 44s
Step 2 of the Scribe -> Grimoire rename. - src/scribe -> src/grimoire, and every import, patch target, module path, hypercorn entry point and `python -m grimoire.restore` with it; pyproject, uv.lock and the frontend package are named grimoire. - Image git.fabledsword.com/bvandeusen/fabledgrimoire; CI's Postgres service runs as grimoire / grimoire_test. - Compose files default the DB user, database and (prod) volume to grimoire, each overridable from .env, so an install created as Scribe keeps its data by setting POSTGRES_USER, POSTGRES_DB and PGDATA_VOLUME. - Backups are written as grimoire-<ts>.tar with format grimoire-backup-tar. Archives named scribe-* with the scribe-backup-tar manifest still restore and are still counted at the destination (folder and S3), with tests. - Exports, the MCP auth realm, the ASGI scope key and the persistent logger carry the new name. Kept on purpose: the secret-sealing key label stays "scribe.secrets.v1", because every stored secret was derived under it. Plugin identity (plugin name, hooks, env vars, .scribe marker, skills) is step 3. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -3,7 +3,7 @@ from unittest.mock import AsyncMock, MagicMock, patch
|
||||
|
||||
import pytest
|
||||
|
||||
from scribe.mcp.tools.milestones import (
|
||||
from grimoire.mcp.tools.milestones import (
|
||||
list_milestones, get_milestone, create_milestone, update_milestone,
|
||||
)
|
||||
from tests.helpers import fake_milestone, fake_task
|
||||
@@ -16,7 +16,7 @@ pytestmark = pytest.mark.usefixtures("_bind_user")
|
||||
def _no_plan_gate():
|
||||
"""The plan gate reads the database; these tests are about what reaches
|
||||
the service. The gate's own tests re-patch it."""
|
||||
with patch("scribe.mcp.tools.milestones.dedup_svc.plan_gate",
|
||||
with patch("grimoire.mcp.tools.milestones.dedup_svc.plan_gate",
|
||||
AsyncMock(return_value=None)):
|
||||
yield
|
||||
|
||||
@@ -25,7 +25,7 @@ def _no_plan_gate():
|
||||
async def test_list_milestones_returns_dict_with_progress():
|
||||
rows = [{"id": 1, "title": "MS1", "status": "active", "total": 2}]
|
||||
with patch(
|
||||
"scribe.mcp.tools.milestones.milestones_svc.get_project_milestone_summary",
|
||||
"grimoire.mcp.tools.milestones.milestones_svc.get_project_milestone_summary",
|
||||
AsyncMock(return_value=rows),
|
||||
):
|
||||
out = await list_milestones(project_id=1)
|
||||
@@ -36,7 +36,7 @@ async def test_list_milestones_returns_dict_with_progress():
|
||||
async def test_create_milestone_passes_through():
|
||||
m = fake_milestone(id=5)
|
||||
mock = AsyncMock(return_value=m)
|
||||
with patch("scribe.mcp.tools.milestones.milestones_svc.create_milestone", mock):
|
||||
with patch("grimoire.mcp.tools.milestones.milestones_svc.create_milestone", mock):
|
||||
out = await create_milestone(project_id=1, title="new", description="d")
|
||||
assert out["id"] == 5
|
||||
assert mock.call_args.kwargs["project_id"] == 1
|
||||
@@ -48,7 +48,7 @@ async def test_create_milestone_passes_through():
|
||||
async def test_create_milestone_empty_description_becomes_none():
|
||||
m = fake_milestone()
|
||||
mock = AsyncMock(return_value=m)
|
||||
with patch("scribe.mcp.tools.milestones.milestones_svc.create_milestone", mock):
|
||||
with patch("grimoire.mcp.tools.milestones.milestones_svc.create_milestone", mock):
|
||||
await create_milestone(project_id=1, title="t", description="")
|
||||
assert mock.call_args.kwargs["description"] is None
|
||||
|
||||
@@ -58,7 +58,7 @@ async def test_create_milestone_passes_body_through():
|
||||
"""The milestone-as-plan body is forwarded to the service."""
|
||||
m = fake_milestone(id=5)
|
||||
mock = AsyncMock(return_value=m)
|
||||
with patch("scribe.mcp.tools.milestones.milestones_svc.create_milestone", mock):
|
||||
with patch("grimoire.mcp.tools.milestones.milestones_svc.create_milestone", mock):
|
||||
await create_milestone(project_id=1, title="t", body="## Goal\n\nship")
|
||||
assert mock.call_args.kwargs["body"] == "## Goal\n\nship"
|
||||
|
||||
@@ -67,7 +67,7 @@ async def test_create_milestone_passes_body_through():
|
||||
async def test_create_milestone_empty_body_becomes_none():
|
||||
m = fake_milestone()
|
||||
mock = AsyncMock(return_value=m)
|
||||
with patch("scribe.mcp.tools.milestones.milestones_svc.create_milestone", mock):
|
||||
with patch("grimoire.mcp.tools.milestones.milestones_svc.create_milestone", mock):
|
||||
await create_milestone(project_id=1, title="t", body="")
|
||||
assert mock.call_args.kwargs["body"] is None
|
||||
|
||||
@@ -76,9 +76,9 @@ async def test_create_milestone_empty_body_becomes_none():
|
||||
async def test_create_milestone_returns_the_active_plan_that_already_covers_it():
|
||||
match = {"duplicate": True, "existing_id": 4}
|
||||
create = AsyncMock()
|
||||
with patch("scribe.mcp.tools.milestones.dedup_svc.plan_gate",
|
||||
with patch("grimoire.mcp.tools.milestones.dedup_svc.plan_gate",
|
||||
AsyncMock(return_value=match)) as gate, \
|
||||
patch("scribe.mcp.tools.milestones.milestones_svc.create_milestone", create):
|
||||
patch("grimoire.mcp.tools.milestones.milestones_svc.create_milestone", create):
|
||||
out = await create_milestone(project_id=1, title="t", description="d", body="b")
|
||||
assert out is match
|
||||
create.assert_not_awaited()
|
||||
@@ -92,8 +92,8 @@ async def test_create_milestone_skips_the_gate_when_forced_or_done():
|
||||
plan competing with an open one."""
|
||||
gate = AsyncMock(return_value={"duplicate": True})
|
||||
create = AsyncMock(return_value=fake_milestone(id=6))
|
||||
with patch("scribe.mcp.tools.milestones.dedup_svc.plan_gate", gate), \
|
||||
patch("scribe.mcp.tools.milestones.milestones_svc.create_milestone", create):
|
||||
with patch("grimoire.mcp.tools.milestones.dedup_svc.plan_gate", gate), \
|
||||
patch("grimoire.mcp.tools.milestones.milestones_svc.create_milestone", create):
|
||||
assert (await create_milestone(project_id=1, title="t", force=True))["id"] == 6
|
||||
assert (await create_milestone(project_id=1, title="t", status="done"))["id"] == 6
|
||||
gate.assert_not_awaited()
|
||||
@@ -103,7 +103,7 @@ async def test_create_milestone_skips_the_gate_when_forced_or_done():
|
||||
async def test_update_milestone_sends_body():
|
||||
m = fake_milestone()
|
||||
mock = AsyncMock(return_value=m)
|
||||
with patch("scribe.mcp.tools.milestones.milestones_svc.update_milestone", mock):
|
||||
with patch("grimoire.mcp.tools.milestones.milestones_svc.update_milestone", mock):
|
||||
await update_milestone(project_id=1, milestone_id=5, body="new plan")
|
||||
assert mock.call_args.kwargs == {"body": "new plan"}
|
||||
|
||||
@@ -114,13 +114,13 @@ async def test_get_milestone_returns_body_steps_and_rules():
|
||||
step = fake_task(id=9, title="step 1", milestone_id=5, body="a long step body")
|
||||
applicable = {"rules": [{"id": 1, "title": "r"}], "truncated": False,
|
||||
"project_rules": [{"id": 3, "title": "own"}]}
|
||||
with patch("scribe.mcp.tools.milestones.milestones_svc.get_milestone",
|
||||
with patch("grimoire.mcp.tools.milestones.milestones_svc.get_milestone",
|
||||
AsyncMock(return_value=m)), \
|
||||
patch("scribe.mcp.tools.milestones.milestones_svc.get_milestone_progress",
|
||||
patch("grimoire.mcp.tools.milestones.milestones_svc.get_milestone_progress",
|
||||
AsyncMock(return_value={"total": 1, "completed": 0, "pct": 0.0})), \
|
||||
patch("scribe.mcp.tools.milestones.notes_svc.list_notes",
|
||||
patch("grimoire.mcp.tools.milestones.notes_svc.list_notes",
|
||||
AsyncMock(return_value=([step], 1))), \
|
||||
patch("scribe.mcp.tools.milestones.rulebooks_svc.get_applicable_rules",
|
||||
patch("grimoire.mcp.tools.milestones.rulebooks_svc.get_applicable_rules",
|
||||
AsyncMock(return_value=applicable)):
|
||||
out = await get_milestone(milestone_id=5)
|
||||
assert out["milestone"]["body"] == "## Goal"
|
||||
@@ -134,7 +134,7 @@ async def test_get_milestone_returns_body_steps_and_rules():
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_get_milestone_raises_when_not_found():
|
||||
with patch("scribe.mcp.tools.milestones.milestones_svc.get_milestone",
|
||||
with patch("grimoire.mcp.tools.milestones.milestones_svc.get_milestone",
|
||||
AsyncMock(return_value=None)):
|
||||
with pytest.raises(ValueError, match="milestone 999 not found"):
|
||||
await get_milestone(milestone_id=999)
|
||||
@@ -144,7 +144,7 @@ async def test_get_milestone_raises_when_not_found():
|
||||
async def test_update_milestone_only_sends_non_default_fields():
|
||||
m = fake_milestone()
|
||||
mock = AsyncMock(return_value=m)
|
||||
with patch("scribe.mcp.tools.milestones.milestones_svc.update_milestone", mock):
|
||||
with patch("grimoire.mcp.tools.milestones.milestones_svc.update_milestone", mock):
|
||||
await update_milestone(project_id=1, milestone_id=5, status="done")
|
||||
args, kwargs = mock.call_args
|
||||
assert args == (7, 5)
|
||||
@@ -156,7 +156,7 @@ async def test_update_milestone_order_index_negative_is_omitted():
|
||||
"""order_index=-1 sentinel means leave unchanged."""
|
||||
m = fake_milestone()
|
||||
mock = AsyncMock(return_value=m)
|
||||
with patch("scribe.mcp.tools.milestones.milestones_svc.update_milestone", mock):
|
||||
with patch("grimoire.mcp.tools.milestones.milestones_svc.update_milestone", mock):
|
||||
await update_milestone(project_id=1, milestone_id=5, order_index=-1)
|
||||
assert "order_index" not in mock.call_args.kwargs
|
||||
|
||||
@@ -166,7 +166,7 @@ async def test_update_milestone_order_index_zero_is_explicit():
|
||||
"""order_index=0 is a real value (top of list), not a sentinel."""
|
||||
m = fake_milestone()
|
||||
mock = AsyncMock(return_value=m)
|
||||
with patch("scribe.mcp.tools.milestones.milestones_svc.update_milestone", mock):
|
||||
with patch("grimoire.mcp.tools.milestones.milestones_svc.update_milestone", mock):
|
||||
await update_milestone(project_id=1, milestone_id=5, order_index=0)
|
||||
assert mock.call_args.kwargs["order_index"] == 0
|
||||
|
||||
@@ -174,7 +174,7 @@ async def test_update_milestone_order_index_zero_is_explicit():
|
||||
@pytest.mark.asyncio
|
||||
async def test_update_milestone_raises_when_not_found():
|
||||
with patch(
|
||||
"scribe.mcp.tools.milestones.milestones_svc.update_milestone",
|
||||
"grimoire.mcp.tools.milestones.milestones_svc.update_milestone",
|
||||
AsyncMock(return_value=None),
|
||||
):
|
||||
with pytest.raises(ValueError, match="milestone 999 not found"):
|
||||
|
||||
Reference in New Issue
Block a user