Files
FabledCurator/tests/test_head_auto_apply.py
T
bvandeusenandClaude Opus 5.5 ff70f837d0
CI and images / lint (push) Successful in 2s
CI and images / extension-version (push) Successful in 2s
CI and images / frontend-build (push) Successful in 20s
CI and images / backend-lint-and-test (push) Successful in 30s
CI and images / integration (push) Successful in 2m18s
CI and images / sign-extension (push) Successful in 3s
CI and images / build-agent (push) Successful in 6s
CI and images / build-web (push) Successful in 1m44s
CI and images / smoke-web (push) Successful in 56s
CI and images / promote (push) Skipped
refactor: test row factories and the fetch stub have one copy each (3109)
tests/factories.py holds image_row/make_image/make_image_async/make_tag. The
17 byte-identical _img/_tag helpers (15 modules) now import them under their
old names, so no call site changed. frontend/test/support/stubFetch.js
replaces 15 copies that differed only in formatting. Copies whose bodies
differ (other defaults, other columns, a url-only stub) are left as they
are; folding those needs a look at each caller.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LVjrnpQjRgHdvq95rASoiR
2026-09-24 16:39:38 -04:00

141 lines
4.8 KiB
Python

"""Earned auto-apply (#114). The sweep is numpy-only (no scikit-learn), so the
apply logic is tested directly via the sync session; the API guards (disabled /
dry-run / conflict) via the async client."""
import pytest
from sqlalchemy import select
from backend.app.models import (
HeadAutoApplyRun,
ImageRecord,
MLSettings,
Tag,
TagHead,
TagKind,
)
from backend.app.models.tag import image_tag
from backend.app.services.ml.heads import auto_apply_sweep
from tests.factories import make_image as _img
pytestmark = pytest.mark.integration
def _emb(slot: int) -> list[float]:
v = [0.0] * 1152
v[slot] = 3.0
return v
def _head(db, tag_id: int, slot: int, *, threshold=0.5, n_pos=60):
s = db.execute(select(MLSettings).where(MLSettings.id == 1)).scalar_one()
w = [0.0] * 1152
w[slot] = 1.0
db.add(TagHead(
tag_id=tag_id, embedding_version=s.embedder_model_version,
weights=w, bias=0.0, suggest_threshold=0.5, auto_apply_threshold=threshold,
n_pos=n_pos, n_neg=90, ap=0.9, precision_cv=0.98, recall=0.7,
))
def _run(db, dry_run=False) -> HeadAutoApplyRun:
run = HeadAutoApplyRun(dry_run=dry_run, params={"dry_run": dry_run}, status="running")
db.add(run)
db.flush()
return run
def _applied_source(db, image_id, tag_id):
return db.execute(
select(image_tag.c.source)
.where(image_tag.c.image_record_id == image_id)
.where(image_tag.c.tag_id == tag_id)
).scalar_one_or_none()
def test_sweep_applies_to_matching_image(db_sync):
img = _img(db_sync, "a" * 64, _emb(0))
tag = Tag(name="autotag", kind=TagKind.general)
db_sync.add(tag)
db_sync.flush()
_head(db_sync, tag.id, 0)
run = _run(db_sync)
db_sync.commit()
result = auto_apply_sweep(db_sync, run, dry_run=False)
assert result["n_applied"] == 1
assert _applied_source(db_sync, img.id, tag.id) == "head_auto"
def test_sweep_dry_run_counts_but_writes_nothing(db_sync):
img = _img(db_sync, "b" * 64, _emb(0))
tag = Tag(name="previewtag", kind=TagKind.general)
db_sync.add(tag)
db_sync.flush()
_head(db_sync, tag.id, 0)
run = _run(db_sync, dry_run=True)
db_sync.commit()
result = auto_apply_sweep(db_sync, run, dry_run=True)
assert result["n_applied"] == 1 # it WOULD apply
assert _applied_source(db_sync, img.id, tag.id) is None # but wrote nothing
def test_sweep_skips_under_supported_head(db_sync):
# n_pos below head_auto_apply_min_positives (default 50) → a precise-looking
# but under-supported head never fires.
img = _img(db_sync, "c" * 64, _emb(0))
tag = Tag(name="weaktag", kind=TagKind.general)
db_sync.add(tag)
db_sync.flush()
_head(db_sync, tag.id, 0, n_pos=5)
run = _run(db_sync)
db_sync.commit()
result = auto_apply_sweep(db_sync, run, dry_run=False)
assert result["n_applied"] == 0
assert _applied_source(db_sync, img.id, tag.id) is None
def test_sweep_skips_ungraduated_head(db_sync):
# auto_apply_threshold is None (head never reached the precision bar).
_img(db_sync, "d" * 64, _emb(0))
tag = Tag(name="nograd", kind=TagKind.general)
db_sync.add(tag)
db_sync.flush()
_head(db_sync, tag.id, 0, threshold=None)
run = _run(db_sync)
db_sync.commit()
result = auto_apply_sweep(db_sync, run, dry_run=False)
assert result["n_applied"] == 0
@pytest.mark.asyncio
async def test_auto_apply_disabled_blocks_real_run(client, db):
# With the master switch OFF, a real sweep is refused (400). (It defaults ON
# now — opt-out — so the test disables it explicitly to exercise this path.)
s = (await db.execute(select(MLSettings).where(MLSettings.id == 1))).scalar_one()
s.head_auto_apply_enabled = False
await db.commit()
resp = await client.post("/api/heads/auto-apply", json={"dry_run": False})
assert resp.status_code == 400
assert (await resp.get_json())["error"] == "auto_apply_disabled"
@pytest.mark.asyncio
async def test_auto_apply_dry_run_allowed_when_disabled(client, db, monkeypatch):
monkeypatch.setattr(
"backend.app.tasks.ml.apply_head_tags.delay", lambda *a, **k: None
)
resp = await client.post("/api/heads/auto-apply", json={"dry_run": True})
assert resp.status_code == 202
assert (await resp.get_json())["status"] == "running"
@pytest.mark.asyncio
async def test_auto_apply_conflict_when_one_running(client, db, monkeypatch):
monkeypatch.setattr(
"backend.app.tasks.ml.apply_head_tags.delay", lambda *a, **k: None
)
db.add(HeadAutoApplyRun(dry_run=True, params={}, status="running"))
await db.flush()
await db.commit()
resp = await client.post("/api/heads/auto-apply", json={"dry_run": True})
assert resp.status_code == 409
assert (await resp.get_json())["error"] == "auto_apply_already_running"