bvandeusenandClaude Opus 5
a708f5e9db
CI / extension-version (push) Successful in 4s
CI / lint (push) Successful in 4s
Build images / sign-extension (push) Successful in 4s
Build images / build-agent (push) Successful in 9s
CI / frontend-build (push) Successful in 27s
CI / backend-lint-and-test (push) Successful in 34s
Build images / build-web (push) Successful in 1m17s
Build images / smoke-web (push) Skipped
CI / integration (push) Failing after 2m8s
Build images / build-ml (push) Successful in 2m18s
Build images / promote (push) Skipped
The step phase A was building toward. A1 made the gated count true, A2 made it a durable state, A3 made it visible in Subscriptions — but Subscriptions is where you go once you already suspect something. This is the line that reaches someone who wasn't looking. A thin grey strip above the feed, front door only: last check, sources failing, sources you can't see. Only the actionable items take a colour, and nothing renders at zero — a permanent "0 failing" trains you to skip the line, which would hide the real number when it appears. Two predicates, defined once. The ribbon counts and the surfaces it links to have to agree on what "failing" and "no access" MEAN, or the ribbon says 3 and the card shows 4. They live in db_helpers, which exists for exactly this reason (its docstring: divergent copies are how the race bugs crept in). Not in source_service, because scheduler_service needs them too and source_service already imports scheduler_service — the other direction is a cycle. Counting deliberately spans all ENABLED sources rather than the auto_check subset scheduler_status already walks: a source erroring on a manual-only artist is still erroring. Disabled sources count for nothing, which is what makes issue 1285 the real escape hatch for a sub you stopped paying for. Extends the existing schedule-status endpoint rather than adding a parallel aggregate — the store already fetches it. Two scalar COUNTs. The status filter is now URL-addressable, which it had to be for the ribbon's links to land anywhere: a count that drops you on an unfiltered list makes the reader redo the filtering the ribbon just did. Mirrors how artistFilter already reads from route.query. Front-door-only via a route prop, not a route.name check, so the view doesn't need to know what it's mounted as and the router states the intent in one place. Inside Browse's Posts tab you're looking FOR something and the hub is one click away. The fetch is swallowed on mount by design (rule 164): this is an aside, and the feed must render whether or not the status call succeeds. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LNXXULQDjVZmbuNa2G9mD9
81 lines
2.8 KiB
Vue
81 lines
2.8 KiB
Vue
<template>
|
|
<!-- Renders nothing at all until it has something true to say. A ribbon that
|
|
shows a skeleton or an error on the front door would make the app look
|
|
broken every cold load; the feed is the point, this is an aside. -->
|
|
<div v-if="status" class="fc-ribbon">
|
|
<span class="fc-ribbon__item">
|
|
<v-icon size="x-small">mdi-clock-outline</v-icon>
|
|
Checked {{ lastCheckedLabel }}
|
|
</span>
|
|
|
|
<RouterLink
|
|
v-if="failing" class="fc-ribbon__item fc-ribbon__item--err"
|
|
:to="{ path: '/subscriptions', query: { status: 'errors' } }"
|
|
>
|
|
<v-icon size="x-small">mdi-alert-circle-outline</v-icon>
|
|
{{ failing }} {{ failing === 1 ? 'source is' : 'sources are' }} failing
|
|
</RouterLink>
|
|
|
|
<!-- The reason this ribbon exists. Phase A made "we can't see this
|
|
creator's posts" a durable fact; without a line here it stays buried
|
|
three clicks into Subscriptions, which is exactly where nobody looks
|
|
until they already suspect something. -->
|
|
<RouterLink
|
|
v-if="noAccess" class="fc-ribbon__item fc-ribbon__item--gated"
|
|
:to="{ path: '/subscriptions', query: { status: 'no_access' } }"
|
|
>
|
|
<v-icon size="x-small">mdi-lock-outline</v-icon>
|
|
{{ noAccess }} you can't see
|
|
</RouterLink>
|
|
</div>
|
|
</template>
|
|
|
|
<script setup>
|
|
import { computed, onMounted } from 'vue'
|
|
import { storeToRefs } from 'pinia'
|
|
|
|
import { useSourcesStore } from '../../stores/sources.js'
|
|
import { formatRelative } from '../../utils/date.js'
|
|
|
|
const store = useSourcesStore()
|
|
const { scheduleStatus: status } = storeToRefs(store)
|
|
|
|
const failing = computed(() => status.value?.failing_sources || 0)
|
|
const noAccess = computed(() => status.value?.no_access_sources || 0)
|
|
const lastCheckedLabel = computed(() =>
|
|
formatRelative(status.value?.last_tick_at, { nullText: 'never' }),
|
|
)
|
|
|
|
onMounted(() => {
|
|
// Swallowed on purpose: this is an aside on the front door, and the feed
|
|
// must render whether or not the status call succeeds (rule #164 — a
|
|
// genuinely-external-ish fact degrades to absent, it never gates the page).
|
|
store.loadScheduleStatus().catch(() => {})
|
|
})
|
|
</script>
|
|
|
|
<style scoped>
|
|
.fc-ribbon {
|
|
display: flex;
|
|
align-items: center;
|
|
flex-wrap: wrap;
|
|
gap: 4px 14px;
|
|
padding: 2px 0 10px;
|
|
font-size: 0.78rem;
|
|
color: rgb(var(--v-theme-on-surface-variant));
|
|
}
|
|
.fc-ribbon__item {
|
|
display: inline-flex;
|
|
align-items: center;
|
|
gap: 4px;
|
|
color: inherit;
|
|
text-decoration: none;
|
|
}
|
|
/* Only the actionable items take a colour, so a healthy instance reads as one
|
|
quiet grey line rather than a status dashboard. */
|
|
.fc-ribbon__item--err { color: rgb(var(--v-theme-error)); }
|
|
.fc-ribbon__item--gated { color: rgb(var(--v-theme-info)); }
|
|
.fc-ribbon__item--err:hover,
|
|
.fc-ribbon__item--gated:hover { text-decoration: underline; }
|
|
</style>
|