c64261593d
Deploys (docker SIGTERM→SIGKILL, default 10s) were killing Celery jobs mid-flight. Give in-flight work room to drain and make interrupted work resume cleanly instead of stalling. - docker-compose.yml: stop_grace_period per lane (web 30s / worker 90s / scheduler 60s / maintenance-long 180s / ml-worker 120s) so warm shutdown can actually drain before SIGKILL. - celery_app.py: task_reject_on_worker_lost=True — a task killed past the grace window is re-queued (safe: idempotent + chunked, recovery sweeps re-drive stragglers). - interpreter_client.py: map 429/5xx (502/503/504) → InterpreterUnavailable and parse Retry-After (delta-seconds or HTTP-date); a draining Interpreter behind a reverse proxy no longer raises an opaque HTTPError. - translation.py: thread retry_after out of _translate_batch; retranslate_posts resumes after the Retry-After hint (or 60s default, capped 900s) on an interrupt with _reset_done=True, self-terminating via the health gate. - tests: 429/5xx mapping + Retry-After parse; interrupt-resume + default backoff. No migration. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
142 lines
5.0 KiB
Python
142 lines
5.0 KiB
Python
"""Interpreter translation client (#143) — unit tests with mocked HTTP (no DB,
|
|
no real network)."""
|
|
import pytest
|
|
|
|
from backend.app.services import interpreter_client as ic
|
|
|
|
|
|
class _Resp:
|
|
def __init__(self, status_code=200, payload=None, headers=None):
|
|
self.status_code = status_code
|
|
self._payload = payload or {}
|
|
self.headers = headers or {}
|
|
|
|
def json(self):
|
|
return self._payload
|
|
|
|
def raise_for_status(self):
|
|
if self.status_code >= 400:
|
|
raise ic.requests.HTTPError(f"status {self.status_code}")
|
|
|
|
|
|
def test_translate_maps_batch_in_order(monkeypatch):
|
|
captured = {}
|
|
|
|
def fake_post(url, json, timeout):
|
|
captured["json"] = json
|
|
return _Resp(200, {
|
|
"translatedText": ["The cat is cute", "Blonde gal!"],
|
|
"detectedLanguage": {"language": "ja", "confidence": 0.98},
|
|
"interpreter": {"engine": "llm", "engine_version": "ollama:x:12b"},
|
|
})
|
|
|
|
monkeypatch.setattr(ic.requests, "post", fake_post)
|
|
out = ic.translate(["ねこが可愛い", "金髪ギャル!"], base_url="http://i.lan")
|
|
assert out["translations"] == ["The cat is cute", "Blonde gal!"]
|
|
assert out["detected_lang"] == "ja"
|
|
assert out["engine_version"] == "ollama:x:12b"
|
|
assert captured["json"]["q"] == ["ねこが可愛い", "金髪ギャル!"]
|
|
assert captured["json"]["target"] == "en"
|
|
|
|
|
|
def test_translate_passthrough_unchanged(monkeypatch):
|
|
# Already-English items come back unchanged in their slot (engine "none").
|
|
monkeypatch.setattr(ic.requests, "post", lambda *a, **k: _Resp(200, {
|
|
"translatedText": ["already english"],
|
|
"detectedLanguage": {"language": "en"},
|
|
"interpreter": {"engine": "none", "engine_version": None},
|
|
}))
|
|
out = ic.translate(["already english"], base_url="http://i.lan")
|
|
assert out["translations"] == ["already english"]
|
|
assert out["detected_lang"] == "en"
|
|
assert out["engine"] == "none"
|
|
|
|
|
|
def test_translate_503_raises_unavailable(monkeypatch):
|
|
monkeypatch.setattr(ic.requests, "post", lambda *a, **k: _Resp(503, {}))
|
|
with pytest.raises(ic.InterpreterUnavailable):
|
|
ic.translate(["x"], base_url="http://i.lan")
|
|
|
|
|
|
def test_translate_connection_error_raises_unavailable(monkeypatch):
|
|
def boom(*a, **k):
|
|
raise ic.requests.ConnectionError("refused")
|
|
|
|
monkeypatch.setattr(ic.requests, "post", boom)
|
|
with pytest.raises(ic.InterpreterUnavailable):
|
|
ic.translate(["x"], base_url="http://i.lan")
|
|
|
|
|
|
@pytest.mark.parametrize("code", [429, 500, 502, 503, 504])
|
|
def test_translate_429_and_5xx_raise_unavailable(monkeypatch, code):
|
|
# A gracefully-draining service behind a reverse proxy returns 429/502/503/504
|
|
# — all mean "retry later", not an opaque error.
|
|
monkeypatch.setattr(ic.requests, "post", lambda *a, **k: _Resp(code, {}))
|
|
with pytest.raises(ic.InterpreterUnavailable) as ei:
|
|
ic.translate(["x"], base_url="http://i.lan")
|
|
assert ei.value.retry_after is None
|
|
|
|
|
|
def test_translate_honours_retry_after_seconds(monkeypatch):
|
|
monkeypatch.setattr(
|
|
ic.requests, "post",
|
|
lambda *a, **k: _Resp(503, {}, headers={"Retry-After": "42"}),
|
|
)
|
|
with pytest.raises(ic.InterpreterUnavailable) as ei:
|
|
ic.translate(["x"], base_url="http://i.lan")
|
|
assert ei.value.retry_after == 42
|
|
|
|
|
|
def test_translate_retry_after_past_http_date_clamps_to_zero(monkeypatch):
|
|
# HTTP-date form; a past date → non-negative clamp to 0 (deterministic).
|
|
monkeypatch.setattr(
|
|
ic.requests, "post",
|
|
lambda *a, **k: _Resp(
|
|
503, {}, headers={"Retry-After": "Wed, 21 Oct 2015 07:28:00 GMT"}),
|
|
)
|
|
with pytest.raises(ic.InterpreterUnavailable) as ei:
|
|
ic.translate(["x"], base_url="http://i.lan")
|
|
assert ei.value.retry_after == 0.0
|
|
|
|
|
|
def test_translate_400_raises_bad_request(monkeypatch):
|
|
monkeypatch.setattr(
|
|
ic.requests, "post", lambda *a, **k: _Resp(400, {"error": "bad target"})
|
|
)
|
|
with pytest.raises(ic.InterpreterBadRequest):
|
|
ic.translate(["x"], base_url="http://i.lan")
|
|
|
|
|
|
def test_translate_empty_is_noop(monkeypatch):
|
|
def boom(*a, **k):
|
|
raise AssertionError("should not call the service for an empty batch")
|
|
|
|
monkeypatch.setattr(ic.requests, "post", boom)
|
|
assert ic.translate([], base_url="http://i.lan")["translations"] == []
|
|
|
|
|
|
def test_health_true_when_llm_up(monkeypatch):
|
|
monkeypatch.setattr(
|
|
ic.requests, "get", lambda *a, **k: _Resp(200, {"engines": {"llm": True}})
|
|
)
|
|
assert ic.health("http://i.lan") is True
|
|
|
|
|
|
def test_health_false_when_engine_down(monkeypatch):
|
|
monkeypatch.setattr(
|
|
ic.requests, "get", lambda *a, **k: _Resp(200, {"engines": {"llm": False}})
|
|
)
|
|
assert ic.health("http://i.lan") is False
|
|
|
|
|
|
def test_health_false_on_error(monkeypatch):
|
|
def boom(*a, **k):
|
|
raise ic.requests.ConnectionError("refused")
|
|
|
|
monkeypatch.setattr(ic.requests, "get", boom)
|
|
assert ic.health("http://i.lan") is False
|
|
|
|
|
|
def test_health_false_when_url_empty():
|
|
assert ic.health("") is False
|