bvandeusenandClaude Opus 5
e3fd8c67d4
Milestone 406 retires pixiv (rule 171) in two phases at the operator's explicit ask: switch it off, then later delete its code. This is the switch-off. Steps 2 and 3 ship together because each is a half-state of the other: unregistered but still in the extension, pixiv creator pages would offer a button the backend then refuses. Reachability removed, never gated (rule 22 - no flag, no `if platform == "pixiv"`): - platforms registry: pixiv unregistered, so /api/platforms, the source validator and quick-add all refuse it through their existing unknown-platform paths. - NATIVE_INGESTER_PLATFORMS: pixiv removed. - extension_service: pixiv's quick-add URL pattern removed (the Python half of the JS mirror). - extension: pixiv's host permissions, content-script match, platform entry and artist pattern removed; popup's pixiv branches removed; and the whole pixiv PKCE OAuth flow cut out of background.js. That last one could not wait for phase 2 - a webRequest listener on a host the manifest no longer grants is at best dead and at worst a startup failure for the entire background script. On startup the extension now also removes any pixiv refresh token a browser still holds in storage, for the same reason as the server-side credential cleanup (3980). - frontend: the extension card stops listing pixiv; SourceActions' copy of the native list drops it. platformColor keeps rendering a pixiv key so existing pixiv posts do not look broken. The guard, and why a registry change alone was not enough. A source outlives its platform: the live instance still had one ENABLED pixiv source (step 1). Tracing it: the scheduler only selects enabled rows and every platform lookup uses .get(), so a disabled row is inert - but re-enabling it and pressing Check would have routed pixiv, no longer native, straight into the gallery-dl branch, which still has a pixiv extractor. And a worker can pick up a still-enabled row before a deploy's migration runs. So run_download and verify_source_credential - the two functions every download and credential probe pass through - now refuse any platform not in the registry: an unsupported_url failure for downloads, and an inconclusive (None, not False) verify, since nothing was probed so nothing was rejected. Generic by registration, so it covers deviantart's leftovers too. Positive-controlled: a supported gallery-dl platform must still reach gallery-dl, or a guard that refused everything would pass (rule 167). Migration 0097 disables sources on retired platforms (pixiv, deviantart) and clears their failure state exactly as disabling through the app does (1285), so the stale row stops being scheduled and stops showing as failing. Nothing is deleted: removing a source can collide with uq_post_artist_external_id_null_source on real data, which is phase 2's step 6 to check. No post or image is touched. Tests: the known-platform lists drop pixiv and gain retirement assertions beside deviantart's; pixiv's positive extension cases become negative guards; the pixiv sidecar post-URL test is deleted with the behaviour it tested; quick-add rejects a pixiv URL. The pixiv client/downloader/ingester suites stay - that code stays until phase 2. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SHQB1YukL3VyvMK8rcbmV9
91 lines
3.3 KiB
Vue
91 lines
3.3 KiB
Vue
<template>
|
|
<!-- Shared per-source action cluster (desktop SourceRow + mobile SourceCard).
|
|
Frequent actions stay as buttons; low-frequency / destructive ones move
|
|
into a labelled overflow menu so they can't be mis-clicked, and the
|
|
labels spell out what each one does (recover vs backfill). -->
|
|
<div class="fc-src-actions">
|
|
<v-btn
|
|
icon size="small" variant="text" :loading="checking"
|
|
@click.stop="emit('check', source)"
|
|
>
|
|
<v-icon>mdi-play</v-icon>
|
|
<v-tooltip activator="parent" location="top">
|
|
Check now — fetch posts published since the last check
|
|
</v-tooltip>
|
|
</v-btn>
|
|
<v-btn
|
|
icon size="small" variant="text"
|
|
:color="running ? 'warning' : undefined"
|
|
@click.stop="emit('backfill', source)"
|
|
>
|
|
<v-icon>{{ running ? 'mdi-stop' : 'mdi-magnify-scan' }}</v-icon>
|
|
<v-tooltip activator="parent" location="top">
|
|
{{ running
|
|
? (recovering ? 'Stop recovery' : (recapturing ? 'Stop recapture' : 'Stop backfill'))
|
|
: 'Backfill — one-time walk of the FULL post history until complete' }}
|
|
</v-tooltip>
|
|
</v-btn>
|
|
|
|
<KebabMenu size="small" :min-width="260" label="More actions">
|
|
<v-list-item
|
|
v-if="isNative && !running"
|
|
prepend-icon="mdi-backup-restore"
|
|
@click="emit('recover', source)"
|
|
>
|
|
<v-list-item-title>Recover dropped near-duplicates</v-list-item-title>
|
|
<v-list-item-subtitle>
|
|
Re-fetch images previously dropped as near-dups and re-judge them
|
|
under the current similarity threshold
|
|
</v-list-item-subtitle>
|
|
</v-list-item>
|
|
<v-list-item
|
|
v-if="isNative && !running"
|
|
prepend-icon="mdi-text-box-search-outline"
|
|
@click="emit('recapture', source)"
|
|
>
|
|
<v-list-item-title>Recapture post text & links</v-list-item-title>
|
|
<v-list-item-subtitle>
|
|
Re-grab every post's body + external links and localize inline images
|
|
already on disk — without re-downloading media
|
|
</v-list-item-subtitle>
|
|
</v-list-item>
|
|
<v-divider v-if="isNative && !running" />
|
|
<v-list-item
|
|
base-color="error"
|
|
prepend-icon="mdi-delete-outline"
|
|
@click="emit('remove', source)"
|
|
>
|
|
<v-list-item-title>Remove source</v-list-item-title>
|
|
</v-list-item>
|
|
</KebabMenu>
|
|
</div>
|
|
</template>
|
|
|
|
<script setup>
|
|
import { computed } from 'vue'
|
|
import KebabMenu from '../common/KebabMenu.vue'
|
|
|
|
const props = defineProps({
|
|
source: { type: Object, required: true },
|
|
checking: { type: Boolean, default: false },
|
|
})
|
|
const emit = defineEmits(['check', 'backfill', 'recover', 'recapture', 'remove'])
|
|
|
|
const running = computed(() => props.source.backfill_state === 'running')
|
|
const recovering = computed(() => !!props.source.backfill_bypass_seen)
|
|
const recapturing = computed(() => !!props.source.backfill_recapture)
|
|
// Recover / recapture are native-ingester features (ledger-bypass re-walk and
|
|
// post-text re-grab), available to every native platform — not just Patreon.
|
|
// Mirrors backend download_backends.NATIVE_INGESTER_PLATFORMS.
|
|
const NATIVE_PLATFORMS = ['patreon', 'subscribestar']
|
|
const isNative = computed(() => NATIVE_PLATFORMS.includes(props.source.platform))
|
|
</script>
|
|
|
|
<style scoped>
|
|
.fc-src-actions {
|
|
display: inline-flex;
|
|
align-items: center;
|
|
gap: 2px;
|
|
}
|
|
</style>
|