bvandeusen
218bfebb92
The credential Verify button still ran gallery-dl --simulate for Patreon after the cutover — testing the wrong path (and prone to the vanity "Failed to extract campaign ID" the native resolver fixes). Wire it to the native ingester, behind a DRY dispatch so callers never branch on platform. - services/download_backends.py (new): the ONE place that knows which platforms are native vs gallery-dl. `uses_native_ingester(platform)` is the shared predicate; `verify_source_credential(...)` is the uniform probe (same (ok|None, message) contract for both backends). As a platform migrates, it moves into NATIVE_INGESTER_PLATFORMS here and BOTH download routing and verify switch together. - PatreonClient.verify_auth(campaign_id): one authenticated /api/posts fetch → True (valid) / False (401/403/HTML-login) / None (drift or network — inconclusive, not a credential verdict). - patreon_ingester.verify_patreon_credential(): resolve campaign id, then verify_auth — the verify counterpart to the download path. - patreon_resolver.resolve_campaign_id_for_source(): extracted the override / id:-URL / vanity resolution into ONE helper now shared by the download ingester and verify (download_service no longer carries its own copy + regex; −`import re`). - download_service: routes on uses_native_ingester() instead of inline `== "patreon"` (3 sites); uses the shared resolver. - api/credentials: calls verify_source_credential — no platform branch. Tests: verify_auth mapping, resolve_campaign_id_for_source (override/id:/ vanity/none), the dispatch predicate, verify_patreon_credential glue, credentials endpoint proves Patreon uses the native path (gallery-dl verify asserted not-called); repointed the gallery-dl verify test to subscribestar. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
24 lines
806 B
Python
24 lines
806 B
Python
"""download_backends — the single predicate that routes a platform to the
|
|
native ingester vs. gallery-dl. Pure, no DB."""
|
|
|
|
from backend.app.services.download_backends import (
|
|
NATIVE_INGESTER_PLATFORMS,
|
|
uses_native_ingester,
|
|
)
|
|
|
|
|
|
def test_patreon_is_native():
|
|
assert uses_native_ingester("patreon") is True
|
|
assert "patreon" in NATIVE_INGESTER_PLATFORMS
|
|
|
|
|
|
def test_gallery_dl_platforms_are_not_native():
|
|
# The five platforms still served by gallery-dl must NOT route to the
|
|
# native ingester — guards an accidental over-broad migration.
|
|
for platform in ("subscribestar", "hentaifoundry", "discord", "pixiv", "deviantart"):
|
|
assert uses_native_ingester(platform) is False
|
|
|
|
|
|
def test_unknown_platform_is_not_native():
|
|
assert uses_native_ingester("nonsense") is False
|