bvandeusenandClaude Opus 5
9ccc460c69
CI / lint (push) Successful in 2s
CI / extension-version (push) Successful in 2s
Build images / sign-extension (push) Successful in 4s
Build images / build-agent (push) Successful in 11s
CI / frontend-build (push) Successful in 29s
CI / backend-lint-and-test (push) Successful in 1m1s
Build images / build-web (push) Successful in 1m11s
Build images / smoke-web (push) Skipped
Build images / build-ml (push) Successful in 1m56s
Build images / promote (push) Skipped
CI / integration (push) Successful in 2m43s
Milestone #421 step 3, reframed on the operator's steer: not a one-off migration but the system that keeps the tree true. The 33,789 misplaced rows the survey found are just its first run. The placement half was already done, verified by reading each writer rather than assuming: downloads have always written `<root>/<slug>/<platform>/` (gallery_dl.py:523), attach_in_place leaves files where the downloader put them, and `_copy_to_library` / `_supersede` became canonical in #4244. So nothing is written off-canon today; what remains is the backlog and a standing check for future drift. `LibraryPlacementRun` (migration 0099) holds the plan as JSONB, and that one structure does three jobs: it is the PREVIEW the operator reads, the list the APPLY executes (rather than re-deriving the set, so the two cannot disagree), and — because `from` is retained — the UNDO. The undo is the point. It makes a 33,789-file operation something to do one artist at a time, look at in the gallery, and reverse if it reads wrong. That settles whether artist_id or the folder held the truth (spike #4257) by doing rather than by arguing it from a 50-row sample. An applied run is therefore HISTORY, not state — lesson #4226's trap, since it is the only record of where those files used to be. The model and the migration both say so: any future retention here may prune ready/cancelled/ error runs, never an applied one. Everything fails closed. The apply re-checks each row against what the plan recorded — source still there, destination still free, row still pointing where the plan said — because a download or a supersede can land in between. A refusal is recorded with its reason and the run continues; one stale row is not a reason to abandon the other 33,788. The row is updated only after its rename lands, so a failed move can never leave `path` naming a file that is not there. Writing the collision test caught the code disagreeing with its own comment: it claimed the first of two rows wanting one destination and skipped the second, silently picking a winner by iteration order. Now it counts first and filters after, so genuinely neither is planned. Thumbnails are sha-addressed, not path-keyed, so they do not move — pinned by a test. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LVjrnpQjRgHdvq95rASoiR
100 lines
3.6 KiB
Python
100 lines
3.6 KiB
Python
"""library_placement_run — the placement reconciler's plan/apply/undo ledger.
|
|
|
|
Milestone #421 step 3. The survey (#4245) measured 33,789 ImageRecord rows
|
|
sitting outside their artist's canonical directory, across 56 artists. This
|
|
table holds one run of the sweep that trues them up: the plan, what it did,
|
|
and where every file came from.
|
|
|
|
## Why the moves live in a table rather than a log line
|
|
|
|
`ImageRecord.path` is the only pointer at the bytes, so a move rewrites the
|
|
row. Once that write lands, the previous location exists nowhere — unless it
|
|
was recorded first. `moves` is that record, which is what makes a 33,789-file
|
|
operation something the operator can undo per artist after looking at the
|
|
result, rather than a one-way door.
|
|
|
|
An `applied` row is therefore HISTORY, not state (lesson #4226). Any future
|
|
retention on this table may prune `ready`, `cancelled` and `error` runs; an
|
|
`applied` one is only disposable once someone decides undo is no longer
|
|
wanted. That is deliberately not a timer's decision, and no pruning is added
|
|
here.
|
|
|
|
Revision ID: 0099
|
|
Revises: 0098
|
|
Create Date: 2026-09-21
|
|
|
|
"""
|
|
from typing import Sequence, Union
|
|
|
|
import sqlalchemy as sa
|
|
from alembic import op
|
|
from sqlalchemy.dialects import postgresql
|
|
|
|
revision: str = "0099"
|
|
down_revision: Union[str, None] = "0098"
|
|
branch_labels: Union[str, Sequence[str], None] = None
|
|
depends_on: Union[str, Sequence[str], None] = None
|
|
|
|
|
|
def upgrade() -> None:
|
|
op.create_table(
|
|
"library_placement_run",
|
|
sa.Column("id", sa.Integer(), nullable=False),
|
|
sa.Column(
|
|
"status", sa.String(length=16), server_default="running",
|
|
nullable=False,
|
|
),
|
|
# SET NULL, not CASCADE: deleting an artist must not destroy the
|
|
# record of where their files were moved.
|
|
sa.Column("artist_id", sa.Integer(), nullable=True),
|
|
sa.Column(
|
|
"started_at", sa.DateTime(timezone=True),
|
|
server_default=sa.text("now()"), nullable=False,
|
|
),
|
|
sa.Column("finished_at", sa.DateTime(timezone=True), nullable=True),
|
|
sa.Column(
|
|
"planned_count", sa.Integer(), server_default="0", nullable=False,
|
|
),
|
|
sa.Column(
|
|
"moved_count", sa.Integer(), server_default="0", nullable=False,
|
|
),
|
|
sa.Column(
|
|
"refused_count", sa.Integer(), server_default="0", nullable=False,
|
|
),
|
|
sa.Column(
|
|
"moves", postgresql.JSONB(astext_type=sa.Text()),
|
|
server_default=sa.text("'[]'::jsonb"), nullable=False,
|
|
),
|
|
sa.Column(
|
|
"refusals", postgresql.JSONB(astext_type=sa.Text()),
|
|
server_default=sa.text("'[]'::jsonb"), nullable=False,
|
|
),
|
|
sa.Column("error", sa.Text(), nullable=True),
|
|
sa.ForeignKeyConstraint(
|
|
["artist_id"], ["artist.id"],
|
|
name="fk_library_placement_run_artist_id", ondelete="SET NULL",
|
|
),
|
|
sa.PrimaryKeyConstraint("id"),
|
|
)
|
|
op.create_index(
|
|
"ix_library_placement_run_status", "library_placement_run", ["status"],
|
|
)
|
|
op.create_index(
|
|
"ix_library_placement_run_artist_id", "library_placement_run",
|
|
["artist_id"],
|
|
)
|
|
|
|
|
|
def downgrade() -> None:
|
|
# Dropping this table destroys the only record of where moved files came
|
|
# from. That is correct for a downgrade — the code that reads it is going
|
|
# away too — but it is worth saying out loud rather than discovering.
|
|
op.drop_index(
|
|
"ix_library_placement_run_artist_id",
|
|
table_name="library_placement_run",
|
|
)
|
|
op.drop_index(
|
|
"ix_library_placement_run_status", table_name="library_placement_run",
|
|
)
|
|
op.drop_table("library_placement_run")
|