bvandeusen
5e1996e77f
Build images / sign-extension (push) Successful in 4s
CI / lint (push) Failing after 2s
CI / extension-version (push) Successful in 2s
Build images / build-agent (push) Successful in 7s
CI / frontend-build (push) Successful in 27s
Build images / build-ml (push) Successful in 48s
CI / backend-lint-and-test (push) Successful in 1m7s
Build images / build-web (push) Successful in 40s
CI / integration (push) Successful in 4m1s
Milestone 328's acceptance test compared a database built by the real
0001..0087 chain against one built from the models, and found ~130
places where they disagree. This closes them.
Almost all were the MODEL being wrong, so almost all of this is model
edits with no DDL — the database already had these things, nothing in it
changes, and no deploy is needed for this part:
* 92 columns gained server_default. The models carried Python-side
`default=` only, so the ORM filled the value and the column had no
database default. Anything inserting outside the ORM behaved
differently from production.
* Eleven indexes that existed only in migrations are now declared:
the three backup_run reporting indexes, the two date-ordered
image_record browse indexes, import_task and presentation_review,
and the three task_run history indexes. All use text() for their DESC
ordering and postgresql_where for the partial one.
* Two UNIQUE indexes that autogenerate silently proposed DROPPING,
because neither is expressible as a UniqueConstraint:
uq_tag_name_kind_fandom — an EXPRESSION index over
(name, kind, COALESCE(fandom_id, 0))
uq_post_artist_external_id_null_source — PARTIAL, WHERE source_id
IS NULL
post.py already had a comment describing the second one. The comment
was right; nothing declared it.
* The two external_link enum CHECKs (host, status) — rule 36 territory,
and absent from the model entirely.
* Two indexes were named explicitly. A bare index=True generated
ix_tag_alias_canonical_tag_id where the database has
ix_tag_alias_canonical, so autogenerate proposed a drop+create of an
index that was already there under another name. Same for
tag_suggestion_rejection.
Only ONE thing needed DDL, as 0088: tag.fandom_id is declared
index=True but no migration ever created that index.
Deliberately NOT here: image_record.sha256. The model says unique=True;
0001 created a plain index. Duplicates are possible today and the ORM
believes otherwise. The fix depends on whether duplicates already exist
— if they do, that is a dedupe decision, not a constraint — so it waits
on an answer about live data.
The real severity of #3275 is not the squash. It is that --autogenerate
has been unsafe on this project: run against the old models it would
have proposed dropping eleven indexes and two uniqueness guarantees.
101 lines
4.3 KiB
Python
101 lines
4.3 KiB
Python
"""Post — provenance anchor for one creator post (may contain many images).
|
|
|
|
`source_id` is nullable since alembic 0030 — filesystem-imported posts
|
|
with no live subscription have NULL source_id. `artist_id` is the
|
|
denormalized always-present link to the creator (added in 0030 so
|
|
artist-filter queries don't depend on the Source detour).
|
|
"""
|
|
|
|
from datetime import datetime
|
|
|
|
from sqlalchemy import (
|
|
CheckConstraint,
|
|
DateTime,
|
|
ForeignKey,
|
|
Index,
|
|
Integer,
|
|
JSON,
|
|
String,
|
|
Text,
|
|
UniqueConstraint,
|
|
func,
|
|
text,
|
|
)
|
|
from sqlalchemy.orm import Mapped, mapped_column
|
|
|
|
from .base import Base
|
|
|
|
|
|
class Post(Base):
|
|
__tablename__ = "post"
|
|
__table_args__ = (
|
|
# alembic 0030. The comment above described this index; nothing declared
|
|
# it, so autogenerate proposed dropping it (#3275).
|
|
Index("uq_post_artist_external_id_null_source", "artist_id", "external_post_id",
|
|
unique=True, postgresql_where=text("source_id IS NULL")),
|
|
# Source-bound dedup. Postgres treats NULL != NULL so rows
|
|
# with source_id IS NULL aren't deduped by this constraint;
|
|
# the partial unique index `uq_post_artist_external_id_null_source`
|
|
# (created in alembic 0030) covers that case via
|
|
# (artist_id, external_post_id).
|
|
UniqueConstraint("source_id", "external_post_id", name="uq_post_source_external_id"),
|
|
CheckConstraint(
|
|
"translation_override IN ('auto', 'force', 'original')",
|
|
name="ck_post_translation_override",
|
|
),
|
|
)
|
|
|
|
id: Mapped[int] = mapped_column(Integer, primary_key=True)
|
|
source_id: Mapped[int | None] = mapped_column(
|
|
ForeignKey("source.id", ondelete="SET NULL"), nullable=True, index=True
|
|
)
|
|
# Denormalized; always equals source.artist_id when source_id is set
|
|
# (the importer is responsible for keeping them consistent on insert).
|
|
# Filter queries (artist detail, artist-scoped posts feed) use this
|
|
# directly instead of joining through Source.
|
|
artist_id: Mapped[int] = mapped_column(
|
|
ForeignKey("artist.id", ondelete="CASCADE"),
|
|
nullable=False, index=True,
|
|
)
|
|
external_post_id: Mapped[str] = mapped_column(String(128), nullable=False)
|
|
post_url: Mapped[str | None] = mapped_column(Text, nullable=True)
|
|
post_title: Mapped[str | None] = mapped_column(Text, nullable=True)
|
|
post_date: Mapped[datetime | None] = mapped_column(DateTime(timezone=True), nullable=True)
|
|
|
|
raw_metadata: Mapped[dict | None] = mapped_column(JSON, nullable=True)
|
|
|
|
description: Mapped[str | None] = mapped_column(Text, nullable=True)
|
|
attachment_count: Mapped[int | None] = mapped_column(Integer, nullable=True)
|
|
|
|
# -- Post-text translation (milestone 143). Filled by the translate_posts
|
|
# sweep via the Interpreter LAN service so viewing is instant.
|
|
# translated_source_lang is the DETECTED original language; "en" (or a
|
|
# passthrough) means nothing to translate and the *_translated columns stay
|
|
# NULL. engine_version keys the Interpreter cache — re-runs are ~1ms and a
|
|
# model upgrade re-translates instead of serving stale.
|
|
post_title_translated: Mapped[str | None] = mapped_column(Text, nullable=True)
|
|
description_translated: Mapped[str | None] = mapped_column(Text, nullable=True)
|
|
translated_source_lang: Mapped[str | None] = mapped_column(
|
|
String(8), nullable=True
|
|
)
|
|
translation_engine_version: Mapped[str | None] = mapped_column(
|
|
String(128), nullable=True
|
|
)
|
|
translated_at: Mapped[datetime | None] = mapped_column(
|
|
DateTime(timezone=True), nullable=True
|
|
)
|
|
# Sticky per-post override of the translation decision (milestone 155):
|
|
# 'auto' = the acceptance gate decides; 'force' = always store Interpreter's
|
|
# translation even below the confidence floor (rescue a skipped legit-foreign
|
|
# title); 'original' = never translate, keep the original (kill a confidently
|
|
# mis-flagged one the floor can't catch). The sweep reads this on every run,
|
|
# and re-translate leaves 'original' posts alone, so the choice survives a
|
|
# Re-translate-all.
|
|
translation_override: Mapped[str] = mapped_column(
|
|
String(16), nullable=False, default="auto", server_default="auto",
|
|
)
|
|
|
|
downloaded_at: Mapped[datetime] = mapped_column(
|
|
DateTime(timezone=True), nullable=False, server_default=func.now()
|
|
)
|