bvandeusenandClaude Opus 5
2ce467e347
`project_artist_cascade` is documented as "a read-only projection of what delete_artist_cascade would touch" and drives the Tier-C confirm dialog, but it counted only images, sources, thumbs, import_tasks and bytes. It never counted posts or attachments, both of which the apply destroys. That is silent in the worst case. `Post.artist_id` is ondelete=CASCADE, so every post goes whether or not it carried an image — and FC has a large body-only post population (#1288 measured 694 pixiv posts with text and no images). Such an artist previewed as `images: 0`, reading as "empty, safe to remove", while the apply destroyed every captured body, description, external-link set and raw_metadata snapshot. The danger-zone card already promised "every image, source, post, and attachment" — the copy was honest and the numbers were not. Root of the drift: the preview re-derived its own predicates instead of sharing the apply's, the same shape as the 2026-06-08 fandom-tag deletion that rule 93 exists for. So rather than bolt on two counts, both halves now build from shared `_artist_{images,posts,attachments}_conditions` helpers, following the `_unused_tag_conditions` / `_bare_post_conditions` style already in the file. Sources keep no helper — the apply doesn't query them either, it gets them from the Artist.sources ORM cascade. The apply also now reports `posts_deleted` (counted before the delete, since the CASCADE leaves nothing to count after). Rule 93's second half asks for the apply to be tested, and parity is only assertable if both halves state the number. Adds a preview/apply parity test that runs both against one artist and asserts the three pairs agree AND that the rows actually went, plus a body-only-artist test covering the case that motivated this. The confirm dialog's counts grid renders every key, so posts and attachments surface there automatically; the prose summary line names posts explicitly, since that is the number that changes how an artist reads. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
98 lines
2.8 KiB
Vue
98 lines
2.8 KiB
Vue
<template>
|
|
<v-card class="fc-danger-zone mt-8" variant="outlined">
|
|
<CardHeading icon="mdi-alert-octagon" icon-color="error" title="Danger zone" />
|
|
<v-card-text>
|
|
<p class="text-body-2 fc-muted mb-4">
|
|
Cascade-delete this artist and every image, source, post, and
|
|
attachment associated with them. This cannot be undone.
|
|
Recoverable only from an FC-3h backup.
|
|
</p>
|
|
<v-btn
|
|
color="error" variant="flat" rounded="pill"
|
|
prepend-icon="mdi-delete-forever"
|
|
:loading="loading"
|
|
@click="onClick"
|
|
>Delete artist & cascade</v-btn>
|
|
|
|
<DestructiveConfirmModal
|
|
v-model="modalOpen"
|
|
action="delete"
|
|
kind="artist"
|
|
:run-id="artistId"
|
|
tier="C"
|
|
:projected-counts="projectedCounts"
|
|
:description="modalDescription"
|
|
@confirm="onConfirm"
|
|
/>
|
|
</v-card-text>
|
|
</v-card>
|
|
</template>
|
|
|
|
<script setup>
|
|
import { computed, ref } from 'vue'
|
|
import { useRouter } from 'vue-router'
|
|
|
|
import DestructiveConfirmModal from '../modal/DestructiveConfirmModal.vue'
|
|
import { useAdminStore } from '../../stores/admin.js'
|
|
import CardHeading from '../common/CardHeading.vue'
|
|
|
|
const props = defineProps({
|
|
slug: { type: String, required: true },
|
|
artistId: { type: Number, required: true },
|
|
artistName: { type: String, required: true },
|
|
})
|
|
|
|
const router = useRouter()
|
|
const store = useAdminStore()
|
|
const loading = ref(false)
|
|
const modalOpen = ref(false)
|
|
const projected = ref(null)
|
|
|
|
const projectedCounts = computed(() => projected.value?.projected || null)
|
|
|
|
// `posts` is named here, not left to the counts grid below it: an artist whose
|
|
// posts are body-only previews as `images: 0`, and a summary line that says
|
|
// only "0 images" reads as "this artist is empty" while the apply destroys
|
|
// every captured post body (#3067). Attachments stay in the grid — the grid
|
|
// renders every key, so this line carries only what changes the read.
|
|
const modalDescription = computed(() => {
|
|
const p = projectedCounts.value
|
|
return p
|
|
? `Artist “${props.artistName}” — ${p.images} images, `
|
|
+ `${p.posts} posts, ${p.sources} sources, `
|
|
+ `${Math.round(p.bytes_on_disk / 1_048_576)} MiB on disk`
|
|
: ''
|
|
})
|
|
|
|
async function onClick() {
|
|
loading.value = true
|
|
try {
|
|
projected.value = await store.projectArtistCascade(props.slug)
|
|
modalOpen.value = true
|
|
} finally {
|
|
loading.value = false
|
|
}
|
|
}
|
|
|
|
async function onConfirm(token) {
|
|
loading.value = true
|
|
try {
|
|
const result = await store.dispatchArtistCascade(props.slug, token)
|
|
const taskId = result.task_id
|
|
router.push('/artists')
|
|
if (taskId) {
|
|
store.pollTaskUntilDone(taskId).catch(() => {})
|
|
}
|
|
} finally {
|
|
loading.value = false
|
|
}
|
|
}
|
|
</script>
|
|
|
|
<style scoped>
|
|
.fc-danger-zone {
|
|
border-color: rgb(var(--v-theme-error));
|
|
border-radius: 8px;
|
|
}
|
|
</style>
|