bvandeusen
af7b5c95e9
Four coupled operator-asked changes to the view modal (Scribe plan #509): 1. **Autofocus tag entry on modal open** — TagAutocomplete grabs focus in onMounted/nextTick so the caret is in the input the moment the modal renders. No click needed to start typing. 2. **General suggestions expanded by default** — SuggestionsPanel's general-category group now mounts with `:default-open="true"`. Operator can collapse if too noisy, but the v1 frame shows them. 3. **Lower general threshold default 0.95 → 0.50** — MLSettings. suggestion_threshold_general default matches character. Alembic 0029 also bumps the existing singleton row's value if it's still at the old 0.95. Operator can re-tune from Settings → ML. 4. **Retire `copyright` + `artist` as ML suggestion categories** — neither feeds a Tag.kind (`artist` retired in FC-2d-vii-c, never really existed as a copyright tag-kind). They were surfaced in the suggestions pipeline + threshold settings UI but had no follow- through. Drop from SURFACED_CATEGORIES, suggestions._threshold_for, ml_admin GET/PATCH allowlist, MLSettings columns (alembic 0029 drops the two columns), frontend CATEGORY_ORDER + CATEGORY_LABELS, SuggestionsPanel.peopleCats, AliasPickerDialog kind-check, and MLThresholdSliders rows. Out of scope (intentional): `tag_kind` Postgres enum still includes `artist` for historic Tag row queryability (per the model comment); no operator pain reported, no enum-shrink needed. Tests: - test_surfaced_categories asserts {character, general}, excludes artist + copyright. - test_threshold_for_artist_is_unsurfaced extended to cover copyright. - test_get_and_patch_settings asserts new 0.50 default and the absent artist + copyright keys in the GET payload.
28 lines
857 B
Python
28 lines
857 B
Python
import pytest
|
|
|
|
pytestmark = pytest.mark.integration
|
|
|
|
|
|
def test_artist_not_surfaced():
|
|
from backend.app.services.ml.tagger import SURFACED_CATEGORIES
|
|
assert "artist" not in SURFACED_CATEGORIES
|
|
|
|
|
|
def test_artist_not_centroid_eligible():
|
|
from backend.app.models import TagKind
|
|
from backend.app.services.ml.centroids import ELIGIBLE_KINDS
|
|
assert TagKind.artist not in ELIGIBLE_KINDS
|
|
|
|
|
|
def test_threshold_for_artist_is_unsurfaced():
|
|
from backend.app.services.ml.suggestions import SuggestionService
|
|
|
|
class _S:
|
|
suggestion_threshold_character = 0.5
|
|
suggestion_threshold_general = 0.5
|
|
|
|
svc = SuggestionService.__new__(SuggestionService)
|
|
# 'artist' and 'copyright' both retired — fall through to 1.01
|
|
assert svc._threshold_for(_S(), "artist") == 1.01
|
|
assert svc._threshold_for(_S(), "copyright") == 1.01
|