Files
FabledCurator/tests/test_api_settings.py
T
bvandeusen 22bc24b6b6 fix(fc2a): align CI with FabledRulebook — lint + short unit tests only
The CI failure resolving 'postgres' hostname was the symptom; the cause is
that the workflow violated FabledRulebook/forgejo.md's "CI philosophy —
lint + short unit tests only" rule. Integration tests against a real
Postgres are supposed to run locally via docker-compose, not in CI.

Changes:
- Marked 8 DB-dependent test files with @pytest.mark.integration:
  test_tag_service, test_importer, test_gallery_service, test_api_gallery,
  test_api_tags, test_api_settings, test_api_import_admin, test_maintenance.
- CI workflow drops the postgres/redis service containers and the alembic
  upgrade smoke step entirely.
- Pytest invocation in CI changes to `pytest -v -m "not integration"`.
- Added pytest marker registration to pyproject.toml.
- DB_PASSWORD and SECRET_KEY env vars retained because config.py reads
  them at import time even though unit tests don't actually use them
  (set to placeholder values).

What CI now runs:
- ruff check
- pytest on the 6 unit test files: test_slug, test_paths,
  test_migration_0002, test_thumbnailer, test_celery_smoke,
  test_tasks_register.
- npm install + npm run build

What CI no longer runs:
- alembic upgrade (no live DB)
- the 8 integration test files (these run locally via docker-compose)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-14 15:23:07 -04:00

59 lines
1.6 KiB
Python

import pytest
from backend.app import create_app
pytestmark = pytest.mark.integration
@pytest.fixture
async def app():
return create_app()
@pytest.fixture
async def client(app):
async with app.test_client() as c:
yield c
@pytest.mark.asyncio
async def test_get_import_settings_defaults(client):
resp = await client.get("/api/settings/import")
assert resp.status_code == 200
body = await resp.get_json()
# Defaults from the migration:
assert body["min_width"] == 0
assert body["min_height"] == 0
assert body["skip_transparent"] is False
assert body["transparency_threshold"] == 0.9
@pytest.mark.asyncio
async def test_patch_import_settings(client):
resp = await client.patch(
"/api/settings/import",
json={"min_width": 500, "skip_transparent": True, "transparency_threshold": 0.7},
)
assert resp.status_code == 200
body = await resp.get_json()
assert body["min_width"] == 500
assert body["skip_transparent"] is True
assert body["transparency_threshold"] == 0.7
@pytest.mark.asyncio
async def test_patch_rejects_non_object(client):
resp = await client.patch("/api/settings/import", json=[1, 2, 3])
assert resp.status_code == 400
@pytest.mark.asyncio
async def test_system_stats_shape(client):
resp = await client.get("/api/system/stats")
assert resp.status_code == 200
body = await resp.get_json()
for key in ("total_images", "total_tags", "storage_bytes", "tasks", "active_batch"):
assert key in body
for status in ("pending", "queued", "processing", "complete", "skipped", "failed"):
assert status in body["tasks"]