bvandeusenandClaude Opus 5
ddf896078c
CI / lint (push) Successful in 3s
CI / extension-version (push) Successful in 4s
CI / frontend-build (push) Successful in 23s
extension / lint (push) Successful in 26s
CI / backend-lint-and-test (push) Successful in 28s
CI / integration (push) Successful in 3m43s
Executes the 2026-07-05 product decision (FC downloaders = art-dedicated
services only), which removed Twitter/X and Bluesky but left deviantart
fully wired for seven weeks — the half-retired state rule 22 exists to
prevent.
Removed: the PlatformInfo module and its registry entry, the gallery-dl
extractor block, extension_service's artist-page pattern, the extension's
PLATFORMS + PLATFORM_ARTIST_PATTERNS entries, its manifest host permission
and content-script match, the frontend icon/colour/label, and the operator-
facing "supported platforms" list that still advertised it.
Two judgment calls, both recorded in migration 0088:
* existing `source` rows are DISABLED, not deleted. The row is the only
record of the artist's DeviantArt URL. Disabling is also required for
correctness rather than tidiness: with the platform unregistered the
download path falls through to gallery-dl, which carries its OWN
deviantart extractor, so an enabled row would have kept downloading
from a dropped platform.
* the `credential` row IS deleted — a live session cookie for a site FC
will never call again.
Adds the invariant whose absence is why manifest.json drifted in the first
place: nothing tied its domain lists back to the platform table. The
extension suite now asserts both directions, plus that no host permission
belongs to an unclaimed domain (`*://*/*` exempted — FC is self-hosted at
an operator-chosen URL the extension cannot enumerate).
Extension version 1.0.10 -> 1.0.11: ci.yml's guard hard-fails a packaged
extension change without a bump. No release is cut — build.yml's
sign-extension job only runs on main.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
38 lines
1.2 KiB
Python
38 lines
1.2 KiB
Python
"""download_backends — the single predicate that routes a platform to the
|
|
native ingester vs. gallery-dl. Pure, no DB."""
|
|
|
|
from backend.app.services.download_backends import (
|
|
NATIVE_INGESTER_PLATFORMS,
|
|
_campaign_resolution_error,
|
|
_native_ingester_cls,
|
|
uses_native_ingester,
|
|
)
|
|
from backend.app.services.pixiv_ingester import PixivIngester
|
|
|
|
|
|
def test_native_platforms():
|
|
for platform in ("patreon", "subscribestar", "pixiv"):
|
|
assert uses_native_ingester(platform) is True
|
|
assert platform in NATIVE_INGESTER_PLATFORMS
|
|
|
|
|
|
def test_gallery_dl_platforms_are_not_native():
|
|
# The platforms still served by gallery-dl must NOT route to the native
|
|
# ingester — guards an accidental over-broad migration.
|
|
for platform in ("hentaifoundry", "discord"):
|
|
assert uses_native_ingester(platform) is False
|
|
|
|
|
|
def test_unknown_platform_is_not_native():
|
|
assert uses_native_ingester("nonsense") is False
|
|
|
|
|
|
def test_pixiv_dispatches_to_its_ingester():
|
|
assert _native_ingester_cls("pixiv") is PixivIngester
|
|
|
|
|
|
def test_pixiv_resolution_error_names_the_expected_url_shape():
|
|
msg = _campaign_resolution_error("pixiv", "https://www.pixiv.net/artworks/1")
|
|
assert "pixiv user id" in msg
|
|
assert "users/<id>" in msg
|