bvandeusen
1ac448d881
Items 2-5 of #3072. Item 1 (the per-row sweep inserts) is separate. 2. .fc-bad was not merely duplicated — it is .fc-weak under a second name. Both local definitions were `color: rgb(var(--v-theme-error))`, identical to the global .fc-weak, and GpuAgentCard was already using .fc-weak to colour exactly what GpuActivityPanel coloured .fc-bad (an errored count, red when non-zero). So rather than promoting a synonym to app.css, both call sites now use .fc-weak and the local defs are gone. app.css's status-colour comment records why there is no .fc-bad, next to the existing note on why .fc-ok is deliberately NOT global. 3. GalleryItem.vue's obsidian literals now use --v-theme-background, which IS obsidian (vuetify-theme.js maps background -> surfaces. obsidian). Preferred over --fc-chrome-rgb: same value, but that variable is named for the nav fade, not for the palette entry. The ticket said these were the only three real uses in the tree. They are not — GalleryItem itself had two more in the artist-label gradient (fixed here, so the file is now consistent), and ~13 more live in SeriesView, SeriesReaderView, ImageViewer, ArtistHeader, ExploreView and GalleryFilterBar. Those are a separate sweep, filed rather than folded in here. 4. The attachment download path had two hand-formatted copies. One definition now, `attachment_download_url`, next to the model both serializers already import. The test pins it by MATCHING the built path against the app's real URL map rather than comparing to a literal — a string-equality test would still pass after someone renamed the route, which is the drift the helper exists to prevent. 5. Extension API key now compares with hmac.compare_digest. Compared as BYTES, not str: compare_digest's str form raises TypeError on non-ASCII, and this value comes straight from an attacker-controlled header, so the str form would turn a junk key into a 500 instead of a 403. Low stakes either way — the API is unauthenticated-by-design on a LAN — but it costs nothing. Refs #3072
49 lines
1.7 KiB
Python
49 lines
1.7 KiB
Python
import pytest
|
|
|
|
from backend.app.models import Artist, PostAttachment, attachment_download_url
|
|
|
|
pytestmark = pytest.mark.integration
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_download_streams_with_disposition(client, db, tmp_path):
|
|
blob = tmp_path / "pack.zip"
|
|
blob.write_bytes(b"PK\x03\x04binarypayload")
|
|
a = Artist(name="Q", slug="q")
|
|
db.add(a)
|
|
await db.flush()
|
|
att = PostAttachment(
|
|
post_id=None, artist_id=a.id, sha256="q" + "0" * 63,
|
|
path=str(blob), original_filename="pack.zip", ext=".zip",
|
|
mime="application/zip", size_bytes=blob.stat().st_size,
|
|
)
|
|
db.add(att)
|
|
await db.flush()
|
|
await db.commit()
|
|
|
|
resp = await client.get(f"/api/attachments/{att.id}/download")
|
|
assert resp.status_code == 200
|
|
disp = resp.headers.get("Content-Disposition", "")
|
|
assert "attachment" in disp
|
|
assert "pack.zip" in disp
|
|
assert (await resp.get_data()) == b"PK\x03\x04binarypayload"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_download_404(client):
|
|
resp = await client.get("/api/attachments/999999/download")
|
|
assert resp.status_code == 404
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_attachment_download_url_routes_to_the_download_endpoint(app):
|
|
"""The two serializers no longer hand-format this path (#3072) — but a
|
|
single definition is only worth having if it still matches the route. Pin
|
|
it by MATCHING against the real URL map rather than comparing to a literal:
|
|
a string equality test would pass just as happily after someone renamed the
|
|
route, which is the exact drift the helper exists to prevent."""
|
|
built = attachment_download_url(4242)
|
|
endpoint, args = app.url_map.bind("localhost").match(built)
|
|
assert endpoint == "attachments.download"
|
|
assert args == {"attachment_id": 4242}
|