bvandeusen/FabledCurator
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 33 Wiki Activity

chore(modal): drop ?image=N soft-compat — pure overlay #55

Merged
bvandeusen merged 1 commits from dev into main 2026-06-02 19:35:04 -04:00
Conversation 0 Commits 1 Files Changed 2
+1 -34
bvandeusen commented 2026-06-02 19:34:58 -04:00
Owner
Copy Link
Copy Source

Summary

Follow-up to G5.4. Operator confirmed no existing ?image=N bookmarks to preserve, so the soft-compat read on initial mount + router.replace strip from PR #54 is dead weight. The modal is now purely a Pinia overlay — no URL involvement on open OR initial mount.

  • GalleryView.vue: 17 lines removed from onMounted + useRouter import dropped
  • ArtistGalleryTab.vue: entire onMounted block + useRoute/useRouter/onMounted imports dropped (component is leaner)

Net: -33 lines.

Test Plan

  • Visit /gallery?image=42 directly — modal should NOT auto-open (the URL is now meaningless)
  • Click an image in the gallery — modal opens, URL stays /gallery
  • Visit /artist/foo?image=99 directly — same: modal does not auto-open

🤖 Generated with Claude Code

## Summary Follow-up to G5.4. Operator confirmed no existing `?image=N` bookmarks to preserve, so the soft-compat read on initial mount + `router.replace` strip from PR #54 is dead weight. The modal is now purely a Pinia overlay — no URL involvement on open OR initial mount. - `GalleryView.vue`: 17 lines removed from `onMounted` + `useRouter` import dropped - `ArtistGalleryTab.vue`: entire `onMounted` block + `useRoute`/`useRouter`/`onMounted` imports dropped (component is leaner) Net: -33 lines. ## Test Plan - [ ] Visit `/gallery?image=42` directly — modal should NOT auto-open (the URL is now meaningless) - [ ] Click an image in the gallery — modal opens, URL stays `/gallery` - [ ] Visit `/artist/foo?image=99` directly — same: modal does not auto-open 🤖 Generated with [Claude Code](https://claude.com/claude-code)
bvandeusen added 1 commit 2026-06-02 19:34:58 -04:00
chore(modal): drop the ?image=N soft-compat from G5.4
CI / lint (push) Successful in 2s
Details
CI / backend-lint-and-test (push) Successful in 14s
Details
CI / frontend-build (push) Successful in 20s
Details
CI / intimp (push) Successful in 3m52s
Details
CI / intapi (push) Successful in 8m38s
Details
CI / intcore (push) Successful in 9m31s
Details
f1860866de 
Operator confirmed they have no existing ?image=N bookmarks to
preserve, so the soft-compat read on initial mount + router.replace
strip is dead weight. The modal is now purely a Pinia overlay — no
URL involvement on open OR initial mount.

Drops 33 lines plus the now-unused vue-router imports in both
ArtistGalleryTab (entire onMounted gone) and GalleryView (just the
?image=N block; the post_id/tag_id filter handling stays).
bvandeusen merged commit 37e66cddc4 into main 2026-06-02 19:35:04 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bvandeusen
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bvandeusen/FabledCurator#55
Delete Branch "dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?