fix(ci): POSIX-safe SHORT_SHA in build.yml #42

Merged

bvandeusen merged 1 commits from dev into main 2026-06-01 08:03:17 -04:00

Conversation 0 Commits 1 Files Changed 1

+10 -2

bvandeusen commented 2026-06-01 08:03:07 -04:00

Owner

Copy Link

Copy Source

Summary

Fix the regression from PR #40 — ${GITHUB_SHA:0:7} substring expansion is bash-only; the runner executes run: steps via dash/BusyBox sh and errored with Bad substitution on the 65386f0 main-push build (both build-web and build-ml failed at "Determine tag" before login/push fired).

Switched to SHORT_SHA=$(printf '%s' "$GITHUB_SHA" | cut -c1-7) which works in both shells. Both build-web and build-ml tag-determination steps updated.

Test plan

• After merge, build-web + build-ml fire and publish :main, :latest, :c-<short_sha> without errors.
• docker pull git.fabledsword.com/bvandeusen/fabledcurator:c-<short_sha> resolves the new per-commit tag.

## Summary Fix the regression from PR #40 — `${GITHUB_SHA:0:7}` substring expansion is bash-only; the runner executes `run:` steps via dash/BusyBox sh and errored with `Bad substitution` on the 65386f0 main-push build (both `build-web` and `build-ml` failed at "Determine tag" before login/push fired). Switched to `SHORT_SHA=$(printf '%s' "$GITHUB_SHA" | cut -c1-7)` which works in both shells. Both build-web and build-ml tag-determination steps updated. ## Test plan - [ ] After merge, build-web + build-ml fire and publish `:main`, `:latest`, `:c-<short_sha>` without errors. - [ ] `docker pull git.fabledsword.com/bvandeusen/fabledcurator:c-<short_sha>` resolves the new per-commit tag.

bvandeusen added 1 commit 2026-06-01 08:03:07 -04:00

fix(ci): POSIX-safe SHORT_SHA in build.yml (runner uses dash, not bash) ... 9564d073b9

`${GITHUB_SHA:0:7}` substring expansion is bash-only; the runner
executes the step via dash/BusyBox sh and errored with
`Bad substitution` (act_runner workflow shell, observed on the
65386f0 main-push run). Switched to
`SHORT_SHA=$(printf '%s' "$GITHUB_SHA" | cut -c1-7)` which works in
both shells. Both build-web and build-ml tag-determination steps
updated.

bvandeusen merged commit b1d58bc3b8 into main 2026-06-01 08:03:17 -04:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

renovate-bot bvandeusen

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: bvandeusen/FabledCurator#42