pixiv retired, placement reconciler removed, build race fixed, mirror pinned #257
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: bvandeusen/FabledCurator#257
Reference in New Issue
Block a user
Five commits, all CI-green on
dev.11a01a9— remove the placement reconciler. It compared each image'sartist_idto the name of the directory its file sat in and called every mismatch misplaced: 33,789 of 63,605 images. 97.1% of that was one artist's folder spelled two ways (Telepurte/vstelepurte/), and queryingImageProvenanceshowed roughly 41% of the remainder would have been misfiled by the tool. Dropslibrary_placement_run(alembic 0100).utils.paths.canonical_subdiris deliberately kept.5aa8e3d— a stopped source is not a failing one (#4279). Ebi77 sat in the failure banner for six days with nothing able to clear it: disabled sources are never scheduled so no run resets the counter, and the card's Retry routes to/check, which refuses a disabled source. Four defects, one symptom —failing_sources_clause()now means enabled-AND-erroring,/backfillgained anenabledguard, and alembic 0101 clears the rows already carrying the state.24b10d0— retire pixiv entirely (milestone #406, steps 5–7). Phase 1 unregistered it in September; this deletes the client, downloader, ingester and platform module, drops both ledger tables, and deletes credentials for every unregistered platform — which also clears DeviantArt's leftover session (#3980), still sitting there seven weeks after #3069 retired it in code. PixivSourcerows are kept on the operator's call:platformis stored only onSource, so deleting would drop every pixiv image into the gallery's__unsourced__bucket. Alembic 0102.bd92fb4— pin the JS↔Py artist-pattern mirror (#3093). Two hand-kept copies of one regex table gate opposite halves of one interaction: the JS copy decides whether the "Add to FC" button appears, the Python copy decides whether the POST is accepted. 25 shared URL samples, asserted by both suites against their own copy.aa2bb66— serialise builds, and pin:c-<sha>to the digest (#4290). Nothing ordered concurrent builds, so two pushes both missed the reuse check and both built — and the repoint step copied:c-<sha>from the channel tag by name, meaning a lost race wrote an immutable rollback tag naming another commit's bytes. Adds aconcurrencygroup and makes the repoint copy the digest this run actually pushed.Net: 1,030 insertions, 4,207 deletions.
Alembic 0100 → 0102 run on deploy. 0102 deletes the stale pixiv and DeviantArt credential rows.
🤖 Generated with Claude Code
https://claude.ai/code/session_01LVjrnpQjRgHdvq95rASoiR
Two independent defects from one missing mechanism. `grep -rn concurrency .forgejo/workflows/` returned nothing, so two pushes to a branch ran build.yml in full parallel with no ordering. Both jobs read `fc.revision` off the channel tag before either has pushed, so both miss the reuse check and both build. Whichever finishes LAST owns the tag. Half 1 — the rolling tag. A slower older build leaves `:dev` carrying content older than the commit that moved it. Family rule 146 says a rolling channel refreshes itself; this is the case where it quietly does not. Self-healing on the next push. Half 2, and the reason this is not filed low — `:c-<sha>`. The repoint step wrote every non-channel tag by copying the channel tag BY NAME, so the immutable rollback tag named whatever `:latest` pointed at when that step happened to run. Lose the race and `:c-<shaA>` names the OTHER run's bytes. Rule 145 makes that tag the rollback unit and immutable, so this does not break immutability — it makes the tag wrong from birth, and immutability then guarantees nobody ever corrects it. Nothing goes red; it surfaces the day someone rolls back and gets a commit they did not choose. Not self-healing. Two fixes, deliberately both: A. A workflow-level `concurrency` group keyed on `github.ref`, so dev and main never block each other. `cancel-in-progress: false` — queue, never cancel: cancelling could kill sign-extension mid-AMO-upload, leaving the version registered at AMO with no cached asset, which is the unrecoverable stuck state that job's rollback trap exists to prevent, reached by another door. Not keyed on BUILD_REF because the group is evaluated before any job starts and cannot read the `env` context. B. Each build-push-action step gains `id: build`, and the repoint step copies from `$IMAGE@${{ steps.build.outputs.digest }}` — the manifest THIS run pushed — rather than from the channel tag by name. On a reuse hit there is no digest and the channel tag remains correct by definition: "hit" means that tag already carries this commit's fc.revision. B is not redundant with A. A depends on this Gitea honouring a key whose failure mode is silent, and this file has been burned by exactly that before (the `format()` note records `true == 'true'` evaluating FALSE on run 5270, every lane green, the feature simply not happening). B holds the :c-<sha> correctness property whether or not A is honoured. The loop's exclusion is now keyed on CHANNEL_REF rather than on SOURCE, and that is load-bearing: SOURCE may now be a digest ref, which never equals a tag string, so testing against it would stop excluding the channel tag. imagetools would index-wrap it and `.Image.Config.Labels` would stop resolving, killing the reuse label permanently — #3183 arriving again. Neither half is verifiable on a dev push: dev's tag list is the channel tag alone, so the repoint correctly does nothing there. B is observable on the next merge to main (:c-<sha>'s digest must equal the build step's), and A by pushing twice in quick succession and reading the run list for a queued second run. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LVjrnpQjRgHdvq95rASoiR