bvandeusen/FabledCurator
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 33 Wiki Activity

fix(ext-ci): drop actions/upload-artifact (Forgejo doesn't support v4+ GHES) #19

Merged
bvandeusen merged 0 commits from dev into main 2026-05-25 23:33:41 -04:00
Conversation 0 Commits - Files Changed -
bvandeusen commented 2026-05-25 23:33:28 -04:00 (Migrated from git.fabledsword.com)
Copy Link
Copy Source

Why

PR #18 unblocked the AMO sign + Forgejo asset upload, but the next step failed:

::error::@actions/artifact v2.0.0+, upload-artifact@v4+ and download-artifact@v4+ are not currently supported on GHES.

Forgejo Actions / act_runner doesn't implement GitHub's v4 artifact service. Downgrading to v3 might work but is also flaky on some runner versions.

Fix

The Actions-artifact handoff between sign-extension and build-web was redundant — sign-extension already uploaded the signed XPI to the ext-<version> Forgejo release as an asset. Just have build-web download from that same source of truth.

  • Remove actions/upload-artifact@v4 from sign-extension
  • Remove actions/download-artifact@v4 from build-web
  • build-web now does: GET /releases/tags/ext-<version> → extract asset id via python → curl download asset → place in frontend/public/extension/
  • Also removed the now-redundant "Download cached signed XPI" step from sign-extension (it was for cache-hit cases; build-web fetches independently so sign-extension only needs to ensure the cache exists)

Cache state right now

  • AMO has v1.0.3 signed
  • ext-1.0.3 Forgejo release EXISTS with fabledcurator-1.0.3.xpi asset (verified — the asset upload happened BEFORE the artifact step that failed)

So the next build.yml run on main will hit cache: sign-extension takes the no-op path; build-web downloads and bundles. Should land a :latest image with the XPI on first try.

After merge + CI green, I'll cut v26.05.25.6.

🤖 Generated with Claude Code

## Why PR #18 unblocked the AMO sign + Forgejo asset upload, but the next step failed: ``` ::error::@actions/artifact v2.0.0+, upload-artifact@v4+ and download-artifact@v4+ are not currently supported on GHES. ``` Forgejo Actions / act_runner doesn't implement GitHub's v4 artifact service. Downgrading to v3 might work but is also flaky on some runner versions. ## Fix The Actions-artifact handoff between `sign-extension` and `build-web` was redundant — `sign-extension` already uploaded the signed XPI to the `ext-<version>` Forgejo release as an asset. Just have `build-web` download from that same source of truth. - Remove `actions/upload-artifact@v4` from `sign-extension` - Remove `actions/download-artifact@v4` from `build-web` - `build-web` now does: GET `/releases/tags/ext-<version>` → extract asset id via python → curl download asset → place in `frontend/public/extension/` - Also removed the now-redundant "Download cached signed XPI" step from sign-extension (it was for cache-hit cases; build-web fetches independently so sign-extension only needs to ensure the cache exists) ## Cache state right now - AMO has v1.0.3 signed - `ext-1.0.3` Forgejo release EXISTS with `fabledcurator-1.0.3.xpi` asset (verified — the asset upload happened BEFORE the artifact step that failed) So the next `build.yml` run on main will hit cache: sign-extension takes the no-op path; build-web downloads and bundles. Should land a `:latest` image with the XPI on first try. After merge + CI green, I'll cut `v26.05.25.6`. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bvandeusen
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bvandeusen/FabledCurator#19
Delete Branch "dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?