bvandeusen/FabledCurator
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 33 Wiki Activity

fix(ext-ci): match AMO-renamed signed XPI #14

Merged
bvandeusen merged 0 commits from dev into main 2026-05-25 18:22:50 -04:00
Conversation 0 Commits - Files Changed -
bvandeusen commented 2026-05-25 18:22:28 -04:00 (Migrated from git.fabledsword.com)
Copy Link
Copy Source

Summary

The extension workflow signed v1.0.1 successfully but the commit step failed because AMO renames signed XPIs to use its internal addon-id-safe-string (997017ca3e104e30a75a-1.0.1.xpi), not the gecko ID we set in manifest.json. The original glob fabledcurator-*.xpi never matched.

Fix: glob *.xpi in the artifacts dir (fresh CI runner = one XPI per run), parse version from extension/package.json, and copy under the canonical fabledcurator-${VERSION}.xpi name so the backend's whitelist (backend/app/frontend.py matches fabledcurator-*.xpi) keeps working. Also wipes prior fabledcurator-*.xpi files in the dir so it doesn't accumulate.

Trigger after merge

The workflow's path filter is extension/**, so this .forgejo/workflows/extension.yml change alone won't auto-trigger it. After merging:

  1. Forgejo → Actions → extension → Run workflow on main (the workflow has workflow_dispatch wired).
  2. AMO returns the cached signed XPI for v1.0.1 (no new signing required for the same version).
  3. Commit step now succeeds → XPI lands on main as a side-commit.
  4. Then cut v26.05.25.3 pointing at the post-XPI HEAD.

🤖 Generated with Claude Code

## Summary The extension workflow signed v1.0.1 successfully but the commit step failed because AMO renames signed XPIs to use its internal addon-id-safe-string (`997017ca3e104e30a75a-1.0.1.xpi`), not the gecko ID we set in `manifest.json`. The original glob `fabledcurator-*.xpi` never matched. Fix: glob `*.xpi` in the artifacts dir (fresh CI runner = one XPI per run), parse version from `extension/package.json`, and copy under the canonical `fabledcurator-${VERSION}.xpi` name so the backend's whitelist (`backend/app/frontend.py` matches `fabledcurator-*.xpi`) keeps working. Also wipes prior `fabledcurator-*.xpi` files in the dir so it doesn't accumulate. ## Trigger after merge The workflow's path filter is `extension/**`, so this `.forgejo/workflows/extension.yml` change alone won't auto-trigger it. After merging: 1. Forgejo → Actions → extension → **Run workflow** on main (the workflow has `workflow_dispatch` wired). 2. AMO returns the cached signed XPI for v1.0.1 (no new signing required for the same version). 3. Commit step now succeeds → XPI lands on main as a side-commit. 4. Then cut `v26.05.25.3` pointing at the post-XPI HEAD. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bvandeusen
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bvandeusen/FabledCurator#14
Delete Branch "dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?