refactor: test row factories and the fetch stub have one copy each (3109)

tests/factories.py holds image_row/make_image/make_image_async/make_tag. The
17 byte-identical _img/_tag helpers (15 modules) now import them under their
old names, so no call site changed. frontend/test/support/stubFetch.js
replaces 15 copies that differed only in formatting. Copies whose bodies
differ (other defaults, other columns, a url-only stub) are left as they
are; folding those needs a look at each caller.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LVjrnpQjRgHdvq95rASoiR

frontend/test/adminStore.spec.js

@@ -1,23 +1,12 @@
 import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest'
 import { setActivePinia, createPinia } from 'pinia'
 import { useAdminStore } from '../src/stores/admin.js'
+import { stubFetch } from './support/stubFetch.js'
 
 // Covers the two helpers the admin store actions route through (DRY Finding C,
 // #753): _dryRunPost (URL + dry_run body, sourceId→source_id) and _guard
 // (lastError capture + rethrow). The store had no frontend test before.
 
-function stubFetch(handler) {
-  globalThis.fetch = vi.fn(async (url, init) => {
-    const { status, body } = handler(url, init)
-    return {
-      ok: status >= 200 && status < 300,
-      status,
-      statusText: String(status),
-      text: async () => (body == null ? '' : JSON.stringify(body)),
-    }
-  })
-}
-
 function lastCallBody(calls) {
   return JSON.parse(calls.at(-1).init.body)
 }

frontend/test/credentials.spec.js

@@ -1,17 +1,7 @@
 import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest'
 import { setActivePinia, createPinia } from 'pinia'
 import { useCredentialsStore } from '../src/stores/credentials.js'
-
-function stubFetch(handler) {
-  globalThis.fetch = vi.fn(async (url, init) => {
-    const { status, body } = handler(url, init)
-    return {
-      ok: status >= 200 && status < 300,
-      status, statusText: String(status),
-      text: async () => (body == null ? '' : JSON.stringify(body)),
-    }
-  })
-}
+import { stubFetch } from './support/stubFetch.js'
 
 describe('credentials store', () => {
   beforeEach(() => setActivePinia(createPinia()))

frontend/test/dbMaintenance.spec.js

@@ -1,18 +1,7 @@
 import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest'
 import { setActivePinia, createPinia } from 'pinia'
 import { useDbMaintenanceStore } from '../src/stores/dbMaintenance.js'
-
-function stubFetch(handler) {
-  globalThis.fetch = vi.fn(async (url, init) => {
-    const { status, body } = handler(url, init)
-    return {
-      ok: status >= 200 && status < 300,
-      status,
-      statusText: String(status),
-      text: async () => (body == null ? '' : JSON.stringify(body)),
-    }
-  })
-}
+import { stubFetch } from './support/stubFetch.js'
 
 describe('dbMaintenance store', () => {
   beforeEach(() => setActivePinia(createPinia()))

frontend/test/downloads.spec.js

@@ -1,17 +1,7 @@
 import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest'
 import { setActivePinia, createPinia } from 'pinia'
 import { useDownloadsStore } from '../src/stores/downloads.js'
-
-function stubFetch(handler) {
-  globalThis.fetch = vi.fn(async (url, init) => {
-    const { status, body } = handler(url, init)
-    return {
-      ok: status >= 200 && status < 300,
-      status, statusText: String(status),
-      text: async () => (body == null ? '' : JSON.stringify(body)),
-    }
-  })
-}
+import { stubFetch } from './support/stubFetch.js'
 
 describe('downloads store', () => {
   beforeEach(() => setActivePinia(createPinia()))

frontend/test/gallery.spec.js

@@ -1,18 +1,7 @@
 import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest'
 import { setActivePinia, createPinia } from 'pinia'
 import { cloneFilter, filterToQuery, useGalleryStore } from '../src/stores/gallery.js'
-
-function stubFetch(handler) {
-  globalThis.fetch = vi.fn(async (url, init) => {
-    const { status, body } = handler(url, init)
-    return {
-      ok: status >= 200 && status < 300,
-      status,
-      statusText: String(status),
-      text: async () => (body == null ? '' : JSON.stringify(body)),
-    }
-  })
-}
+import { stubFetch } from './support/stubFetch.js'
 
 const EMPTY = { images: [], date_groups: [], next_cursor: null }
 

frontend/test/gallerySelection.spec.js

@@ -1,18 +1,7 @@
 import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest'
 import { setActivePinia, createPinia } from 'pinia'
 import { useGallerySelectionStore } from '../src/stores/gallerySelection.js'
-
-function stubFetch(handler) {
-  globalThis.fetch = vi.fn(async (url, init) => {
-    const { status, body } = handler(url, init)
-    return {
-      ok: status >= 200 && status < 300,
-      status,
-      statusText: String(status),
-      text: async () => (body == null ? '' : JSON.stringify(body))
-    }
-  })
-}
+import { stubFetch } from './support/stubFetch.js'
 
 describe('gallerySelection store', () => {
   beforeEach(() => setActivePinia(createPinia()))

frontend/test/platforms.spec.js

@@ -1,17 +1,7 @@
 import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest'
 import { setActivePinia, createPinia } from 'pinia'
 import { usePlatformsStore } from '../src/stores/platforms.js'
-
-function stubFetch(handler) {
-  globalThis.fetch = vi.fn(async (url, init) => {
-    const { status, body } = handler(url, init)
-    return {
-      ok: status >= 200 && status < 300,
-      status, statusText: String(status),
-      text: async () => (body == null ? '' : JSON.stringify(body)),
-    }
-  })
-}
+import { stubFetch } from './support/stubFetch.js'
 
 describe('platforms store', () => {
   beforeEach(() => setActivePinia(createPinia()))

frontend/test/provenance.spec.js

@@ -1,18 +1,7 @@
 import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest'
 import { setActivePinia, createPinia } from 'pinia'
 import { useProvenanceStore } from '../src/stores/provenance.js'
-
-function stubFetch(handler) {
-  globalThis.fetch = vi.fn(async (url, init) => {
-    const { status, body } = handler(url, init)
-    return {
-      ok: status >= 200 && status < 300,
-      status,
-      statusText: String(status),
-      text: async () => (body == null ? '' : JSON.stringify(body))
-    }
-  })
-}
+import { stubFetch } from './support/stubFetch.js'
 
 describe('provenance store', () => {
   beforeEach(() => setActivePinia(createPinia()))

frontend/test/seriesManage.spec.js

@@ -1,17 +1,7 @@
 import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest'
 import { setActivePinia, createPinia } from 'pinia'
 import { useSeriesManageStore, moveItem } from '../src/stores/seriesManage.js'
-
-function stubFetch(handler) {
-  globalThis.fetch = vi.fn(async (url, init) => {
-    const { status, body } = handler(url, init)
-    return {
-      ok: status >= 200 && status < 300,
-      status, statusText: String(status),
-      text: async () => (body == null ? '' : JSON.stringify(body))
-    }
-  })
-}
+import { stubFetch } from './support/stubFetch.js'
 
 // FC-6.x: a flat page run + cosmetic chapter dividers.
 const SERIES_BODY = {

frontend/test/seriesReader.spec.js

@@ -6,17 +6,7 @@ import {
   progressPct,
   clampPage
 } from '../src/stores/seriesReader.js'
-
-function stubFetch(handler) {
-  globalThis.fetch = vi.fn(async (url, init) => {
-    const { status, body } = handler(url, init)
-    return {
-      ok: status >= 200 && status < 300,
-      status, statusText: String(status),
-      text: async () => (body == null ? '' : JSON.stringify(body))
-    }
-  })
-}
+import { stubFetch } from './support/stubFetch.js'
 
 const M = [
   { page_number: 1, top: 0, height: 100 },

frontend/test/sources.spec.js

@@ -1,17 +1,7 @@
 import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest'
 import { setActivePinia, createPinia } from 'pinia'
 import { useSourcesStore } from '../src/stores/sources.js'
-
-function stubFetch(handler) {
-  globalThis.fetch = vi.fn(async (url, init) => {
-    const { status, body } = handler(url, init)
-    return {
-      ok: status >= 200 && status < 300,
-      status, statusText: String(status),
-      text: async () => (body == null ? '' : JSON.stringify(body)),
-    }
-  })
-}
+import { stubFetch } from './support/stubFetch.js'
 
 describe('sources store', () => {
   beforeEach(() => setActivePinia(createPinia()))

frontend/test/suggestions.spec.js

@@ -1,21 +1,10 @@
 import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest'
 import { setActivePinia, createPinia } from 'pinia'
 import { useSuggestionsStore } from '../src/stores/suggestions.js'
+import { stubFetch } from './support/stubFetch.js'
 
 vi.mock('../src/utils/toast.js', () => ({ toast: vi.fn() }))
 
-function stubFetch(handler) {
-  globalThis.fetch = vi.fn(async (url, init) => {
-    const { status, body } = handler(url, init)
-    return {
-      ok: status >= 200 && status < 300,
-      status,
-      statusText: String(status),
-      text: async () => (body == null ? '' : JSON.stringify(body)),
-    }
-  })
-}
-
 // Every suggestion is a canonical DB tag now (tagging-v2): a real id, flagged
 // above/below its head's suggest threshold. No raw / creates-new / alias cases.
 const sugg = (over = {}) => ({

frontend/test/support/stubFetch.js

@@ -0,0 +1,16 @@
+// Replace globalThis.fetch with a stub answering from `handler(url, init)`,
+// which returns { status, body }. Fifteen specs carried their own copy of this
+// (#3109); a response shape change now has one place to go.
+import { vi } from 'vitest'
+
+export function stubFetch (handler) {
+  globalThis.fetch = vi.fn(async (url, init) => {
+    const { status, body } = handler(url, init)
+    return {
+      ok: status >= 200 && status < 300,
+      status,
+      statusText: String(status),
+      text: async () => (body == null ? '' : JSON.stringify(body))
+    }
+  })
+}

frontend/test/tagDirectory.spec.js

@@ -1,18 +1,7 @@
 import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest'
 import { setActivePinia, createPinia } from 'pinia'
 import { useTagDirectoryStore } from '../src/stores/tagDirectory.js'
-
-function stubFetch(handler) {
-  globalThis.fetch = vi.fn(async (url, init) => {
-    const { status, body } = handler(url, init)
-    return {
-      ok: status >= 200 && status < 300,
-      status,
-      statusText: String(status),
-      text: async () => (body == null ? '' : JSON.stringify(body))
-    }
-  })
-}
+import { stubFetch } from './support/stubFetch.js'
 
 describe('tagDirectory store: rename / merge', () => {
   beforeEach(() => setActivePinia(createPinia()))

frontend/test/tags.spec.js

@@ -1,18 +1,7 @@
 import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest'
 import { setActivePinia, createPinia } from 'pinia'
 import { useTagStore } from '../src/stores/tags.js'
-
-function stubFetch(handler) {
-  globalThis.fetch = vi.fn(async (url, init) => {
-    const { status, body } = handler(url, init)
-    return {
-      ok: status >= 200 && status < 300,
-      status,
-      statusText: String(status),
-      text: async () => (body == null ? '' : JSON.stringify(body)),
-    }
-  })
-}
+import { stubFetch } from './support/stubFetch.js'
 
 describe('tags store: setFandom', () => {
   beforeEach(() => setActivePinia(createPinia()))

frontend/test/workerLanes.spec.js

@@ -1,6 +1,7 @@
 import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest'
 import { setActivePinia, createPinia } from 'pinia'
 import { laneStuckFor, useSystemActivityStore } from '../src/stores/systemActivity.js'
+import { stubFetch } from './support/stubFetch.js'
 
 // Milestone 422 step 4. Covers the store half of the worker-lane dial — the
 // part that decides what the card can tell the operator.
@@ -18,18 +19,6 @@ import { laneStuckFor, useSystemActivityStore } from '../src/stores/systemActivi
 // as one. A control that silently does nothing is worse than one that
 // refuses out loud.
 
-function stubFetch(handler) {
-  globalThis.fetch = vi.fn(async (url, init) => {
-    const { status, body } = handler(url, init)
-    return {
-      ok: status >= 200 && status < 300,
-      status,
-      statusText: String(status),
-      text: async () => (body == null ? '' : JSON.stringify(body)),
-    }
-  })
-}
-
 const LANES_BODY = {
   lanes: [
     {